Commit 3f890ce
[AiAssistance] Fix changing panels breaking conversation when loading
I think, while doing refactoring, we updated the logic to save the
initial message to history after receiving the response from AidaClient.
This made `isEmpty` to return `false` when there is a loading request in
flight. So, whenever the user changed the panel while a request is in
flight; it changed the `#currentAgent`.
This CL fixes it by adding `isLoading` check to the
`#selectDefaultAgentIfNeeded` method.
Fixed: 395886018
Change-Id: Iedc50c968eec7bec9faa72f9dba3c9af84b38e2d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6253022
Auto-Submit: Ergün Erdoğmuş <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>1 parent ad845bf commit 3f890ce
1 file changed
+4
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
400 | 400 | | |
401 | 401 | | |
402 | 402 | | |
403 | | - | |
404 | | - | |
405 | | - | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
406 | 407 | | |
407 | 408 | | |
408 | 409 | | |
| |||
0 commit comments