Skip to content

Commit 3fb14b0

Browse files
szuendDevtools-frontend LUCI CQ
authored andcommitted
Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance. In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8720003962868709441 [email protected] Bug: none Change-Id: I15d3bbd4bb5c29018d49cb706e0b2444eb56fbf7 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6368178 Reviewed-by: Danil Somsikov <[email protected]> Commit-Queue: Simon Zünd <[email protected]> Reviewed-by: Kim-Anh Tran <[email protected]>
1 parent 6ab2b40 commit 3fb14b0

File tree

11 files changed

+97
-8
lines changed

11 files changed

+97
-8
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ vars = {
2424
'inspector_protocol_revision': '940abfc668be2591483f7132145593c6a047f3cf',
2525

2626
# Keeping track of the last time we rollerd the browser protocol files.
27-
'chromium_browser_protocol_revision' : '02eeb8baedf61eb9b6fbb97409ed0b382c05f38b',
27+
'chromium_browser_protocol_revision' : 'c855ab36dac455eed8e4330b747b137802146ad0',
2828

2929
'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
3030
'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',

front_end/generated/InspectorBackendCommands.js

Lines changed: 5 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

front_end/generated/protocol-mapping.d.ts

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2245,6 +2245,24 @@ export namespace ProtocolMapping {
22452245
paramsType: [];
22462246
returnType: void;
22472247
};
2248+
/**
2249+
* Start using the given display features to pupulate the Viewport Segments API.
2250+
* This override can also be set in setDeviceMetricsOverride().
2251+
*/
2252+
'Emulation.setDisplayFeaturesOverride': {
2253+
paramsType: [Protocol.Emulation.SetDisplayFeaturesOverrideRequest];
2254+
returnType: void;
2255+
};
2256+
/**
2257+
* Clears the display features override set with either setDeviceMetricsOverride()
2258+
* or setDisplayFeaturesOverride() and starts using display features from the
2259+
* platform again.
2260+
* Does nothing if no override is set.
2261+
*/
2262+
'Emulation.clearDisplayFeaturesOverride': {
2263+
paramsType: [];
2264+
returnType: void;
2265+
};
22482266
'Emulation.setScrollbarsHidden': {
22492267
paramsType: [Protocol.Emulation.SetScrollbarsHiddenRequest];
22502268
returnType: void;

front_end/generated/protocol-proxy-api.d.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1542,6 +1542,20 @@ declare namespace ProtocolProxyApi {
15421542
*/
15431543
invoke_clearDevicePostureOverride(): Promise<Protocol.ProtocolResponseWithError>;
15441544

1545+
/**
1546+
* Start using the given display features to pupulate the Viewport Segments API.
1547+
* This override can also be set in setDeviceMetricsOverride().
1548+
*/
1549+
invoke_setDisplayFeaturesOverride(params: Protocol.Emulation.SetDisplayFeaturesOverrideRequest): Promise<Protocol.ProtocolResponseWithError>;
1550+
1551+
/**
1552+
* Clears the display features override set with either setDeviceMetricsOverride()
1553+
* or setDisplayFeaturesOverride() and starts using display features from the
1554+
* platform again.
1555+
* Does nothing if no override is set.
1556+
*/
1557+
invoke_clearDisplayFeaturesOverride(): Promise<Protocol.ProtocolResponseWithError>;
1558+
15451559
invoke_setScrollbarsHidden(params: Protocol.Emulation.SetScrollbarsHiddenRequest): Promise<Protocol.ProtocolResponseWithError>;
15461560

15471561
invoke_setDocumentCookieDisabled(params: Protocol.Emulation.SetDocumentCookieDisabledRequest): Promise<Protocol.ProtocolResponseWithError>;

front_end/generated/protocol.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1140,6 +1140,7 @@ export namespace Audits {
11401140

11411141
export interface SRIMessageSignatureIssueDetails {
11421142
error: SRIMessageSignatureError;
1143+
signatureBase: string;
11431144
request: AffectedRequest;
11441145
}
11451146

@@ -6534,6 +6535,7 @@ export namespace Emulation {
65346535
/**
65356536
* If set, the display feature of a multi-segment screen. If not set, multi-segment support
65366537
* is turned-off.
6538+
* Deprecated, use Emulation.setDisplayFeaturesOverride.
65376539
*/
65386540
displayFeature?: DisplayFeature;
65396541
/**
@@ -6548,6 +6550,10 @@ export namespace Emulation {
65486550
posture: DevicePosture;
65496551
}
65506552

6553+
export interface SetDisplayFeaturesOverrideRequest {
6554+
features: DisplayFeature[];
6555+
}
6556+
65516557
export interface SetScrollbarsHiddenRequest {
65526558
/**
65536559
* Whether scrollbars should be always hidden.
@@ -17945,6 +17951,7 @@ export namespace Preload {
1794517951
PrefetchFailedMIMENotSupported = 'PrefetchFailedMIMENotSupported',
1794617952
PrefetchFailedNetError = 'PrefetchFailedNetError',
1794717953
PrefetchFailedNon2XX = 'PrefetchFailedNon2XX',
17954+
PrefetchEvictedAfterBrowsingDataRemoved = 'PrefetchEvictedAfterBrowsingDataRemoved',
1794817955
PrefetchEvictedAfterCandidateRemoved = 'PrefetchEvictedAfterCandidateRemoved',
1794917956
PrefetchEvictedForNewerPrefetch = 'PrefetchEvictedForNewerPrefetch',
1795017957
PrefetchHeldback = 'PrefetchHeldback',

front_end/models/issues_manager/SRIMessageSignatureIssue.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ describeWithLocale('SRIMessageSignatureIssue', () => {
4949
requestId: 'test-request-id' as Protocol.Network.RequestId,
5050
url: 'https://example.com/',
5151
},
52+
signatureBase: 'test-signature-base',
5253
};
5354
const issue = createProtocolIssue(issueDetails);
5455
const sriMessageSignatureIssues =

front_end/models/javascript_metadata/NativeFunctions.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8478,6 +8478,10 @@ export const NativeFunctions = [
84788478
name: "contributeToHistogram",
84798479
signatures: [["contribution"]]
84808480
},
8481+
{
8482+
name: "contributeToHistogramOnEvent",
8483+
signatures: [["event","contribution"]]
8484+
},
84818485
{
84828486
name: "enableDebugMode",
84838487
signatures: [["?options"]]

front_end/panels/application/preloading/components/PreloadingString.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -519,6 +519,9 @@ export function prefetchFailureReason({prefetchStatus}: SDK.PreloadingModel.Pref
519519
return PrefetchReasonDescription['PrefetchNotEligibleRedirectFromServiceWorker'].name();
520520
case Protocol.Preload.PrefetchStatus.PrefetchNotEligibleRedirectToServiceWorker:
521521
return PrefetchReasonDescription['PrefetchNotEligibleRedirectToServiceWorker'].name();
522+
case Protocol.Preload.PrefetchStatus.PrefetchEvictedAfterBrowsingDataRemoved:
523+
// TODO(crbug.com/40262310): Add description.
524+
return null;
522525
default:
523526
// Note that we use switch and exhaustiveness check to prevent to
524527
// forget updating these strings, but allow to handle unknown

third_party/blink/public/devtools_protocol/browser_protocol.json

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1678,6 +1678,10 @@
16781678
"name": "error",
16791679
"$ref": "SRIMessageSignatureError"
16801680
},
1681+
{
1682+
"name": "signatureBase",
1683+
"type": "string"
1684+
},
16811685
{
16821686
"name": "request",
16831687
"$ref": "AffectedRequest"
@@ -9962,8 +9966,9 @@
99629966
},
99639967
{
99649968
"name": "displayFeature",
9965-
"description": "If set, the display feature of a multi-segment screen. If not set, multi-segment support\nis turned-off.",
9969+
"description": "If set, the display feature of a multi-segment screen. If not set, multi-segment support\nis turned-off.\nDeprecated, use Emulation.setDisplayFeaturesOverride.",
99669970
"experimental": true,
9971+
"deprecated": true,
99679972
"optional": true,
99689973
"$ref": "DisplayFeature"
99699974
},
@@ -9993,6 +9998,25 @@
99939998
"description": "Clears a device posture override set with either setDeviceMetricsOverride()\nor setDevicePostureOverride() and starts using posture information from the\nplatform again.\nDoes nothing if no override is set.",
99949999
"experimental": true
999510000
},
10001+
{
10002+
"name": "setDisplayFeaturesOverride",
10003+
"description": "Start using the given display features to pupulate the Viewport Segments API.\nThis override can also be set in setDeviceMetricsOverride().",
10004+
"experimental": true,
10005+
"parameters": [
10006+
{
10007+
"name": "features",
10008+
"type": "array",
10009+
"items": {
10010+
"$ref": "DisplayFeature"
10011+
}
10012+
}
10013+
]
10014+
},
10015+
{
10016+
"name": "clearDisplayFeaturesOverride",
10017+
"description": "Clears the display features override set with either setDeviceMetricsOverride()\nor setDisplayFeaturesOverride() and starts using display features from the\nplatform again.\nDoes nothing if no override is set.",
10018+
"experimental": true
10019+
},
999610020
{
999710021
"name": "setScrollbarsHidden",
999810022
"experimental": true,
@@ -27169,6 +27193,7 @@
2716927193
"PrefetchFailedMIMENotSupported",
2717027194
"PrefetchFailedNetError",
2717127195
"PrefetchFailedNon2XX",
27196+
"PrefetchEvictedAfterBrowsingDataRemoved",
2717227197
"PrefetchEvictedAfterCandidateRemoved",
2717327198
"PrefetchEvictedForNewerPrefetch",
2717427199
"PrefetchHeldback",

third_party/blink/public/devtools_protocol/browser_protocol.pdl

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -858,6 +858,7 @@ experimental domain Audits
858858
type SRIMessageSignatureIssueDetails extends object
859859
properties
860860
SRIMessageSignatureError error
861+
string signatureBase
861862
AffectedRequest request
862863

863864
type GenericIssueErrorType extends string
@@ -4594,7 +4595,8 @@ domain Emulation
45944595
experimental optional Page.Viewport viewport
45954596
# If set, the display feature of a multi-segment screen. If not set, multi-segment support
45964597
# is turned-off.
4597-
experimental optional DisplayFeature displayFeature
4598+
# Deprecated, use Emulation.setDisplayFeaturesOverride.
4599+
experimental deprecated optional DisplayFeature displayFeature
45984600
# If set, the posture of a foldable device. If not set the posture is set
45994601
# to continuous.
46004602
# Deprecated, use Emulation.setDevicePostureOverride.
@@ -4612,6 +4614,18 @@ domain Emulation
46124614
# Does nothing if no override is set.
46134615
experimental command clearDevicePostureOverride
46144616

4617+
# Start using the given display features to pupulate the Viewport Segments API.
4618+
# This override can also be set in setDeviceMetricsOverride().
4619+
experimental command setDisplayFeaturesOverride
4620+
parameters
4621+
array of DisplayFeature features
4622+
4623+
# Clears the display features override set with either setDeviceMetricsOverride()
4624+
# or setDisplayFeaturesOverride() and starts using display features from the
4625+
# platform again.
4626+
# Does nothing if no override is set.
4627+
experimental command clearDisplayFeaturesOverride
4628+
46154629
experimental command setScrollbarsHidden
46164630
parameters
46174631
# Whether scrollbars should be always hidden.
@@ -12903,6 +12917,7 @@ experimental domain Preload
1290312917
PrefetchFailedMIMENotSupported
1290412918
PrefetchFailedNetError
1290512919
PrefetchFailedNon2XX
12920+
PrefetchEvictedAfterBrowsingDataRemoved
1290612921
PrefetchEvictedAfterCandidateRemoved
1290712922
PrefetchEvictedForNewerPrefetch
1290812923
PrefetchHeldback

0 commit comments

Comments
 (0)