[cleanup] Fix SDK.RemoteObject.callFunctionJSON types

The function can return null and use of it should respect that.

Fixed: 402390420
Change-Id: Id7ace3e3090a8cfd938d92589494c267612f7a10
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6438951
Reviewed-by: Benedikt Meurer <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>

Author: Lightning00Blade

front_end/core/sdk/RemoteObject.ts

@@ -242,7 +242,7 @@ export abstract class RemoteObject {
 
   callFunctionJSON<T, U>(
       _functionDeclaration: (this: U, ...args: any[]) => T,
-      _args: Protocol.Runtime.CallArgument[]|undefined): Promise<T> {
+      _args: Protocol.Runtime.CallArgument[]|undefined): Promise<T|null> {
     throw new Error('Not implemented');
   }
 
@@ -568,7 +568,7 @@ export class RemoteObjectImpl extends RemoteObject {
 
   override async callFunctionJSON<T, U>(
       functionDeclaration: (this: U, ...args: any[]) => T,
-      args: Protocol.Runtime.CallArgument[]|undefined): Promise<T> {
+      args: Protocol.Runtime.CallArgument[]|undefined): Promise<T|null> {
     const response = await this.#runtimeAgent.invoke_callFunctionOn({
       objectId: this.#objectIdInternal,
       functionDeclaration: functionDeclaration.toString(),
@@ -577,7 +577,7 @@ export class RemoteObjectImpl extends RemoteObject {
       returnByValue: true,
     });
     if (response.getError() || response.exceptionDetails) {
-      return null as T;
+      return null;
     }
 
     return response.result.value;
@@ -973,7 +973,7 @@ export class RemoteArrayBuffer {
     return this.#objectInternal.arrayBufferByteLength();
   }
 
-  async bytes(start = 0, end = this.byteLength()): Promise<number[]> {
+  async bytes(start = 0, end = this.byteLength()): Promise<number[]|null> {
     if (start < 0 || start >= this.byteLength()) {
       throw new RangeError('start is out of range');
     }

front_end/models/source_map_scopes/NamesResolver.ts

@@ -741,7 +741,7 @@ export class RemoteObject extends SDK.RemoteObject.RemoteObject {
   }
 
   override callFunctionJSON<T, U>(
-      functionDeclaration: (this: U, ...args: any[]) => T, args?: Protocol.Runtime.CallArgument[]): Promise<T> {
+      functionDeclaration: (this: U, ...args: any[]) => T, args?: Protocol.Runtime.CallArgument[]): Promise<T|null> {
     return this.object.callFunctionJSON(functionDeclaration, args);
   }
 

front_end/panels/event_listeners/EventListenersUtils.ts

@@ -75,7 +75,11 @@ export async function frameworkEventListeners(object: SDK.RemoteObject.RemoteObj
         return {type: this.type, useCapture: this.useCapture, passive: this.passive, once: this.once};
       }
 
-      function storeTruncatedListener(truncatedListener: TruncatedEventListenerObjectInInspectedPage): void {
+      function storeTruncatedListener(truncatedListener: TruncatedEventListenerObjectInInspectedPage|null): void {
+        if (!truncatedListener) {
+          return;
+        }
+
         if (truncatedListener.type !== undefined) {
           type = truncatedListener.type;
         }

front_end/panels/event_listeners/EventListenersView.ts

@@ -145,7 +145,11 @@ export class EventListenersView extends UI.Widget.VBox {
         return isInternal;
       }
 
-      function setIsInternal(isInternal: boolean[]): void {
+      function setIsInternal(isInternal: boolean[]|null): void {
+        if (!isInternal) {
+          return;
+        }
+
         for (let i = 0; i < eventListeners.length; ++i) {
           if (isInternal[i]) {
             eventListeners[i].markAsFramework();

front_end/panels/linear_memory_inspector/LinearMemoryInspectorController.ts

@@ -53,7 +53,8 @@ export class RemoteArrayBufferWrapper implements LazyUint8Array {
       return new Uint8Array(0);
     }
     const array = await this.#remoteArrayBuffer.bytes(start, newEnd);
-    return new Uint8Array(array);
+
+    return new Uint8Array(array ?? []);
   }
 }
 

front_end/ui/components/text_editor/javascript.ts

@@ -710,7 +710,7 @@ async function prototypesFromObject(object: SDK.RemoteObject.RemoteObject): Prom
       }
     }
     return result;
-  }, []);
+  }, []) ?? [];
 }
 
 // Given a function object that is probably a bound function, try to

front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts

@@ -1424,7 +1424,7 @@ export class ArrayGroupingTreeElement extends UI.TreeOutline.TreeElement {
       return {ranges};
     }
 
-    async function callback(result: {ranges: number[][]}|undefined): Promise<void> {
+    async function callback(result: {ranges: number[][]}|undefined|null): Promise<void> {
       if (!result) {
         return;
       }

front_end/ui/legacy/components/utils/ImagePreview.ts

@@ -194,7 +194,7 @@ export class ImagePreview {
 
     const featuresObject = await object.callFunctionJSON(features, undefined);
     object.release();
-    return featuresObject;
+    return featuresObject ?? undefined;
 
     function features(this: HTMLImageElement): PrecomputedFeatures {
       return {