[SRI Message Signatures] Handle errors delivered to devtools.

This CL implements the devtools side of the integration for SRI
Message Signature errors that occur during parsing or validation in
the network service. It copies over the protocol changes from the
Chromium side of the patch, and fleshes out the issue implementation
and messaging.

1. [Chromium] https://crrev.com/c/6163804
2. [Devtools frontend] https://crrev.com/c/6239271 [You are here]

Bug: 381044049
Change-Id: I94df831bcaacce8b37a60f880d5e01dc7e374db9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6239271
Commit-Queue: Mike West <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>

Author: mikewest

config/gni/devtools_grd_files.gni

@@ -537,6 +537,26 @@ grd_files_release_sources = [
   "front_end/models/issues_manager/descriptions/sharedDictionaryWriteErrorShuttingDown.md",
   "front_end/models/issues_manager/descriptions/sharedDictionaryWriteErrorTooLongIdField.md",
   "front_end/models/issues_manager/descriptions/sharedDictionaryWriteErrorUnsupportedType.md",
+  "front_end/models/issues_manager/descriptions/sriInvalidSignatureHeader.md",
+  "front_end/models/issues_manager/descriptions/sriInvalidSignatureInputHeader.md",
+  "front_end/models/issues_manager/descriptions/sriMissingSignatureHeader.md",
+  "front_end/models/issues_manager/descriptions/sriMissingSignatureInputHeader.md",
+  "front_end/models/issues_manager/descriptions/sriSignatureHeaderValueIsIncorrectLength.md",
+  "front_end/models/issues_manager/descriptions/sriSignatureHeaderValueIsNotByteSequence.md",
+  "front_end/models/issues_manager/descriptions/sriSignatureHeaderValueIsParameterized.md",
+  "front_end/models/issues_manager/descriptions/sriSignatureInputHeaderInvalidComponentName.md",
+  "front_end/models/issues_manager/descriptions/sriSignatureInputHeaderInvalidComponentType.md",
+  "front_end/models/issues_manager/descriptions/sriSignatureInputHeaderInvalidDerivedComponentParameter.md",
+  "front_end/models/issues_manager/descriptions/sriSignatureInputHeaderInvalidHeaderComponentParameter.md",
+  "front_end/models/issues_manager/descriptions/sriSignatureInputHeaderInvalidParameter.md",
+  "front_end/models/issues_manager/descriptions/sriSignatureInputHeaderKeyIdLength.md",
+  "front_end/models/issues_manager/descriptions/sriSignatureInputHeaderMissingLabel.md",
+  "front_end/models/issues_manager/descriptions/sriSignatureInputHeaderMissingRequiredParameters.md",
+  "front_end/models/issues_manager/descriptions/sriSignatureInputHeaderValueMissingComponents.md",
+  "front_end/models/issues_manager/descriptions/sriSignatureInputHeaderValueNotInnerList.md",
+  "front_end/models/issues_manager/descriptions/sriValidationFailedInvalidLength.md",
+  "front_end/models/issues_manager/descriptions/sriValidationFailedSignatureExpired.md",
+  "front_end/models/issues_manager/descriptions/sriValidationFailedSignatureMismatch.md",
   "front_end/models/issues_manager/descriptions/stylesheetLateImport.md",
   "front_end/models/issues_manager/descriptions/stylesheetRequestFailed.md",
   "front_end/models/issues_manager/issues_manager.js",
@@ -1021,6 +1041,7 @@ grd_files_debug_sources = [
   "front_end/models/issues_manager/PropertyRuleIssue.js",
   "front_end/models/issues_manager/QuirksModeIssue.js",
   "front_end/models/issues_manager/RelatedIssue.js",
+  "front_end/models/issues_manager/SRIMessageSignatureIssue.js",
   "front_end/models/issues_manager/SelectElementAccessibilityIssue.js",
   "front_end/models/issues_manager/SharedArrayBufferIssue.js",
   "front_end/models/issues_manager/SharedDictionaryIssue.js",

front_end/core/host/UserMetrics.ts

@@ -1114,8 +1114,28 @@ export enum IssueCreated {
   'SelectElementAccessibilityIssue::NonPhrasingContentOptionChild' = 88,
   'SelectElementAccessibilityIssue::InteractiveContentOptionChild' = 89,
   'SelectElementAccessibilityIssue::InteractiveContentLegendChild' = 90,
+  'SRIMessageSignatureIssue::MissingSignatureHeader' = 91,
+  'SRIMessageSignatureIssue::MissingSignatureInputHeader' = 92,
+  'SRIMessageSignatureIssue::InvalidSignatureHeader' = 93,
+  'SRIMessageSignatureIssue::InvalidSignatureInputHeader' = 94,
+  'SRIMessageSignatureIssue::SignatureHeaderValueIsNotByteSequence' = 95,
+  'SRIMessageSignatureIssue::SignatureHeaderValueIsParameterized' = 96,
+  'SRIMessageSignatureIssue::SignatureHeaderValueIsIncorrectLength' = 97,
+  'SRIMessageSignatureIssue::SignatureInputHeaderMissingLabel' = 98,
+  'SRIMessageSignatureIssue::SignatureInputHeaderValueNotInnerList' = 99,
+  'SRIMessageSignatureIssue::SignatureInputHeaderValueMissingComponents' = 100,
+  'SRIMessageSignatureIssue::SignatureInputHeaderInvalidComponentType' = 101,
+  'SRIMessageSignatureIssue::SignatureInputHeaderInvalidComponentName' = 102,
+  'SRIMessageSignatureIssue::SignatureInputHeaderInvalidHeaderComponentParameter' = 103,
+  'SRIMessageSignatureIssue::SignatureInputHeaderInvalidDerivedComponentParameter' = 104,
+  'SRIMessageSignatureIssue::SignatureInputHeaderKeyIdLength' = 105,
+  'SRIMessageSignatureIssue::SignatureInputHeaderInvalidParameter' = 106,
+  'SRIMessageSignatureIssue::SignatureInputHeaderMissingRequiredParameters' = 107,
+  'SRIMessageSignatureIssue::ValidationFailedSignatureExpired' = 108,
+  'SRIMessageSignatureIssue::ValidationFailedInvalidLength' = 109,
+  'SRIMessageSignatureIssue::ValidationFailedSignatureMismatch' = 110,
   /* eslint-enable @typescript-eslint/naming-convention */
-  MAX_VALUE = 91,
+  MAX_VALUE = 111,
 }
 
 export const enum DeveloperResourceLoaded {

front_end/models/issues_manager/BUILD.gn

@@ -35,6 +35,7 @@ devtools_module("issues_manager") {
     "PropertyRuleIssue.ts",
     "QuirksModeIssue.ts",
     "RelatedIssue.ts",
+    "SRIMessageSignatureIssue.ts",
     "SelectElementAccessibilityIssue.ts",
     "SharedArrayBufferIssue.ts",
     "SharedDictionaryIssue.ts",
@@ -213,6 +214,26 @@ devtools_issue_description_files = [
   "sharedDictionaryWriteErrorShuttingDown.md",
   "sharedDictionaryWriteErrorTooLongIdField.md",
   "sharedDictionaryWriteErrorUnsupportedType.md",
+  "sriMissingSignatureHeader.md",
+  "sriMissingSignatureInputHeader.md",
+  "sriInvalidSignatureHeader.md",
+  "sriInvalidSignatureInputHeader.md",
+  "sriSignatureHeaderValueIsNotByteSequence.md",
+  "sriSignatureHeaderValueIsParameterized.md",
+  "sriSignatureHeaderValueIsIncorrectLength.md",
+  "sriSignatureInputHeaderMissingLabel.md",
+  "sriSignatureInputHeaderValueNotInnerList.md",
+  "sriSignatureInputHeaderValueMissingComponents.md",
+  "sriSignatureInputHeaderInvalidComponentType.md",
+  "sriSignatureInputHeaderInvalidComponentName.md",
+  "sriSignatureInputHeaderInvalidHeaderComponentParameter.md",
+  "sriSignatureInputHeaderInvalidDerivedComponentParameter.md",
+  "sriSignatureInputHeaderKeyIdLength.md",
+  "sriSignatureInputHeaderInvalidParameter.md",
+  "sriSignatureInputHeaderMissingRequiredParameters.md",
+  "sriValidationFailedSignatureExpired.md",
+  "sriValidationFailedInvalidLength.md",
+  "sriValidationFailedSignatureMismatch.md",
   "placeholderDescriptionForInvisibleIssues.md",
 ]
 
@@ -265,6 +286,7 @@ ts_library("unittests") {
     "MarkdownIssueDescription.test.ts",
     "PropertyRuleIssue.test.ts",
     "RelatedIssue.test.ts",
+    "SRIMessageSignatureIssue.test.ts",
     "SelectElementAccessibilityIssue.test.ts",
     "SharedDictionaryIssue.test.ts",
     "StylesheetLoadingIssue.test.ts",

front_end/models/issues_manager/IssuesManager.ts

@@ -29,6 +29,7 @@ import {SelectElementAccessibilityIssue} from './SelectElementAccessibilityIssue
 import {SharedArrayBufferIssue} from './SharedArrayBufferIssue.js';
 import {SharedDictionaryIssue} from './SharedDictionaryIssue.js';
 import {SourceFrameIssuesManager} from './SourceFrameIssuesManager.js';
+import {SRIMessageSignatureIssue} from './SRIMessageSignatureIssue.js';
 import {StylesheetLoadingIssue} from './StylesheetLoadingIssue.js';
 
 export {Events} from './IssuesManagerEvents.js';
@@ -129,6 +130,10 @@ const issueCodeHandlers = new Map<
     Protocol.Audits.InspectorIssueCode.SelectElementAccessibilityIssue,
     SelectElementAccessibilityIssue.fromInspectorIssue,
   ],
+  [
+    Protocol.Audits.InspectorIssueCode.SRIMessageSignatureIssue,
+    SRIMessageSignatureIssue.fromInspectorIssue,
+  ],
 ]);
 
 /**

front_end/models/issues_manager/SRIMessageSignatureIssue.test.ts

@@ -0,0 +1,65 @@
+// Copyright 2025 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import type * as SDK from '../../core/sdk/sdk.js';
+import * as Protocol from '../../generated/protocol.js';
+import {describeWithLocale} from '../../testing/EnvironmentHelpers.js';
+import {MockIssuesModel} from '../../testing/MockIssuesModel.js';
+import * as IssuesManager from '../issues_manager/issues_manager.js';
+
+function createProtocolIssue(sriMessageSignatureIssueDetails: Protocol.Audits.SRIMessageSignatureIssueDetails):
+    Protocol.Audits.InspectorIssue {
+  return {
+    code: Protocol.Audits.InspectorIssueCode.SRIMessageSignatureIssue,
+    details: {sriMessageSignatureIssueDetails},
+  };
+}
+
+describeWithLocale('SRIMessageSignatureIssue', () => {
+  const mockModel = new MockIssuesModel([]) as unknown as SDK.IssuesModel.IssuesModel;
+
+  it('can be created for various error reasons', () => {
+    const errorReasons = [
+      Protocol.Audits.SRIMessageSignatureError.MissingSignatureHeader,
+      Protocol.Audits.SRIMessageSignatureError.MissingSignatureInputHeader,
+      Protocol.Audits.SRIMessageSignatureError.InvalidSignatureHeader,
+      Protocol.Audits.SRIMessageSignatureError.InvalidSignatureInputHeader,
+      Protocol.Audits.SRIMessageSignatureError.SignatureHeaderValueIsNotByteSequence,
+      Protocol.Audits.SRIMessageSignatureError.SignatureHeaderValueIsParameterized,
+      Protocol.Audits.SRIMessageSignatureError.SignatureHeaderValueIsIncorrectLength,
+      Protocol.Audits.SRIMessageSignatureError.SignatureInputHeaderMissingLabel,
+      Protocol.Audits.SRIMessageSignatureError.SignatureInputHeaderValueNotInnerList,
+      Protocol.Audits.SRIMessageSignatureError.SignatureInputHeaderValueMissingComponents,
+      Protocol.Audits.SRIMessageSignatureError.SignatureInputHeaderInvalidComponentType,
+      Protocol.Audits.SRIMessageSignatureError.SignatureInputHeaderInvalidComponentName,
+      Protocol.Audits.SRIMessageSignatureError.SignatureInputHeaderInvalidHeaderComponentParameter,
+      Protocol.Audits.SRIMessageSignatureError.SignatureInputHeaderInvalidDerivedComponentParameter,
+      Protocol.Audits.SRIMessageSignatureError.SignatureInputHeaderKeyIdLength,
+      Protocol.Audits.SRIMessageSignatureError.SignatureInputHeaderInvalidParameter,
+      Protocol.Audits.SRIMessageSignatureError.SignatureInputHeaderMissingRequiredParameters,
+      Protocol.Audits.SRIMessageSignatureError.ValidationFailedSignatureExpired,
+      Protocol.Audits.SRIMessageSignatureError.ValidationFailedInvalidLength,
+      Protocol.Audits.SRIMessageSignatureError.ValidationFailedSignatureMismatch,
+    ];
+    for (const errorReason of errorReasons) {
+      const issueDetails = {
+        error: errorReason,
+        request: {
+          requestId: 'test-request-id' as Protocol.Network.RequestId,
+          url: 'https://example.com/',
+        },
+      };
+      const issue = createProtocolIssue(issueDetails);
+      const sriMessageSignatureIssues =
+          IssuesManager.SRIMessageSignatureIssue.SRIMessageSignatureIssue.fromInspectorIssue(mockModel, issue);
+      assert.lengthOf(sriMessageSignatureIssues, 1);
+      const sriMessageSignatureIssue = sriMessageSignatureIssues[0];
+
+      assert.strictEqual(sriMessageSignatureIssue.getCategory(), IssuesManager.Issue.IssueCategory.OTHER);
+      assert.deepEqual(sriMessageSignatureIssue.details(), issueDetails);
+      assert.strictEqual(sriMessageSignatureIssue.getKind(), IssuesManager.Issue.IssueKind.PAGE_ERROR);
+      assert.isNotNull(sriMessageSignatureIssue.getDescription());
+    }
+  });
+});