Remove js profiler leftovers

Fixed: 391142900
Change-Id: I5befb999029201106624024b70e1c8d56d69d26a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6187115
Auto-Submit: Andres Olivares <[email protected]>
Commit-Queue: Andres Olivares <[email protected]>
Reviewed-by: Nikolay Vitkov <[email protected]>

Author: and-oli

config/gni/devtools_grd_files.gni

@@ -832,7 +832,6 @@ grd_files_debug_sources = [
   "front_end/core/sdk/AccessibilityModel.js",
   "front_end/core/sdk/AnimationModel.js",
   "front_end/core/sdk/AutofillModel.js",
-  "front_end/core/sdk/CPUProfileDataModel.js",
   "front_end/core/sdk/CPUProfilerModel.js",
   "front_end/core/sdk/CPUThrottlingManager.js",
   "front_end/core/sdk/CSSContainerQuery.js",
@@ -884,7 +883,6 @@ grd_files_debug_sources = [
   "front_end/core/sdk/PaintProfiler.js",
   "front_end/core/sdk/PerformanceMetricsModel.js",
   "front_end/core/sdk/PreloadingModel.js",
-  "front_end/core/sdk/ProfileTreeModel.js",
   "front_end/core/sdk/RehydratingConnection.js",
   "front_end/core/sdk/RehydratingObject.js",
   "front_end/core/sdk/RemoteObject.js",

front_end/core/sdk/BUILD.gn

@@ -11,7 +11,6 @@ devtools_module("sdk") {
     "AccessibilityModel.ts",
     "AnimationModel.ts",
     "AutofillModel.ts",
-    "CPUProfileDataModel.ts",
     "CPUProfilerModel.ts",
     "CPUThrottlingManager.ts",
     "CSSContainerQuery.ts",
@@ -63,7 +62,6 @@ devtools_module("sdk") {
     "PaintProfiler.ts",
     "PerformanceMetricsModel.ts",
     "PreloadingModel.ts",
-    "ProfileTreeModel.ts",
     "RehydratingConnection.ts",
     "RehydratingObject.ts",
     "RemoteObject.ts",

front_end/core/sdk/CPUProfileDataModel.ts

@@ -5,7 +5,6 @@
 import './SDKModel.js';
 import './CSSMetadata.js';
 import '../../generated/SupportedCSSProperties.js';
-import './ProfileTreeModel.js';
 import './NetworkRequest.js';
 import './NetworkManager.js';
 import './RuntimeModel.js';
@@ -21,7 +20,6 @@ import * as ConsoleModel from './ConsoleModel.js';
 import * as Cookie from './Cookie.js';
 import * as CookieModel from './CookieModel.js';
 import * as CookieParser from './CookieParser.js';
-import * as CPUProfileDataModel from './CPUProfileDataModel.js';
 import * as CPUProfilerModel from './CPUProfilerModel.js';
 import * as CPUThrottlingManager from './CPUThrottlingManager.js';
 import * as CSSContainerQuery from './CSSContainerQuery.js';
@@ -63,7 +61,6 @@ import * as PageResourceLoader from './PageResourceLoader.js';
 import * as PaintProfiler from './PaintProfiler.js';
 import * as PerformanceMetricsModel from './PerformanceMetricsModel.js';
 import * as PreloadingModel from './PreloadingModel.js';
-import * as ProfileTreeModel from './ProfileTreeModel.js';
 import * as RemoteObject from './RemoteObject.js';
 import * as Resource from './Resource.js';
 import * as ResourceTreeModel from './ResourceTreeModel.js';
@@ -101,7 +98,6 @@ export {
   Cookie,
   CookieModel,
   CookieParser,
-  CPUProfileDataModel,
   CPUProfilerModel,
   CPUThrottlingManager,
   CSSContainerQuery,
@@ -143,7 +139,6 @@ export {
   PaintProfiler,
   PerformanceMetricsModel,
   PreloadingModel,
-  ProfileTreeModel,
   RemoteObject,
   Resource,
   ResourceTreeModel,

front_end/core/sdk/ProfileTreeModel.ts

@@ -66,8 +66,6 @@ export class ProfileTreeModel {
 
   private assignDepthsAndParents(): void {
     const root = this.root;
-    // TODO(crbug.com/1354548): start depth from 0 once profiler
-    // panel dependencies are gone.
     root.depth = -1;
     root.parent = null;
     this.maxDepth = 0;

front_end/core/sdk/sdk.ts

@@ -444,7 +444,7 @@ export class DebuggerPlugin extends Plugin {
             jslogContext: 'configure',
           },
         ],
-        undefined, undefined, 'script-on-ignore-list');
+        undefined, 'script-on-ignore-list');
     this.ignoreListInfobar = infobar;
     infobar.setCloseCallback(() => this.removeInfobar(this.ignoreListInfobar));
 

front_end/models/cpu_profile/ProfileTreeModel.ts

@@ -52,7 +52,6 @@ export class Infobar {
 
   constructor(
       type: Type, text: string, actions?: InfobarAction[], disableSetting?: Common.Settings.Setting<boolean>,
-      /* TODO(crbug.com/1354548) Remove with JS Profiler deprecation */ isCloseable: boolean = true,
       jslogContext?: string) {
     this.element = document.createElement('div');
     if (jslogContext) {
@@ -120,7 +119,6 @@ export class Infobar {
     this.toggleElement.setAttribute('role', 'link');
     this.closeContainer.appendChild(this.toggleElement);
     this.closeButton = this.closeContainer.createChild('dt-close-button', 'close-button');
-    this.closeButton.hidden = !isCloseable;
     this.closeButton.setTabbable(true);
     ARIAUtils.setDescription(this.closeButton, i18nString(UIStrings.close));
     self.onInvokeElement(this.closeButton, this.dispose.bind(this));
@@ -156,7 +154,7 @@ export class Infobar {
     if (disableSetting && disableSetting.get()) {
       return null;
     }
-    return new Infobar(type, text, actions, disableSetting, undefined, jslogContext);
+    return new Infobar(type, text, actions, disableSetting, jslogContext);
   }
 
   dispose(): void {

front_end/panels/sources/DebuggerPlugin.ts

@@ -500,7 +500,7 @@ export class InspectorView extends VBox implements ViewLocationResolver {
               jslogContext: 'main.debug-reload',
             },
           ],
-          undefined, undefined, 'reload-required');
+          undefined, 'reload-required');
       infobar.setParentView(this);
       this.attachInfobar(infobar);
       this.reloadRequiredInfobar = infobar;
@@ -529,7 +529,7 @@ export class InspectorView extends VBox implements ViewLocationResolver {
               jslogContext: 'main.debug-reload',
             },
           ],
-          undefined, undefined, 'reload-required');
+          undefined, 'reload-required');
       infobar.setParentView(this);
       this.attachInfobar(infobar);
       this.reloadRequiredInfobar = infobar;
@@ -552,7 +552,7 @@ export class InspectorView extends VBox implements ViewLocationResolver {
               jslogContext: 'select-folder',
             },
           ],
-          undefined, undefined, 'select-override-folder');
+          undefined, 'select-override-folder');
       infobar.setParentView(this);
       this.attachInfobar(infobar);
       this.#selectOverrideFolderInfobar = infobar;
@@ -632,7 +632,7 @@ function createLocaleInfobar(): Infobar {
           jslogContext: 'set-to-specific-language',
         },
       ],
-      getDisableLocaleInfoBarSetting(), undefined, 'language-mismatch');
+      getDisableLocaleInfoBarSetting(), 'language-mismatch');
 }
 
 function reloadDevTools(): void {