Cleanup unused parameter from createWithStringLiteral

The method `createWithStringLiteral` has an optional parameter `subtitle` which isn't used by any caller, so removing the parameter and the passing it down. This is a preparation to removing such helpers altogether as these don't bring much value in lit templates

Bug: 301364727
Change-Id: Iea989c7ab90fa6dfc9f504c45b647ebc9cc96d7f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6438858
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>

Author: danilsomsikov

front_end/panels/elements/ClassesPaneWidget.ts

@@ -180,8 +180,8 @@ export class ClassesPaneWidget extends UI.Widget.Widget {
     const keys = [...classes.keys()];
     keys.sort(Platform.StringUtilities.caseInsensetiveComparator);
     for (const className of keys) {
-      const label = UI.UIUtils.CheckboxLabel.createWithStringLiteral(
-          className, classes.get(className), undefined, 'element-class', true);
+      const label =
+          UI.UIUtils.CheckboxLabel.createWithStringLiteral(className, classes.get(className), 'element-class', true);
       label.classList.add('monospace');
       label.checkboxElement.addEventListener('click', this.onClick.bind(this, className), false);
       this.classesContainer.appendChild(label);

front_end/panels/elements/ElementStatePaneWidget.ts

@@ -112,8 +112,7 @@ export class ElementStatePaneWidget extends UI.Widget.Widget {
     const createElementStateCheckbox = (state: string): HTMLDivElement => {
       const div = document.createElement('div');
       div.id = state;
-      const label =
-          UI.UIUtils.CheckboxLabel.createWithStringLiteral(':' + state, undefined, undefined, undefined, true);
+      const label = UI.UIUtils.CheckboxLabel.createWithStringLiteral(':' + state, undefined, undefined, true);
       const input = label.checkboxElement;
       this.inputStates.set(input, state);
       input.addEventListener('click', (clickListener as EventListener), false);

front_end/panels/network/NetworkConfigView.ts

@@ -340,7 +340,7 @@ export class NetworkConfigView extends UI.Widget.VBox {
       Zstd: Protocol.Network.ContentEncoding.Zstd,
     };
     for (const encoding of Object.values(contentEncodings)) {
-      const label = UI.UIUtils.CheckboxLabel.createWithStringLiteral(encoding, true, undefined, encoding);
+      const label = UI.UIUtils.CheckboxLabel.createWithStringLiteral(encoding, true, encoding);
       encodingsSection.appendChild(label);
       checkboxes.set(encoding, label.checkboxElement);
     }

front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts

@@ -217,8 +217,8 @@ export class FrameworkIgnoreListSettingsTab extends UI.Widget.VBox implements
 
     const listSetting = this.setting;
 
-    const checkbox = UI.UIUtils.CheckboxLabel.createWithStringLiteral(
-        item.pattern, !item.disabled, undefined, 'settings.ignore-list-pattern');
+    const checkbox =
+        UI.UIUtils.CheckboxLabel.createWithStringLiteral(item.pattern, !item.disabled, 'settings.ignore-list-pattern');
     const helpText = i18nString(UIStrings.ignoreScriptsWhoseNamesMatchS, {PH1: item.pattern});
     UI.Tooltip.Tooltip.install(checkbox, helpText);
     checkbox.checkboxElement.ariaLabel = helpText;

front_end/panels/settings/SettingsScreen.ts

@@ -479,8 +479,8 @@ export class ExperimentsSettingsTab extends SettingsTab {
   }
 
   private createExperimentCheckbox(experiment: Root.Runtime.Experiment): HTMLParagraphElement {
-    const label = UI.UIUtils.CheckboxLabel.createWithStringLiteral(
-        experiment.title, experiment.isEnabled(), undefined, experiment.name);
+    const label =
+        UI.UIUtils.CheckboxLabel.createWithStringLiteral(experiment.title, experiment.isEnabled(), experiment.name);
     label.classList.add('experiment-label');
     const input = label.checkboxElement;
     input.name = experiment.name;

front_end/panels/timeline/components/IgnoreListSetting.ts

@@ -246,7 +246,7 @@ export class IgnoreListSetting extends HTMLElement {
 
   #renderItem(regex: Common.Settings.RegExpSettingItem, index: number): Lit.TemplateResult {
     const checkboxWithLabel = UI.UIUtils.CheckboxLabel.createWithStringLiteral(
-        regex.pattern, !regex.disabled, /* subtitle*/ undefined, /* jslogContext*/ 'timeline.ignore-list-pattern');
+        regex.pattern, !regex.disabled, /* jslogContext*/ 'timeline.ignore-list-pattern');
     const helpText = i18nString(UIStrings.ignoreScriptsWhoseNamesMatchS, {regex: regex.pattern});
     UI.Tooltip.Tooltip.install(checkboxWithLabel, helpText);
     checkboxWithLabel.checkboxElement.ariaLabel = helpText;

front_end/ui/legacy/UIUtils.ts

@@ -1343,11 +1343,10 @@ export class CheckboxLabel extends HTMLElement {
   }
 
   /** Only to be used when the checkbox label is 'generated' (a regex, a className, etc). Most checkboxes should be create()'d with UIStrings */
-  static createWithStringLiteral(
-      title?: string, checked?: boolean, subtitle?: Platform.UIString.LocalizedString, jslogContext?: string,
-      small?: boolean): CheckboxLabel {
+  static createWithStringLiteral(title?: string, checked?: boolean, jslogContext?: string, small?: boolean):
+      CheckboxLabel {
     const stringLiteral = title as Platform.UIString.LocalizedString;
-    return CheckboxLabel.create(stringLiteral, checked, subtitle, jslogContext, small);
+    return CheckboxLabel.create(stringLiteral, checked, undefined, jslogContext, small);
   }
 
   private static lastId = 0;