Skip to content

Commit 48963ad

Browse files
pfaffeDevtools-frontend LUCI CQ
authored andcommitted
[css value tracing] Fix highlighting in BinOps
Fixed: 404538338 Change-Id: Ic15007e85a415973057579db3d77c011b44015e7 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6368598 Reviewed-by: Eric Leese <[email protected]> Commit-Queue: Eric Leese <[email protected]> Auto-Submit: Philip Pfaffe <[email protected]>
1 parent cf70a05 commit 48963ad

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

front_end/panels/elements/PropertyRenderer.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -498,9 +498,12 @@ export class StringRenderer extends rendererBase(SDK.CSSPropertyParserMatchers.S
498498
export class BinOpRenderer extends rendererBase(SDK.CSSPropertyParserMatchers.BinOpMatch) {
499499
// clang-format on
500500
override render(match: SDK.CSSPropertyParserMatchers.BinOpMatch, context: RenderingContext): Node[] {
501-
const [lhs, binop, rhs] =
502-
SDK.CSSPropertyParser.ASTUtils.children(match.node).map(child => Renderer.render(child, context).nodes);
501+
const [lhs, binop, rhs] = SDK.CSSPropertyParser.ASTUtils.children(match.node).map(child => {
502+
const span = document.createElement('span');
503+
Renderer.renderInto(child, context, span);
504+
return span;
505+
});
503506

504-
return [lhs, document.createTextNode(' '), binop, document.createTextNode(' '), rhs].flat();
507+
return [lhs, document.createTextNode(' '), binop, document.createTextNode(' '), rhs];
505508
}
506509
}

0 commit comments

Comments
 (0)