Move common unit tests to foundation

The only exception is the base64 decoder that requires the browser
runtime. The CL uses `@ts-expect-error` where tsc is missing types
coming from either DOM or node.js.

Bug: 451502260
Change-Id: Idc90ae547d13df490b622dcf36c58f60cecb01a6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7112839
Reviewed-by: Simon Zünd <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>

Author: OrKoN

front_end/BUILD.gn

@@ -276,6 +276,7 @@ group("unittests") {
 
 group("foundation_unittests") {
   deps = [
+    "core/common:foundation_unittests",
     "core/i18n:foundation_unittests",
     "models/ai_assistance:foundation_unittests",
   ]

front_end/core/common/BUILD.gn

@@ -76,6 +76,18 @@ devtools_entrypoint("bundle") {
 ts_library("unittests") {
   testonly = true
 
+  sources = [ "Base64.browser.test.ts" ]
+
+  deps = [
+    ":bundle",
+    "../../testing",
+    "../i18n:bundle",
+  ]
+}
+
+devtools_foundation_module("foundation_unittests") {
+  testonly = true
+
   sources = [
     "Base64.test.ts",
     "CharacterIdMap.test.ts",

front_end/core/common/Base64.browser.test.ts

@@ -0,0 +1,18 @@
+// Copyright 2025 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as Common from './common.js';
+
+describe('Base64 encoder', () => {
+  it('encodes ArrayBuffers correctly', async () => {
+    const buffer1 = new Uint8Array([0]);
+    assert.strictEqual(await Common.Base64.encode(buffer1.buffer), 'AA==');
+
+    const buffer2 = new Uint8Array([0, 1]);
+    assert.strictEqual(await Common.Base64.encode(buffer2.buffer), 'AAE=');
+
+    const buffer3 = new Uint8Array([0, 1, 2]);
+    assert.strictEqual(await Common.Base64.encode(buffer3.buffer), 'AAEC');
+  });
+});

front_end/core/common/Base64.test.ts

@@ -6,6 +6,7 @@ import * as Common from './common.js';
 
 describe('Base64 decoder', () => {
   function decode(str: string) {
+    // @ts-expect-error missing types in devtools_foundation_module.
     const encoded = btoa(str);
     const decoded = Common.Base64.decode(encoded);
     const view = new DataView(decoded.buffer);
@@ -26,16 +27,3 @@ describe('Base64 decoder', () => {
     decode('ABCDEF');  // Unpadded: QUJDREVG
   });
 });
-
-describe('Base64 encoder', () => {
-  it('encodes ArrayBuffers correctly', async () => {
-    const buffer1 = new Uint8Array([0]);
-    assert.strictEqual(await Common.Base64.encode(buffer1.buffer), 'AA==');
-
-    const buffer2 = new Uint8Array([0, 1]);
-    assert.strictEqual(await Common.Base64.encode(buffer2.buffer), 'AAE=');
-
-    const buffer3 = new Uint8Array([0, 1, 2]);
-    assert.strictEqual(await Common.Base64.encode(buffer3.buffer), 'AAEC');
-  });
-});

front_end/core/common/CharacterIdMap.test.ts

@@ -8,20 +8,20 @@ const CharacterIdMap = Common.CharacterIdMap.CharacterIdMap;
 
 describe('CharacterIdMap class', () => {
   it('is able to convert an element to a character', () => {
-    const testElement = document.createElement('p');
+    const testElement = {};
     const characterIdMap = new CharacterIdMap();
     assert.strictEqual(characterIdMap.toChar(testElement), '!', 'element was not converted correctly');
   });
 
   it('is able to convert a character to an element', () => {
-    const testElement = document.createElement('p');
+    const testElement = {};
     const characterIdMap = new CharacterIdMap();
     assert.strictEqual(characterIdMap.toChar(testElement), '!', 'element was not converted correctly');
     assert.strictEqual(characterIdMap.fromChar('!'), testElement, 'character was not converted correctly');
   });
 
   it('returns the same character when trying to convert an element that was already converted', () => {
-    const testElement = document.createElement('p');
+    const testElement = {};
     const characterIdMap = new CharacterIdMap();
     assert.strictEqual(characterIdMap.toChar(testElement), '!', 'element was not converted correctly');
     assert.strictEqual(characterIdMap.toChar(testElement), '!', 'element was not converted correctly');
@@ -32,8 +32,9 @@ describe('CharacterIdMap class', () => {
     const characterIdMap = new CharacterIdMap();
     assert.throws(() => {
       for (let index = 0; index <= upperLimit; index++) {
-        const el = document.createElement('div');
-        el.setAttribute('id', 'Div' + index);
+        const el = {
+          id: 'Div' + index,
+        };
         characterIdMap.toChar(el);
       }
     }, 'CharacterIdMap ran out of capacity!');

front_end/core/common/Debouncer.test.ts

@@ -18,6 +18,7 @@ describe('Debouncer', () => {
     debouncedIncrement();
 
     // Then wait a while before checking the value.
+    // @ts-expect-error missing types in devtools_foundation_module.
     setTimeout(() => {
       assert.strictEqual(count, 1);
       done();

front_end/core/common/Debouncer.ts

@@ -6,10 +6,10 @@
  * Debounce utility function, ensures that the function passed in is only called once the function stops being called and the delay has expired.
  */
 export const debounce = function(func: (...args: any[]) => void, delay: number): (...args: any[]) => void {
-  let timer = 0;
+  let timer: ReturnType<typeof setTimeout>;
   const debounced = (...args: any[]): void => {
     clearTimeout(timer);
-    timer = window.setTimeout(() => func(...args), delay);
+    timer = setTimeout(() => func(...args), delay);
   };
   return debounced;
 };

front_end/core/common/Gzip.test.ts

@@ -14,9 +14,12 @@ describe('Gzip', () => {
 
   it('can compress and decompress a stream', async () => {
     const text = 'Hello, world! This is a stream test.';
+    // @ts-expect-error missing types in devtools_foundation_module.
     const textEncoder = new TextEncoder();
+    // @ts-expect-error missing types in devtools_foundation_module.
     const inputStream = new ReadableStream({
-      start(controller) {
+      // @ts-expect-error missing types in devtools_foundation_module.
+      start(controller: ReadableStreamController<Uint8Array<ArrayBuffer>>) {
         controller.enqueue(textEncoder.encode(text));
         controller.close();
       },
@@ -25,7 +28,9 @@ describe('Gzip', () => {
     const compressedStream = Common.Gzip.compressStream(inputStream);
     const decompressedStream = Common.Gzip.decompressStream(compressedStream);
 
+    // @ts-expect-error missing types in devtools_foundation_module.
     const buffer = await new Response(decompressedStream).arrayBuffer();
+    // @ts-expect-error missing types in devtools_foundation_module.
     const decodedText = new TextDecoder().decode(buffer);
 
     assert.strictEqual(decodedText, text);
@@ -41,6 +46,7 @@ describe('arrayBufferToString', () => {
   });
   it('can decode a plaintext buffer', async () => {
     const text = 'Hello, buddy!';
+    // @ts-expect-error missing types in devtools_foundation_module.
     const buffer = new TextEncoder().encode(text).buffer;
     const result = await Common.Gzip.arrayBufferToString(buffer);
     assert.strictEqual(result, text);
@@ -51,11 +57,13 @@ describe('fileToString', () => {
   it('can decompress a gzipped file', async () => {
     const text = '{"key": "value"}';
     const compressed = await Common.Gzip.compress(text);
+    // @ts-expect-error missing types in devtools_foundation_module.
     const result = await Common.Gzip.fileToString(new File([compressed], 'file.json.gz', {type: 'application/gzip'}));
     assert.strictEqual(result, text);
   });
   it('can decode a plaintext file', async () => {
     const text = 'Hello, buddy!';
+    // @ts-expect-error missing types in devtools_foundation_module.
     const file = new File([text], 'test.txt');
     const result = await Common.Gzip.fileToString(file);
     assert.strictEqual(result, text);

front_end/core/common/Gzip.ts

@@ -54,7 +54,7 @@ async function gzipCodec(
     codecStream: CompressionStream|DecompressionStream): Promise<ArrayBuffer> {
   const readable = new ReadableStream({
     start(controller) {
-      controller.enqueue(buffer);
+      controller.enqueue(buffer instanceof ArrayBuffer ? new Uint8Array(buffer) : buffer);
       controller.close();
     }
   });

front_end/core/common/Mutex.test.ts

@@ -6,6 +6,7 @@ import * as Common from './common.js';
 
 describe('Mutex', () => {
   async function triggerMicroTaskQueue(): Promise<void> {
+    // @ts-expect-error missing types in devtools_foundation_module.
     await new Promise(resolve => setTimeout(resolve, 0));
   }