Skip to content

Commit 4d2261c

Browse files
AlinaVarkkiDevtools-frontend LUCI CQ
authored andcommitted
[RPP] Add border to radio buttons and switch a few keys in the shortcuts dialog
Bug: 313757601 Change-Id: I30f8aa9394e7489baef2509901a65c6320802c14 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6037605 Auto-Submit: Alina Varkki <[email protected]> Commit-Queue: Alina Varkki <[email protected]> Reviewed-by: Nancy Li <[email protected]>
1 parent b04e784 commit 4d2261c

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

front_end/panels/timeline/TimelinePanel.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1146,12 +1146,15 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
11461146
}
11471147

11481148
return [
1149-
{title: i18nString(UIStrings.timelineScrollUpDown), bindings: [['Scroll'], ['Shift', 'up/down']]},
1150-
{title: i18nString(UIStrings.timelineZoomInOut), bindings: [['Cmd', 'Scroll'], ['W/S'], ['+/-']]},
1149+
{title: i18nString(UIStrings.timelineScrollUpDown), bindings: [['Scroll'], ['Shift', '↑/↓']]},
1150+
{
1151+
title: i18nString(UIStrings.timelineZoomInOut),
1152+
bindings: [[Host.Platform.isMac() ? '⌘' : 'Ctrl', 'Scroll'], ['W/S'], ['+/-']],
1153+
},
11511154
{title: i18nString(UIStrings.timelineFastZoomInOut), bindings: [['Shift', 'W/S'], ['Shift', '+/-']]},
11521155
{
11531156
title: i18nString(UIStrings.timelinePanLeftRight),
1154-
bindings: [['A/D'], ['Shift', 'Scroll'], ['Shift', 'left/right']],
1157+
bindings: [['A/D'], ['Shift', 'Scroll'], ['Shift', '←/→']],
11551158
},
11561159
];
11571160
}

front_end/ui/components/dialogs/shortcutDialog.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,9 @@
7070
.nav-radio-buttons {
7171
display: flex;
7272
flex-direction: column;
73-
padding: 0 var(--sys-size-8);
73+
padding: 0 var(--sys-size-8) var(--sys-size-4) var(--sys-size-8);
7474
gap: var(--sys-size-3);
75+
border-bottom: var(--sys-size-1) solid var(--sys-color-divider);
7576
}
7677

7778
.keybinds-key {

0 commit comments

Comments
 (0)