Skip to content

Commit 4f99dac

Browse files
ktranDevtools-frontend LUCI CQ
authored andcommitted
[docs] Remove combobox docs and add disabled example to select menu
Combobox is duplicated (see SelectMenu documentation: https://chromedevtools.github.io/devtools-frontend/#SelectMenu ). However, add a disabled example to select menu, which was previously existing for the combobox doc. Bug: 414332459 Change-Id: I0bf5f98b60d8208bd1593ff3effbe6ac293bb0c8 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7117386 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Kim-Anh Tran <[email protected]>
1 parent db6563f commit 4f99dac

File tree

5 files changed

+14
-92
lines changed

5 files changed

+14
-92
lines changed

front_end/ui/components/docs/BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ group("docs") {
1212
":component_doc_styles",
1313
"../../../Images",
1414
"../../../panels/timeline/fixtures/traces",
15-
"./combo_box",
1615
"./context_menu",
1716
"./expandable_list",
1817
"./input",

front_end/ui/components/docs/combo_box/BUILD.gn

Lines changed: 0 additions & 22 deletions
This file was deleted.

front_end/ui/components/docs/combo_box/basic.html

Lines changed: 0 additions & 20 deletions
This file was deleted.

front_end/ui/components/docs/combo_box/basic.ts

Lines changed: 0 additions & 49 deletions
This file was deleted.

front_end/ui/legacy/SelectMenu.docs.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,20 @@ export async function render(container: HTMLElement) {
5151
simpleMenuHTML);
5252
}
5353

54+
{
55+
const disabledMenuHTML = createDivWithP('Disabled select with lit-html');
56+
// clang-format off
57+
Lit.render(
58+
html`<select disabled aria-label="Select an option" @change=${onChange}>
59+
<option hidden>Select an option</option>
60+
<option jslog=${VisualLogging.item('option-1').track({
61+
click: true
62+
})} value="Option1">Option 1</option>
63+
</select>`,
64+
disabledMenuHTML);
65+
// clang-format on
66+
}
67+
5468
{
5569
const groupMenuHTML = createDivWithP('Select with groups with lit-html');
5670
Lit.render(

0 commit comments

Comments
 (0)