Skip to content

Commit 4fc00a6

Browse files
OrKoNDevtools-frontend LUCI CQ
authored andcommitted
build: we need shell true to run autoninja on win
Fixed: 391686539 Change-Id: I17efd6066ec741e7dd85e1a2094f53b666d27e39 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6836130 Commit-Queue: Alex Rudenko <[email protected]> Auto-Submit: Alex Rudenko <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]>
1 parent 0a2e715 commit 4fc00a6

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

test/run.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import * as childProcess from 'child_process';
66
import * as fs from 'fs';
77
import * as glob from 'glob';
8-
import * as os from 'os';
98
import * as path from 'path';
109
import yargs from 'yargs';
1110
import unparse from 'yargs-unparser';
@@ -104,10 +103,10 @@ function ninja(stdio: 'inherit'|'pipe', ...args: string[]) {
104103
}
105104
buildRoot = parent;
106105
}
107-
const ninjaCommand = os.platform() === 'win32' ? 'autoninja.bat' : 'autoninja';
108106
// autoninja can't always find ninja if not run from the checkout root, so
109107
// run it from there and pass the build root as an argument.
110-
const result = runProcess(ninjaCommand, ['-C', buildRoot, ...args], {encoding: 'utf-8', cwd: CHECKOUT_ROOT, stdio});
108+
const result =
109+
runProcess('autoninja', ['-C', buildRoot, ...args], {encoding: 'utf-8', shell: true, cwd: CHECKOUT_ROOT, stdio});
111110
if (result.error) {
112111
throw result.error;
113112
}

0 commit comments

Comments
 (0)