Skip to content

Commit 4fc8b1c

Browse files
Guangyue XuDevtools-frontend LUCI CQ
authored andcommitted
Update tooltips for the SelectorStats table
1. clarifying the elapsed time in computing style recalculation. 2. replace `element(s)` with `node(s)` which was used interchangeably before. 3. fix a typo `defintion` with `definition` 4. clarifying the invalidation count. A node can be invalidated multiple times and by multiple selectors. Bug: 379886422 Change-Id: I85aeec7f546c6bb2bba6cd74b4d24ebb6e022162 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6762175 Reviewed-by: Sulekha Kulkarni <[email protected]> Commit-Queue: Guangyue Xu <[email protected]> Reviewed-by: Paul Irish <[email protected]>
1 parent af08e46 commit 4fc8b1c

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

front_end/panels/timeline/TimelineSelectorStatsView.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const UIStrings = {
3232
/**
3333
*@description Tooltip description 'Elapsed (ms)'
3434
*/
35-
elapsedExplanation: 'Elapsed time spent computing a style rule in micro seconds',
35+
elapsedExplanation: 'Elapsed time spent matching a selector against the DOM in milliseconds.',
3636
/**
3737
*@description Column name and percentage of slow mach non-matches computing a style rule
3838
*/
@@ -49,23 +49,23 @@ const UIStrings = {
4949
/**
5050
*@description Tooltip description 'Match attempts'
5151
*/
52-
matchAttemptsExplanation: 'Count of elements that the engine attempted to match against a style rule',
52+
matchAttemptsExplanation: 'Count of nodes that the engine attempted to match against a style rule.',
5353
/**
5454
*@description Column name for count of elements that matched a style rule
5555
*/
5656
matchCount: 'Match count',
5757
/**
5858
*@description Tooltip description 'Match count'
5959
*/
60-
matchCountExplanation: 'Count of elements that matched a style rule',
60+
matchCountExplanation: 'Count of nodes that matched a style rule.',
6161
/**
6262
*@description Column name for a style rule's CSS selector text
6363
*/
6464
selector: 'Selector',
6565
/**
6666
*@description Tooltip description 'Selector'
6767
*/
68-
selectorExplanation: 'CSS selector text of a style rule',
68+
selectorExplanation: 'CSS selector text of a style rule.',
6969
/**
7070
*@description Column name for a style rule's CSS selector text
7171
*/
@@ -74,7 +74,7 @@ const UIStrings = {
7474
*@description Tooltip description 'Style Sheet'
7575
*/
7676
styleSheetIdExplanation:
77-
'Links to the selector rule defintion in the style sheets. Note that a selector rule could be defined in multiple places in a style sheet or defined in multiple style sheets. Selector rules from browser user-agent style sheet or dynamic style sheets don\'t have a link.',
77+
'Links to the selector rule definition in the style sheets. Note that a selector rule could be defined in multiple places in a style sheet or defined in multiple style sheets. Selector rules from browser user-agent style sheet or dynamic style sheets don\'t have a link.',
7878
/**
7979
*@description A context menu item in data grids to copy entire table to clipboard
8080
*/
@@ -110,7 +110,7 @@ const UIStrings = {
110110
*@description Tooltip description 'Invalidation count'
111111
*/
112112
invalidationCountExplanation:
113-
'Aggregated count of invalidations on nodes and subsequently had style recalculated, all of which are matched by this selector. Note that a node can be invalidated multiple times.',
113+
'Aggregated count of invalidations on nodes and subsequently had style recalculated, all of which are matched by this selector. Note that a node can be invalidated multiple times and by multiple selectors.',
114114
} as const;
115115
const str_ = i18n.i18n.registerUIStrings('panels/timeline/TimelineSelectorStatsView.ts', UIStrings);
116116
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

0 commit comments

Comments
 (0)