Open Rehydrated Devtools session in tab or window

This CL changes the current behavior for when opening an Enhanced Trace
in the Performance Panel.

Before: A new window will always open when the user opens a saved
Enhanced Trace

After: If the Devtools are in docked mode, new session will spawn on a
new tab. If the Devtools are in undocked mode, new session will spawn on
a new window.

Bug: 432043264
Change-Id: I4bc33ab482cde0a5a1f6e544b4bfd3be46fb0ee5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6897346
Reviewed-by: Connor Clark <[email protected]>
Commit-Queue: Vidal Diazleal <[email protected]>

Author: vidorteg

front_end/panels/timeline/TimelinePanel.ts

@@ -1677,7 +1677,12 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
       hostWindow.removeEventListener('message', onMessageHandler);
     }
     hostWindow.addEventListener('message', onMessageHandler);
-    rehydratingWindow = hostWindow.open(pathToLaunch, /* target: */ undefined, 'noopener=false,popup=true');
+
+    if (this.isDocked()) {
+      rehydratingWindow = hostWindow.open(pathToLaunch, /* target: */ '_blank', 'noopener=false,popup=false');
+    } else {
+      rehydratingWindow = hostWindow.open(pathToLaunch, /* target: */ undefined, 'noopener=false,popup=true');
+    }
   }
 
   async loadFromURL(url: Platform.DevToolsPath.UrlString): Promise<void> {
@@ -1688,6 +1693,10 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
     this.loader = await TimelineLoader.loadFromURL(url, this);
   }
 
+  private isDocked(): boolean {
+    return UI.DockController.DockController.instance().dockSide() !== UI.DockController.DockState.UNDOCKED;
+  }
+
   private updateMiniMap(): void {
     if (this.#viewMode.mode !== 'VIEWING_TRACE') {
       this.#minimapComponent.setData(null);