Add isDevToolsPerformanceMenuItem flag to context menus

Bug: 368240754
Change-Id: I6a1db0ca9e8ecd54f5cb3c7052b2b2fb51aff129
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5934531
Reviewed-by: Kim-Anh Tran <[email protected]>
Commit-Queue: Kateryna Prokopenko <[email protected]>

Author: Kateryna Prokopenko

front_end/core/host/InspectorFrontendHostAPI.ts

@@ -392,6 +392,7 @@ export interface ContextMenuDescriptor {
   isExperimentalFeature?: boolean;
   enabled?: boolean;
   checked?: boolean;
+  isDevToolsPerformanceMenuItem?: boolean;
   subItems?: ContextMenuDescriptor[];
   shortcut?: string;
   jslogContext?: string;

front_end/ui/legacy/ContextMenu.ts

@@ -47,6 +47,7 @@ export class Item {
   protected readonly previewFeature: boolean;
   protected disabled: boolean|undefined;
   private readonly checked: boolean|undefined;
+  protected isDevToolsPerformanceMenuItem: boolean;
   protected contextMenu: ContextMenu|null;
   protected idInternal: number|undefined;
   customElement?: Element;
@@ -65,6 +66,7 @@ export class Item {
     this.accelerator = accelerator;
     this.disabled = disabled;
     this.checked = checked;
+    this.isDevToolsPerformanceMenuItem = false;
     this.contextMenu = contextMenu;
     this.idInternal = undefined;
     this.#tooltip = tooltip;
@@ -119,6 +121,9 @@ export class Item {
         }
         if (this.accelerator) {
           result.accelerator = this.accelerator;
+          if (this.isDevToolsPerformanceMenuItem) {
+            result.isDevToolsPerformanceMenuItem = true;
+          }
         }
         return result;
       }
@@ -157,6 +162,13 @@ export class Item {
     this.accelerator = {keyCode: key.code, modifiers: modifierSum};
   }
 
+  // This influences whether accelerators will be shown for native menus on Mac.
+  // Use this ONLY for performance menus and ONLY where accelerators are critical
+  // for a smooth user journey and heavily context dependent.
+  setIsDevToolsPerformanceMenuItem(isDevToolsPerformanceMenuItem: boolean): void {
+    this.isDevToolsPerformanceMenuItem = isDevToolsPerformanceMenuItem;
+  }
+
   setShortcut(shortcut: string): void {
     this.shortcut = shortcut;
   }
@@ -331,6 +343,7 @@ export class SubMenu extends Item {
       type: 'subMenu',
       label: this.label,
       accelerator: this.accelerator,
+      isDevToolsPerformanceMenuItem: this.accelerator ? this.isDevToolsPerformanceMenuItem : undefined,
       isExperimentalFeature: this.previewFeature,
       enabled: !this.disabled,
       subItems: [],

front_end/ui/legacy/SoftContextMenu.ts

@@ -644,6 +644,7 @@ export interface SoftContextMenuDescriptor {
   isExperimentalFeature?: boolean;
   enabled?: boolean;
   checked?: boolean;
+  isDevToolsPerformanceMenuItem?: boolean;
   subItems?: SoftContextMenuDescriptor[];
   element?: Element;
   shortcut?: string;