Skip to content

Commit 558cd42

Browse files
jackfranklinDevtools-frontend LUCI CQ
authored andcommitted
RPP: fix max call stack error in Trace Tree
This can hit the max call stack size error; so this changes to avoid building up another array to then push. [email protected] Bug: 436491188 Change-Id: Iaa37d45e72714f4f8b0231dc93149a29ed1339fb Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6862705 Auto-Submit: Jack Franklin <[email protected]> Reviewed-by: Connor Clark <[email protected]> Commit-Queue: Connor Clark <[email protected]>
1 parent 10a2fef commit 558cd42

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

front_end/models/trace/extras/TraceTree.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,9 @@ export class BottomUpRootNode extends Node {
512512
groupNode = new GroupNode(groupId, this, node.events);
513513
groupNodes.set(groupId, groupNode);
514514
} else {
515-
groupNode.events.push(...node.events);
515+
for (const e of node.events) {
516+
groupNode.events.push(e);
517+
}
516518
}
517519
groupNode.addChild(node as BottomUpNode, node.selfTime, node.selfTime, node.transferSize);
518520
}

0 commit comments

Comments
 (0)