Revert "Use Intl.NumberFormat for time and byte formatting"

This reverts commit 6b3449e.

Reason for revert: currently failing the auto roller: https://ci.chromium.org/ui/p/devtools-internal/builders/try/devtools_frontend_linux_rel/b8731890377373202833/overview

Original change's description:
> Use Intl.NumberFormat for time and byte formatting
>
> TimeUtilities now uses Intl.NumberFormat (instead of UIStrings),
> and bytesToString now uses Intl.NumberFormat (instead of non-locale
> aware strings). Additionally, bytesToString is now under the i18n
> module.
>
> Impacts of this change:
>
> * use Chrome ICU locale data to format, rather than human translators,
>   which allows us to be more accurate in regards to unit display style
>   (narrow vs short vs long)
> * group separators (ex: thousands decimals in english) are now present
> * slight change to rounding behavior - Intl.NumberFormat defaults to
>   "halfExpand", which rounds away from zeroes to break ties. Previously
>   we just truncated
>
> See go/cpq:i18n-units-design
>
> Bug: 372723536
> Change-Id: Iff05ca9ff01213660d64ca88fadb613296153fa9
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5981156
> Reviewed-by: Simon Zünd <[email protected]>
> Commit-Queue: Connor Clark <[email protected]>
> Reviewed-by: Benedikt Meurer <[email protected]>
> Reviewed-by: Paul Irish <[email protected]>

Bug: 372723536
Change-Id: I82f74ae04729b9f6c514d7e186572a8ffade30cd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6003765
Commit-Queue: Kim-Anh Tran <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>

Author: ktran

config/gni/devtools_grd_files.gni

@@ -779,9 +779,7 @@ grd_files_debug_sources = [
   "front_end/core/host/Platform.js",
   "front_end/core/host/ResourceLoader.js",
   "front_end/core/host/UserMetrics.js",
-  "front_end/core/i18n/ByteUtilities.js",
   "front_end/core/i18n/DevToolsLocale.js",
-  "front_end/core/i18n/NumberFormatter.js",
   "front_end/core/i18n/i18nImpl.js",
   "front_end/core/i18n/i18nTypes.js",
   "front_end/core/i18n/locales.js",

front_end/core/i18n/BUILD.gn

@@ -12,9 +12,7 @@ import("//$devtools_root_location/config/gni/i18n.gni")
 
 devtools_module("i18n") {
   sources = [
-    "ByteUtilities.ts",
     "DevToolsLocale.ts",
-    "NumberFormatter.ts",
     "i18nImpl.ts",
     "i18nTypes.ts",
     "time-utilities.ts",
@@ -87,7 +85,6 @@ ts_library("unittests") {
   testonly = true
 
   sources = [
-    "ByteUtilities.test.ts",
     "DevToolsLocale.test.ts",
     "i18n.test.ts",
     "time-utilities.test.ts",

front_end/core/i18n/ByteUtilities.test.ts

@@ -2,16 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import * as ByteUtilities from './ByteUtilities.js';
 import * as DevToolsLocale from './DevToolsLocale.js';
 import * as i18n from './i18nImpl.js';
-import * as NumberFormatter from './NumberFormatter.js';
 import * as TimeUtilities from './time-utilities.js';
 
 export {
-  ByteUtilities,
   DevToolsLocale,
   i18n,
-  NumberFormatter,
   TimeUtilities,
 };

front_end/core/i18n/ByteUtilities.ts

@@ -14,30 +14,12 @@ describeWithLocale('preciseMillisToString', () => {
     assert.strictEqual(outputString, '8\xA0ms');
   });
 
-  it('formats big number without a given precision', () => {
-    const inputNumber = 723123;
-    const outputString = i18n.TimeUtilities.preciseMillisToString(inputNumber);
-    assert.strictEqual(outputString, '723,123\xA0ms');
-  });
-
-  it('formats with a given precision', () => {
+  it('formats without a given precision', () => {
     const inputNumber = 7.84;
     const precision = 2;
     const outputString = i18n.TimeUtilities.preciseMillisToString(inputNumber, precision);
     assert.strictEqual(outputString, '7.84\xA0ms');
   });
-
-  it('formats with a given precision, rounding as expected', () => {
-    assert.strictEqual(i18n.TimeUtilities.preciseMillisToString(5.55555, 2), '5.56\xA0ms');
-    assert.strictEqual(i18n.TimeUtilities.preciseMillisToString(-5.55555, 2), '-5.56\xA0ms');
-    assert.strictEqual(i18n.TimeUtilities.preciseMillisToString(5.555, 2), '5.56\xA0ms');
-    assert.strictEqual(i18n.TimeUtilities.preciseMillisToString(-5.55, 2), '-5.55\xA0ms');  // ties break towards zero!
-    assert.strictEqual(i18n.TimeUtilities.preciseMillisToString(9.99999, 1), '10.0\xA0ms');
-    assert.strictEqual(i18n.TimeUtilities.preciseMillisToString(9.95, 1), '10.0\xA0ms');
-    assert.strictEqual(i18n.TimeUtilities.preciseMillisToString(9.94, 1), '9.9\xA0ms');
-    assert.strictEqual(i18n.TimeUtilities.preciseMillisToString(1.001, 1), '1.0\xA0ms');
-    assert.strictEqual(i18n.TimeUtilities.preciseMillisToString(1.001, 0), '1\xA0ms');
-  });
 });
 
 describeWithLocale('formatMicroSecondsTime', () => {
@@ -139,7 +121,7 @@ describeWithLocale('millisToString', () => {
   it('formats less than 24 hours', () => {
     const inputNumber = 20000000;
     const outputString = i18n.TimeUtilities.millisToString(inputNumber);
-    assert.strictEqual(outputString, '5.6\xA0hr');
+    assert.strictEqual(outputString, '5.6\xA0hrs');
   });
 
   it('formats days', () => {