Skip to content

Commit 578c379

Browse files
danilsomsikovDevtools-frontend LUCI CQ
authored andcommitted
Partially apply UI eng vision in the SearchVieew
Will remove DOM references from output and other DOM manipulations in the subsequent CLs Bug: 407750483 Change-Id: I07e7bca41b31f985ab9c10e6332c788f2d63bff9 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6881886 Reviewed-by: Philip Pfaffe <[email protected]> Commit-Queue: Danil Somsikov <[email protected]>
1 parent 75494b5 commit 578c379

File tree

2 files changed

+186
-107
lines changed

2 files changed

+186
-107
lines changed

front_end/panels/search/SearchView.test.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,12 @@ class TestSearchView extends Search.SearchView.SearchView {
7878
/** Fills in the UI elements of the SearchView and hits 'Enter'. */
7979
triggerSearch(query: string, matchCase: boolean, isRegex: boolean): void {
8080
this.search.value = query;
81-
this.matchCaseButton.toggled = matchCase;
82-
this.regexButton.toggled = isRegex;
81+
if (matchCase) {
82+
this.matchCaseButton.click();
83+
}
84+
if (isRegex) {
85+
this.regexButton.click();
86+
}
8387

8488
dispatchKeyDownEvent(this.search, {keyCode: UI.KeyboardShortcut.Keys.Enter.code});
8589
}

0 commit comments

Comments
 (0)