Skip to content

Commit 5836f7e

Browse files
Adriana IxbaDevtools-frontend LUCI CQ
authored andcommitted
[RPP 3P table] "Unhover" tree row after bottom up button click
This fixes a bug where after clicking the bottom-up button, the 3P checkbox remains "disabled". This is because dimming on the tree row hover remains after the click. So, it still thinks that we are currently dimming on row hover of the 3P table. So, we send an event to reset this Bug:393955677 Change-Id: Id69129ca02674138404ab9ac7c936d4eb86cdcaf Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6228898 Auto-Submit: Adriana Ixba <[email protected]> Reviewed-by: Paul Irish <[email protected]> Commit-Queue: Paul Irish <[email protected]>
1 parent c653121 commit 5836f7e

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

front_end/panels/timeline/TimelineTreeView.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -846,6 +846,9 @@ export class GridNode extends DataGrid.SortableDataGrid.SortableDataGridNode<Gri
846846
}
847847

848848
#bottomUpButtonClicked(): void {
849+
// We should also trigger an event to "unhover" the 3P tree row. Since this isn't
850+
// triggered when clicking the bottom up button.
851+
this.treeView.dispatchEventToListeners(TimelineTreeView.Events.THIRD_PARTY_ROW_HOVERED, null);
849852
this.treeView.dispatchEventToListeners(TimelineTreeView.Events.BOTTOM_UP_BUTTON_CLICKED, this.profileNode);
850853
}
851854
}

0 commit comments

Comments
 (0)