[eslint] Adopt ESLint Rule Naming Conventions.

Update our custom ESLint rules to follow the official naming
conventions[^1], in particular the rule names need to

1. consistently use dashes to separate words (rather a mix of
   underscores and dashes), and
1. consistently use `no-` prefix for rules that disallow something.

Drive-by-fix: Also remove the `fixable` setting from rules that don't
provide a fix.

This is a functionally neutral change.

[^1]: https://eslint.org/docs/latest/contribute/core-rules#rule-naming-conventions

Fixed: 386319581
Change-Id: Ifcb6c0e4ca8334a263be6534596c30b3bcca243b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6110726
Reviewed-by: Samiya Caur <[email protected]>
Commit-Queue: Samiya Caur <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>
Auto-Submit: Benedikt Meurer <[email protected]>

Author: bmeurer

.eslintrc.js

@@ -131,15 +131,15 @@ module.exports = {
     'import/no-duplicates': 'error',
 
     // Try to spot '// console.log()' left over from debugging
-    'rulesdir/commented_out_console': 'error',
+    'rulesdir/no-commented-out-console': 'error',
 
     // Prevent imports being commented out rather than deleted.
-    'rulesdir/commented_out_import': 'error',
+    'rulesdir/no-commented-out-import': 'error',
 
     // DevTools specific rules
-    'rulesdir/es_modules_import': 'error',
-    'rulesdir/check_license_header': 'error',
-    'rulesdir/html_tagged_template': 'error',
+    'rulesdir/es-modules-import': 'error',
+    'rulesdir/check-license-header': 'error',
+    'rulesdir/html-tagged-template': 'error',
     /**
      * Ensures that JS Doc comments are properly aligned - all the starting
      * `*` are in the right place.
@@ -195,10 +195,10 @@ module.exports = {
        */
       '@typescript-eslint/no-non-null-assertion': 'error',
       '@typescript-eslint/consistent-type-imports': 'error',
-      'rulesdir/no_underscored_properties': 'error',
-      'rulesdir/prefer_readonly_keyword': 'error',
-      'rulesdir/inline_type_imports': 'error',
-      'rulesdir/enforce_default_import_name': ['error', {
+      'rulesdir/no-underscored-properties': 'error',
+      'rulesdir/prefer-readonly-keyword': 'error',
+      'rulesdir/inline-type-imports': 'error',
+      'rulesdir/enforce-default-import-name': ['error', {
         // Enforce that any import of models/trace/trace.js names the import Trace.
         modulePath: path.join(__dirname, 'front_end', 'models', 'trace', 'trace.js'),
         importName: 'Trace'
@@ -291,12 +291,12 @@ module.exports = {
       'mocha/no-global-tests': 'error',
       'mocha/no-nested-tests': 'error',
 
-      'rulesdir/check_test_definitions' : 'error',
-      'rulesdir/avoid_assert_equal' : 'error',
-      'rulesdir/no_repeated_tests' : 'error',
-      'rulesdir/compare_arrays_with_assert_deepequal' : 'error',
-      'rulesdir/ban_screenshot_test_outside_perf_panel' : 'error',
-      'rulesdir/trace_engine_test_timeouts' : 'error',
+      'rulesdir/check-test-definitions' : 'error',
+      'rulesdir/no-assert-equal' : 'error',
+      'rulesdir/no-repeated-tests' : 'error',
+      'rulesdir/compare-arrays-with-assert-deepequal' : 'error',
+      'rulesdir/no-screenshot-test-outside-perf-panel' : 'error',
+      'rulesdir/trace-engine-test-timeouts' : 'error',
       '@typescript-eslint/no-non-null-assertion' : 'off',
     },
     settings: {

PRESUBMIT.py

@@ -209,7 +209,7 @@ def _CheckDevToolsRunESLintTests(input_api, output_api):
 
     mocha_path = devtools_paths.mocha_path()
     eslint_tests_path = input_api.os_path.join(eslint_rules_dir_path, 'tests',
-                                               '*_test.js')
+                                               '*.test.js')
 
     results = [output_api.PresubmitNotifyResult('ESLint rules unit tests')]
     results.extend(

extensions/cxx_debugging/src/CreditsItem.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-/* eslint-disable rulesdir/check_component_naming, rulesdir/no_underscored_properties, rulesdir/ban_style_tags_in_lit_html, rulesdir/ban_a_tags_in_lit_html, rulesdir/lit_html_host_this */
+/* eslint-disable rulesdir/check-component-naming, rulesdir/no-underscored-properties, rulesdir/no-style-tags-in-lit-html, rulesdir/no-a-tags-in-lit-html, rulesdir/lit-html-host-this */
 import {html, render} from 'lit-html';
 
 export type CreditsItemData = {

extensions/cxx_debugging/src/ExtensionOptions.ts

@@ -2,15 +2,15 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-/* eslint-disable rulesdir/check_component_naming */
-/* eslint-disable rulesdir/inject_checkbox_styles */
-/* eslint-disable rulesdir/lit_html_host_this */
+/* eslint-disable rulesdir/check-component-naming */
+/* eslint-disable rulesdir/inject-checkbox-styles */
+/* eslint-disable rulesdir/lit-html-host-this */
 
 import './CreditsItem.js';
 import './ModuleConfigurationList.js';
 
 import {html, render} from 'lit-html';
-import {until} from 'lit-html/directives/until.js';  // eslint-disable-line rulesdir/es_modules_import
+import {until} from 'lit-html/directives/until.js';  // eslint-disable-line rulesdir/es-modules-import
 
 import {type CreditsItemData} from './CreditsItem.js';
 import {type Storage} from './DevToolsPluginHost.js';

extensions/cxx_debugging/src/ModuleConfigurationList.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-/* eslint-disable rulesdir/check_component_naming, rulesdir/no_underscored_properties, rulesdir/ban_style_tags_in_lit_html, rulesdir/ban_a_tags_in_lit_html, rulesdir/lit_html_host_this,  @typescript-eslint/naming-convention,  @typescript-eslint/explicit-function-return-type,  @typescript-eslint/no-unused-vars */
+/* eslint-disable rulesdir/check-component-naming, rulesdir/no-underscored-properties, rulesdir/no-style-tags-in-lit-html, rulesdir/no-a-tags-in-lit-html, rulesdir/lit-html-host-this,  @typescript-eslint/naming-convention,  @typescript-eslint/explicit-function-return-type,  @typescript-eslint/no-unused-vars */
 
 import {html, nothing, render} from 'lit-html';
 

extensions/cxx_debugging/tests/Formatters_test.ts

@@ -3,7 +3,8 @@
 // found in the LICENSE file.
 
 import {CustomFormatters, type TypeInfo} from '../src/CustomFormatters.js';
-import * as Formatters from '../src/Formatters.js';  // eslint-disable-line rulesdir/es_modules_import
+import * as Formatters from '../src/Formatters.js';  // eslint-disable-line rulesdir/es-modules-import
+
 import {TestValue, TestWasmInterface} from './TestUtils.js';
 
 describe('Formatters', () => {

front_end/.eslintrc.js

@@ -10,16 +10,16 @@ rulesDirPlugin.RULES_DIR = path.join(__dirname, '..', 'scripts', 'eslint_rules',
 module.exports = {
   rules: {
     // L10n rules are only relevant in 'front_end'.
-    'rulesdir/l10n_filename_matches': [
+    'rulesdir/l10n-filename-matches': [
       'error', {
         rootFrontendDirectory: __dirname,
       }
     ],
-    'rulesdir/l10n_i18nString_call_only_with_uistrings': 'error',
-    'rulesdir/l10n_no_i18nString_calls_module_instantiation': 'error',
-    'rulesdir/l10n_no_locked_or_placeholder_only_phrase': 'error',
-    'rulesdir/l10n_no_uistrings_export': 'error',
-    'rulesdir/l10n_no_unused_message': 'error',
+    'rulesdir/l10n-i18nString-call-only-with-uistrings': 'error',
+    'rulesdir/l10n-no-i18nString-calls-module-instantiation': 'error',
+    'rulesdir/l10n-no-locked-or-placeholder-only-phrase': 'error',
+    'rulesdir/l10n-no-uistrings-export': 'error',
+    'rulesdir/l10n-no-unused-message': 'error',
   },
   overrides: [
     {
@@ -32,25 +32,25 @@ module.exports = {
               allowIIFEs:true,
             },
         ],
-        'rulesdir/no_importing_images_from_src': 'error',
-        'rulesdir/enforce_bound_render_for_schedule_render': 'error',
-        'rulesdir/enforce_custom_event_names': 'error',
-        'rulesdir/set_data_type_reference': 'error',
-        'rulesdir/no_bound_component_methods': 'error',
-        'rulesdir/lit_no_style_interpolation': 'error',
-        'rulesdir/ban_self_closing_custom_element_tagnames': 'error',
-        'rulesdir/ban_style_tags_in_lit_html': 'error',
-        'rulesdir/ban_a_tags_in_lit_html': 'error',
-        'rulesdir/check_css_import': 'error',
+        'rulesdir/no-importing-images-from-src': 'error',
+        'rulesdir/enforce-bound-render-for-schedule-render': 'error',
+        'rulesdir/enforce-custom-event-names': 'error',
+        'rulesdir/set-data-type-reference': 'error',
+        'rulesdir/no-bound-component-methods': 'error',
+        'rulesdir/lit-no-style-interpolation': 'error',
+        'rulesdir/no-self-closing-custom-element-tagnames': 'error',
+        'rulesdir/no-style-tags-in-lit-html': 'error',
+        'rulesdir/no-a-tags-in-lit-html': 'error',
+        'rulesdir/check-css-import': 'error',
         'rulesdir/enforce-optional-properties-last': 'error',
-        'rulesdir/check_enumerated_histograms': 'error',
-        'rulesdir/check_was_shown_methods': 'error',
-        'rulesdir/static_custom_event_names': 'error',
-        'rulesdir/lit_html_host_this': 'error',
-        'rulesdir/lit_html_no_attribute_quotes': 'error',
-        'rulesdir/lit_template_result_or_nothing': 'error',
-        'rulesdir/inject_checkbox_styles': 'error',
-        'rulesdir/jslog_context_list': 'error',
+        'rulesdir/check-enumerated-histograms': 'error',
+        'rulesdir/check-was-shown-methods': 'error',
+        'rulesdir/static-custom-event-names': 'error',
+        'rulesdir/lit-html-host-this': 'error',
+        'rulesdir/lit-html-no-attribute-quotes': 'error',
+        'rulesdir/lit-template-result-or-nothing': 'error',
+        'rulesdir/inject-checkbox-styles': 'error',
+        'rulesdir/jslog-context-list': 'error',
       }
     },
     {
@@ -74,21 +74,21 @@ module.exports = {
     {
       files: ['panels/**/components/*.ts', 'ui/components/**/*.ts', 'entrypoints/**/*.ts'],
       rules: {
-        'rulesdir/use_private_class_members': 'error',
+        'rulesdir/prefer-private-class-members': 'error',
       }
     },
     // TODO(crbug/1402569): Remove once LitElement is fully adopted.
     {
       files: ['panels/recorder/**/*.ts', 'panels/protocol_monitor/**/*.ts', 'ui/components/suggestion_input/*.ts'],
       rules: {
         // TODO(crbug/1402569): Reenable once https://github.com/microsoft/TypeScript/issues/48885 is closed.
-        'rulesdir/use_private_class_members': 'off',
+        'rulesdir/prefer-private-class-members': 'off',
       }
     },
     {
       files: ['generated/SupportedCSSProperties.js'],
       rules: {
-        'rulesdir/jslog_context_list': 'error',
+        'rulesdir/jslog-context-list': 'error',
       }
     }
   ]

front_end/Images/rollup.config.mjs

@@ -1,7 +1,7 @@
 // Copyright 2021 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-// eslint-disable-next-line rulesdir/es_modules_import
+// eslint-disable-next-line rulesdir/es-modules-import
 import {importMetaAssets} from '@web/rollup-plugin-import-meta-assets';
 import {optimize} from 'svgo';
 

front_end/core/sdk/NetworkManager.ts

@@ -1972,7 +1972,7 @@ export class ConditionsSerializer implements Serializer<Conditions, Conditions>
     const parsed = JSON.parse(serialized);
     return {
       ...parsed,
-      // eslint-disable-next-line rulesdir/l10n_i18nString_call_only_with_uistrings
+      // eslint-disable-next-line rulesdir/l10n-i18nString-call-only-with-uistrings
       title: parsed.i18nTitleKey ? i18nLazyString(parsed.i18nTitleKey) : parsed.title,
     };
   }

front_end/entrypoints/heap_snapshot_worker/HeapSnapshot.ts

@@ -28,7 +28,7 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-/* eslint-disable rulesdir/use_private_class_members */
+/* eslint-disable rulesdir/prefer-private-class-members */
 
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';