[RPP] Fix bug that double-counts transfer size in 3p table

Fixed: 408275043
Change-Id: I966155b37e08f32f2640823f46b0c214095775f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6431348
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Auto-Submit: Connor Clark <[email protected]>

Author: Connor Clark

front_end/models/trace/extras/ThirdParties.test.ts

@@ -27,7 +27,7 @@ describeWithEnvironment('ThirdParties', function() {
 
       const results = summaries.map(s => [s.entity.name, s.mainThreadTime, s.transferSize]);
       assert.deepEqual(results, [
-        ['localhost', 24.947999954223633, 2254],
+        ['localhost', 24.947999954223633, 1503],
         ['Google Fonts', 0, 25325],
       ]);
       const urls = extractUrlsFromSummaries(summaries);

front_end/models/trace/extras/TraceTree.ts

@@ -420,7 +420,20 @@ export class BottomUpRootNode extends Node {
         } else {
           node.events.push(e);
         }
-        node.transferSize += e.args.data.encodedDataLength;
+
+        // ResourceReceivedData events tally up the transfer size over time, but the
+        // ResourceReceiveResponse / ResourceFinish events hold the final result.
+        if (e.name === 'ResourceReceivedData') {
+          node.transferSize += e.args.data.encodedDataLength;
+        } else if (e.args.data.encodedDataLength > 0) {
+          // For some reason, ResourceFinish can be zero even if data was sent.
+          // Ignore that case.
+          // Note: this will count the entire resource size if just the last bit of a
+          // request is in view. If it isn't in view, the transfer size is counted
+          // gradually, in proportion with the ResourceReceivedData events in the
+          // current view.
+          node.transferSize = e.args.data.encodedDataLength;
+        }
       }
     };
 

front_end/models/trace/insights/ThirdParties.test.ts

@@ -20,7 +20,7 @@ describeWithEnvironment('ThirdParties', function() {
     ]);
     const summaryResult = insight.summaries.map(s => [s.entity.name, s.transferSize, s.mainThreadTime.toFixed(2)]);
     assert.deepEqual(summaryResult, [
-      ['localhost', 2254, '24.95'],
+      ['localhost', 1503, '24.95'],
       ['Google Fonts', 25325, '0.00'],
     ]);
   });
@@ -43,12 +43,12 @@ describeWithEnvironment('ThirdParties', function() {
 
     const summaryResult = insight.summaries.map(s => [s.entity.name, s.transferSize, s.mainThreadTime.toFixed(2)]);
     assert.deepEqual(summaryResult, [
-      ['paulirish.com', 439223, '85.54'],
-      ['Google Fonts', 169258, '0.00'],
-      ['Google Tag Manager', 367917, '19.95'],
-      ['Google Analytics', 75811, '5.86'],
-      ['Disqus', 3748, '0.34'],
-      ['Firebase', 6564, '0.00'],
+      ['paulirish.com', 157130, '85.54'],
+      ['Google Fonts', 80003, '0.00'],
+      ['Google Tag Manager', 95375, '19.95'],
+      ['Google Analytics', 20865, '5.86'],
+      ['Disqus', 1551, '0.34'],
+      ['Firebase', 2847, '0.00'],
     ]);
   });
 });