[cleanup] Prefer assert.exist

Verify likely this was done as back in the day chai assert did not
have good typing for this.

Bug: none
Change-Id: I22ce025dc9c56313560db3eade87687be8fe7ad4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7079394
Commit-Queue: Benedikt Meurer <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>

Author: Lightning00Blade

front_end/core/common/ColorUtils.test.ts

@@ -88,7 +88,6 @@ describe('ColorUtils', () => {
       const bg = Common.Color.parse(test.bgColor)?.asLegacyColor();
       if (!fg || !bg) {
         assert.fail(`Failed to parse foreground and/or background color: ${test.fgColor}, ${test.bgColor}`);
-        return;
       }
       assert.closeTo(Common.ColorUtils.contrastRatioAPCA(fg.rgba(), bg.rgba()), test.expectedContrast, 0.1);
     }

front_end/core/common/SettingRegistration.test.ts

@@ -49,15 +49,10 @@ describe('SettingRegistration', () => {
   });
 
   it('retrieves a registered setting', () => {
-    try {
-      const preRegisteredSetting = Common.Settings.Settings.instance().moduleSetting(settingName);
-      assert.strictEqual(preRegisteredSetting.title(), settingTitle, 'Setting title is not returned correctly');
-      assert.strictEqual(
-          preRegisteredSetting.category(), settingCategory, 'Setting category is not returned correctly');
-      assert.isNotTrue(preRegisteredSetting.get(), 'Setting value is not returned correctly');
-    } catch {
-      assert.fail('Failed to find setting registration');
-    }
+    const preRegisteredSetting = Common.Settings.Settings.instance().moduleSetting(settingName);
+    assert.strictEqual(preRegisteredSetting.title(), settingTitle, 'Setting title is not returned correctly');
+    assert.strictEqual(preRegisteredSetting.category(), settingCategory, 'Setting category is not returned correctly');
+    assert.isNotTrue(preRegisteredSetting.get(), 'Setting value is not returned correctly');
   });
 
   it('triggers a setting\'s change listener when a setting is set', () => {

front_end/core/sdk/CookieParser.test.ts

@@ -8,10 +8,7 @@ import {type CookieExpectation, expectCookie} from '../../testing/Cookies.js';
 import * as SDK from './sdk.js';
 
 function ensureCookiesExistOrFailTest(cookies: SDK.Cookie.Cookie[]|null): cookies is SDK.Cookie.Cookie[] {
-  if (!cookies) {
-    assert.fail('expected cookies to exist');
-    return false;
-  }
+  assert.exists(cookies, 'expected cookies to exist');
   return true;
 }
 

front_end/models/source_map_scopes/NamesResolver.test.ts

@@ -415,10 +415,7 @@ describeWithMockConnection('NameResolver', () => {
       const debuggerModel = target.model(SDK.DebuggerModel.DebuggerModel);
       const script = debuggerModel?.scripts()[0];
       const scriptId = script?.scriptId;
-      if (scriptId === undefined) {
-        assert.fail('Script id not found');
-        return;
-      }
+      assert.exists(scriptId, 'Script id not found');
       const {lineNumber, columnNumber} = scopeLocation;
       await script?.requestContentData();
       const functionName = await SourceMapScopes.NamesResolver.resolveProfileFrameFunctionName(

front_end/models/trace/handlers/LayoutShiftsHandler.test.ts

@@ -10,16 +10,13 @@ async function processTrace(context: Mocha.Suite|Mocha.Context|null, url: string
 
   Trace.Handlers.ModelHandlers.LayoutShifts.reset();
 
-  try {
-    const events = await TraceLoader.rawEvents(context, url);
-    for (const event of events) {
-      Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
-      Trace.Handlers.ModelHandlers.Screenshots.handleEvent(event);
-      Trace.Handlers.ModelHandlers.LayoutShifts.handleEvent(event);
-    }
-  } catch (error) {
-    assert.fail(error);
+  const events = await TraceLoader.rawEvents(context, url);
+  for (const event of events) {
+    Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
+    Trace.Handlers.ModelHandlers.Screenshots.handleEvent(event);
+    Trace.Handlers.ModelHandlers.LayoutShifts.handleEvent(event);
   }
+
   await Trace.Handlers.ModelHandlers.Meta.finalize();
   await Trace.Handlers.ModelHandlers.Screenshots.finalize();
   await Trace.Handlers.ModelHandlers.LayoutShifts.finalize();

front_end/models/trace/handlers/MetaHandler.test.ts

@@ -9,13 +9,7 @@ import * as Trace from '../trace.js';
 describe('MetaHandler', function() {
   let baseEvents: Trace.Types.Events.Event[];
   beforeEach(async function() {
-    let defaultTraceEvents: readonly Trace.Types.Events.Event[];
-    try {
-      defaultTraceEvents = await TraceLoader.rawEvents(this, 'basic.json.gz');
-    } catch (error) {
-      assert.fail(error);
-      return;
-    }
+    const defaultTraceEvents = await TraceLoader.rawEvents(this, 'basic.json.gz');
 
     baseEvents = [
       ...defaultTraceEvents,
@@ -123,10 +117,8 @@ describe('MetaHandler', function() {
       assert.strictEqual(data.navigationsByNavigationId.size, 1);
 
       const firstNavigation = data.navigationsByNavigationId.get('navigation-1');
-      if (!firstNavigation?.args.data) {
-        assert.fail('Navigation data was expected in trace events');
-        return;
-      }
+
+      assert.exists(firstNavigation?.args.data, 'Navigation data was expected in trace events');
 
       assert.strictEqual(firstNavigation.args.data.documentLoaderURL, 'test1');
     });
@@ -235,10 +227,8 @@ describe('MetaHandler', function() {
     assert.deepEqual([...data.topLevelRendererIds], [3601132]);
 
     const rendererProcesses = data.rendererProcessesByFrame.get(data.mainFrameId);
-    if (!rendererProcesses) {
-      assert.fail('No renderer processes found');
-      return;
-    }
+    assert.exists(rendererProcesses, 'No renderer processes found');
+
     assert.deepEqual([...rendererProcesses?.keys()], [3601132]);
     const windowMinTime = 1143381875846;
     assert.deepEqual(
@@ -272,10 +262,7 @@ describe('MetaHandler', function() {
     assert.deepEqual([...data.topLevelRendererIds], [78450, 78473, 79194]);
 
     const rendererProcesses = data.rendererProcessesByFrame.get(data.mainFrameId);
-    if (!rendererProcesses) {
-      assert.fail('No renderer processes found');
-      return;
-    }
+    assert.exists(rendererProcesses, 'No renderer processes found');
 
     const windowMinTime = 3550807444741;
     assert.deepEqual([...rendererProcesses?.keys()], [78450, 78473, 79194]);
@@ -329,10 +316,7 @@ describe('MetaHandler', function() {
     assert.deepEqual([...data.topLevelRendererIds], [2080]);
 
     const rendererProcesses = data.rendererProcessesByFrame.get(data.mainFrameId);
-    if (!rendererProcesses) {
-      assert.fail('No renderer processes found');
-      return;
-    }
+    assert.exists(rendererProcesses, 'No renderer processes found');
 
     assert.deepEqual([...rendererProcesses?.keys()], [2080]);
     assert.deepEqual([...rendererProcesses?.values()], [
@@ -423,7 +407,6 @@ describe('MetaHandler', function() {
       traceEvents = await TraceLoader.rawEvents(this, 'web-dev.json.gz');
     } catch (error) {
       assert.fail(error);
-      return;
     }
 
     Trace.Handlers.ModelHandlers.Meta.reset();

front_end/models/trace/handlers/NetworkRequestsHandler.test.ts

@@ -476,10 +476,7 @@ describe('NetworkRequestsHandler', function() {
 function assertDataArgsStats<D extends keyof DataArgs>(
     requests: Trace.Types.Events.SyntheticNetworkRequest[], url: string, stats: Map<D, DataArgs[D]>): void {
   const request = requests.find(request => request.args.data.url === url);
-  if (!request) {
-    assert.fail(`Unable to find request for URL ${url}`);
-    return;
-  }
+  assert.exists(request, `Unable to find request for URL ${url}`);
 
   for (const [name, value] of stats.entries()) {
     if (typeof request.args.data[name] === 'number') {
@@ -496,10 +493,7 @@ function assertDataArgsProcessedDataStats<D extends keyof DataArgsProcessedData>
     requests: Trace.Types.Events.SyntheticNetworkRequest[], url: string,
     stats: Map<D, DataArgsProcessedData[D]>): void {
   const request = requests.find(request => request.args.data.url === url);
-  if (!request) {
-    assert.fail(`Unable to find request for URL ${url}`);
-    return;
-  }
+  assert.exists(request, `Unable to find request for URL ${url}`);
 
   for (const [name, value] of stats.entries()) {
     if (typeof request.args.data.syntheticData[name] === 'number') {

front_end/models/trace/helpers/TreeHelpers.test.ts

@@ -230,37 +230,27 @@ describe('TreeHelpers', () => {
       const taskC = nodeC.entry;
 
       const taskCTotalTime = taskC.dur;
-      if (taskCTotalTime === undefined) {
-        assert.fail('Total time for task was not found');
-      }
+      assert.exists(taskCTotalTime, 'Total time for task was not found');
       assert.strictEqual(taskCTotalTime, Trace.Types.Timing.Micro(1));
       assert.strictEqual(nodeC.selfTime, taskCTotalTime);
 
       const taskBTotalTime = taskB.dur;
-      if (taskBTotalTime === undefined) {
-        assert.fail('Total time for task was not found');
-      }
+      assert.exists(taskBTotalTime, 'Total time for task was not found');
       assert.strictEqual(taskBTotalTime, Trace.Types.Timing.Micro(3));
       assert.strictEqual(nodeB.selfTime, Trace.Types.Timing.Micro(taskBTotalTime - taskCTotalTime));
 
       const taskDTotalTime = taskD.dur;
-      if (taskDTotalTime === undefined) {
-        assert.fail('Total time for task was not found');
-      }
+      assert.exists(taskDTotalTime, 'Total time for task was not found');
       assert.strictEqual(taskDTotalTime, Trace.Types.Timing.Micro(3));
       assert.strictEqual(nodeD.selfTime, taskDTotalTime);
 
       const taskATotalTime = taskA.dur;
-      if (taskATotalTime === undefined) {
-        assert.fail('Total time for task was not found');
-      }
+      assert.exists(taskATotalTime, 'Total time for task was not found');
       assert.strictEqual(taskATotalTime, Trace.Types.Timing.Micro(10));
       assert.strictEqual(nodeA.selfTime, Trace.Types.Timing.Micro(taskATotalTime - taskBTotalTime - taskDTotalTime));
 
       const taskETotalTime = taskE.dur;
-      if (taskETotalTime === undefined) {
-        assert.fail('Total time for task was not found');
-      }
+      assert.exists(taskETotalTime, 'Total time for task was not found');
       assert.strictEqual(taskETotalTime, Trace.Types.Timing.Micro(3));
       assert.strictEqual(nodeD.selfTime, taskETotalTime);
     });

front_end/panels/elements/StylePropertyTreeElement.test.ts

@@ -476,8 +476,7 @@ describeWithMockConnection('StylePropertyTreeElement', () => {
     const {valueElement} = stylePropertyTreeElement;
     assert.exists(valueElement);
 
-    const swatch = valueElement.querySelector<InlineEditor.ColorSwatch.ColorSwatch>('devtools-color-swatch');
-
+    const swatch = valueElement.querySelector('devtools-color-swatch');
     assert.exists(swatch);
 
     const expectedColorString = swatch.getColor()?.asString(Common.Color.Format.LAB);

front_end/panels/elements/components/ComputedStyleProperty.test.ts

@@ -27,10 +27,8 @@ describe('ComputedStyleProperty', () => {
         getEventPromise(component, ElementsComponents.ComputedStyleProperty.NavigateToSourceEvent.eventName);
 
     const goto = component.shadowRoot!.querySelector<HTMLElement>('.goto');
-    if (!goto) {
-      assert.fail('goto icon should exist');
-      return;
-    }
+    assert.exists(goto, 'goto icon should exist');
+
     goto.click();
     const event = await navigateEvent;
     assert.exists(event);