[AI Assistance] Remove time-based assertions in unit tests

Drive-by: a helper to create cancelled results with an error
and an extra check for the signal before triggering the side
effect UI.

Bug: 380394373
Change-Id: I93e805d86db663f9450a35e2a85396331b5d004a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6108440
Reviewed-by: Mathias Bynens <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>

Author: OrKoN

front_end/panels/ai_assistance/agents/StylingAgent.test.ts

@@ -712,8 +712,7 @@ c`;
       });
 
       it('returns error when side effect is aborted', async () => {
-        const promise = Promise.withResolvers();
-        const stub = sinon.stub().returns(promise);
+        const selected = new AiAssistance.NodeContext(element);
         async function* generateAction() {
           yield {
             explanation: `ACTION
@@ -725,26 +724,31 @@ c`;
         }
         const execJs = sinon.mock().once().throws(
             new AiAssistance.SideEffectError('EvalError: Possible side-effect in debug-evaluate'));
+        const sideEffectConfirmationPromise = Promise.withResolvers();
         const agent = new StylingAgent({
           aidaClient: mockAidaClient(generateAction),
           createExtensionScope,
-          confirmSideEffectForTest: stub,
+          confirmSideEffectForTest: sinon.stub().returns(sideEffectConfirmationPromise),
           execJs,
         });
-        const controller = new AbortController();
 
-        const agentPromise = Array.fromAsync(
-            agent.run('test', {selected: new AiAssistance.NodeContext(element), signal: controller.signal}));
-        await stub.calledOnce;
-        const awaitTimeout = (delay: number) => new Promise(resolve => setTimeout(resolve, delay));
-        await awaitTimeout(10).then(() => controller.abort());
-        const responses = await agentPromise;
+        const responses: AiAssistance.ResponseData[] = [];
+        const controller = new AbortController();
+        for await (const result of agent.run('test', {selected, signal: controller.signal})) {
+          responses.push(result);
+          if (result.type === 'side-effect') {
+            // Initial code invocation resulting in a side-effect
+            // happened.
+            assert.isTrue(execJs.calledOnce);
+            // Emulate abort when waiting for the side-effect confirmation.
+            controller.abort();
+          }
+        }
 
         const errorStep = responses.at(-1) as AiAssistance.ErrorResponse;
-        assert.strictEqual(execJs.getCalls().length, 1);
         assert.exists(errorStep);
         assert.strictEqual(errorStep.error, ErrorType.ABORT);
-        await promise.promise.then(value => assert.strictEqual(value, false));
+        assert.strictEqual(await sideEffectConfirmationPromise.promise, false);
       });
     });
 

front_end/panels/ai_assistance/agents/StylingAgent.ts

@@ -586,24 +586,25 @@ export class StylingAgent extends AiAgent<SDK.DOMModel.DOMNode> {
       handleAction(action: string, options?: {signal?: AbortSignal}):
           AsyncGenerator<SideEffectResponse, ActionResponse, void> {
     debugLog(`Action to execute: ${action}`);
-    if (this.executionMode === Root.Runtime.HostConfigFreestylerExecutionMode.NO_SCRIPTS) {
+
+    function createCancelledResult(output: string): ActionResponse {
       return {
         type: ResponseType.ACTION,
         code: action,
-        output: 'Error: JavaScript execution is currently disabled.',
+        output,
         canceled: true,
       };
     }
 
+    if (this.executionMode === Root.Runtime.HostConfigFreestylerExecutionMode.NO_SCRIPTS) {
+      return createCancelledResult('Error: JavaScript execution is currently disabled.');
+    }
+
     const selectedNode = UI.Context.Context.instance().flavor(SDK.DOMModel.DOMNode);
     const target = selectedNode?.domModel().target() ?? UI.Context.Context.instance().flavor(SDK.Target.Target);
     if (target?.model(SDK.DebuggerModel.DebuggerModel)?.selectedCallFrame()) {
-      return {
-        type: ResponseType.ACTION,
-        code: action,
-        output: 'Error: Cannot evaluate JavaScript because the execution is paused on a breakpoint.',
-        canceled: true,
-      };
+      return createCancelledResult(
+          'Error: Cannot evaluate JavaScript because the execution is paused on a breakpoint.');
     }
 
     const scope = this.#createExtensionScope(this.#changes);
@@ -613,16 +614,22 @@ export class StylingAgent extends AiAgent<SDK.DOMModel.DOMNode> {
       debugLog(`Action result: ${JSON.stringify(result)}`);
       if (result.sideEffect) {
         if (this.executionMode === Root.Runtime.HostConfigFreestylerExecutionMode.SIDE_EFFECT_FREE_SCRIPTS_ONLY) {
-          return {
-            type: ResponseType.ACTION,
-            code: action,
-            output: 'Error: JavaScript execution that modifies the page is currently disabled.',
-            canceled: true,
-          };
+          return createCancelledResult('Error: JavaScript execution that modifies the page is currently disabled.');
+        }
+
+        if (options?.signal?.aborted) {
+          return createCancelledResult('Error: evaluation has been cancelled');
         }
 
         const sideEffectConfirmationPromiseWithResolvers = this.#confirmSideEffect<boolean>();
 
+        void sideEffectConfirmationPromiseWithResolvers.promise.then(result => {
+          Host.userMetrics.actionTaken(
+              result ? Host.UserMetrics.Action.AiAssistanceSideEffectConfirmed :
+                       Host.UserMetrics.Action.AiAssistanceSideEffectRejected,
+          );
+        });
+
         options?.signal?.addEventListener('abort', () => {
           sideEffectConfirmationPromiseWithResolvers.resolve(false);
         }, {once: true});
@@ -632,10 +639,6 @@ export class StylingAgent extends AiAgent<SDK.DOMModel.DOMNode> {
           code: action,
           confirm: (result: boolean) => {
             sideEffectConfirmationPromiseWithResolvers.resolve(result);
-            Host.userMetrics.actionTaken(
-                result ? Host.UserMetrics.Action.AiAssistanceSideEffectConfirmed :
-                         Host.UserMetrics.Action.AiAssistanceSideEffectRejected,
-            );
           },
         };