Skip to content

Commit 5ab7c67

Browse files
hanselfmu-chromiumDevtools-frontend LUCI CQ
authored andcommitted
Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance. In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8705927456663003137 [email protected] Bug: none Change-Id: Ic7d07bb9176ed6a0ca843908d68b99227877563a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6870035 Commit-Queue: Changhao Han <[email protected]> Reviewed-by: Changhao Han <[email protected]> Reviewed-by: Alex Rudenko <[email protected]>
1 parent 94def37 commit 5ab7c67

File tree

13 files changed

+174
-125
lines changed

13 files changed

+174
-125
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ vars = {
2424
'inspector_protocol_revision': '07272ab9a30fd555890fda0718f4c2c25931653a',
2525

2626
# Keeping track of the last time we rolled the browser protocol files.
27-
'chromium_browser_protocol_revision' : 'd4bee3ec18917ad622065859583166224e0ca5f0',
27+
'chromium_browser_protocol_revision' : 'c3e5017b2e2396d8c18d68ccb6fccd5f1432e72a',
2828

2929
'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
3030
'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',

front_end/generated/InspectorBackendCommands.js

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

front_end/generated/SupportedCSSProperties.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1754,7 +1754,9 @@ export const generatedProperties = [
17541754
{
17551755
"longhands": [
17561756
"column-width",
1757-
"column-count"
1757+
"column-count",
1758+
"column-height",
1759+
"column-wrap"
17581760
],
17591761
"name": "columns"
17601762
},

front_end/generated/protocol-mapping.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -255,10 +255,10 @@ export namespace ProtocolMapping {
255255
'Media.playerErrorsRaised': [Protocol.Media.PlayerErrorsRaisedEvent];
256256
/**
257257
* Called whenever a player is created, or when a new agent joins and receives
258-
* a list of active players. If an agent is restored, it will receive the full
259-
* list of player ids and all events again.
258+
* a list of active players. If an agent is restored, it will receive one
259+
* event for each active player.
260260
*/
261-
'Media.playersCreated': [Protocol.Media.PlayersCreatedEvent];
261+
'Media.playerCreated': [Protocol.Media.PlayerCreatedEvent];
262262
/**
263263
* Fired when data chunk was received over the network.
264264
*/

front_end/generated/protocol-proxy-api.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2367,10 +2367,10 @@ declare namespace ProtocolProxyApi {
23672367

23682368
/**
23692369
* Called whenever a player is created, or when a new agent joins and receives
2370-
* a list of active players. If an agent is restored, it will receive the full
2371-
* list of player ids and all events again.
2370+
* a list of active players. If an agent is restored, it will receive one
2371+
* event for each active player.
23722372
*/
2373-
playersCreated(params: Protocol.Media.PlayersCreatedEvent): void;
2373+
playerCreated(params: Protocol.Media.PlayerCreatedEvent): void;
23742374

23752375
}
23762376

front_end/generated/protocol.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9418,6 +9418,11 @@ export namespace Media {
94189418
data: any;
94199419
}
94209420

9421+
export interface Player {
9422+
playerId: PlayerId;
9423+
domNodeId?: DOM.BackendNodeId;
9424+
}
9425+
94219426
/**
94229427
* This can be called multiple times, and can be used to set / override /
94239428
* remove player properties. A null propValue indicates removal.
@@ -9454,11 +9459,11 @@ export namespace Media {
94549459

94559460
/**
94569461
* Called whenever a player is created, or when a new agent joins and receives
9457-
* a list of active players. If an agent is restored, it will receive the full
9458-
* list of player ids and all events again.
9462+
* a list of active players. If an agent is restored, it will receive one
9463+
* event for each active player.
94599464
*/
9460-
export interface PlayersCreatedEvent {
9461-
players: PlayerId[];
9465+
export interface PlayerCreatedEvent {
9466+
player: Player;
94629467
}
94639468
}
94649469

0 commit comments

Comments
 (0)