[cleanup] Remove unused disable comments

This is already the case with EsLint, and it prevent issues
from being masked by accident.

Bug: 397260638
Change-Id: Ibcc80b76118bd398ae48447a827963c18a2a8f56
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397061
Reviewed-by: Benedikt Meurer <[email protected]>
Reviewed-by: Kateryna Prokopenko <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

.stylelintrc.json

@@ -1,8 +1,6 @@
 {
   "extends": "stylelint-config-standard",
-  "plugins": [
-    "./scripts/stylelint_rules/lib/use_theme_colors.mjs"
-  ],
+  "plugins": ["./scripts/stylelint_rules/lib/use_theme_colors.mjs"],
   "rules": {
     "plugin/use_theme_colors": true,
     "alpha-value-notation": "percentage",
@@ -14,10 +12,7 @@
     "selector-type-no-unknown": [
       true,
       {
-        "ignoreTypes": [
-          "/^devtools-/",
-          "/^dt-/"
-        ]
+        "ignoreTypes": ["/^devtools-/", "/^dt-/", "x-link"]
       }
     ],
     "selector-class-pattern": null,
@@ -27,5 +22,7 @@
     "value-no-vendor-prefix": null,
     "media-feature-name-no-vendor-prefix": null,
     "no-descending-specificity": null
-  }
+  },
+  "reportNeedlessDisables": true,
+  "reportUnscopedDisables": true
 }

front_end/panels/ai_assistance/components/chatView.css

@@ -45,9 +45,7 @@
 
   /* Prevents the input form from jumping when the scrollbar is shown */
   /* 688px is the max width of the input form + left and right paddings: var(--sys-size-36) + 2 * var(--sys-size-5)  */
-  /* stylelint-disable-next-line at-rule-no-unknown */
   @container (width > 688px) {
-    /* stylelint-disable-next-line unit-no-unknown */
     --half-scrollbar-width: calc((100cqw - 100%) / 2);
 
     margin-left: var(--half-scrollbar-width);
@@ -57,7 +55,6 @@
   /* when there isn't enough space to view the messages,
   do not overlay the input form on top of the messages */
   /* height < var(--sys-size-27) */
-  /* stylelint-disable-next-line at-rule-no-unknown */
   @container (height < 224px) {
     position: static;
   }
@@ -77,7 +74,6 @@
       box-shadow: 0 -3px 2px -2px var(--app-color-ai-assistance-input-divider);
       animation: reveal;
       opacity: 0%;
-      /* stylelint-disable-next-line property-no-unknown */
       animation-timeline: --scroll-timeline;
     }
   }
@@ -163,7 +159,7 @@
   ); /* Gap between the button and the edge + icon's width */
 
   scrollbar-width: none;
-  field-sizing: content; /* stylelint-disable-line property-no-unknown */
+  field-sizing: content;
   resize: none;
   width: 100%;
   max-height: 84px; /* 4 rows */
@@ -251,9 +247,7 @@
 
   /* Prevents the container from jumping when the scrollbar is shown */
   /* 688px is the max width of the input form + left and right paddings: var(--sys-size-36) + 2 * var(--sys-size-5)  */
-  /* stylelint-disable-next-line at-rule-no-unknown */
   @container (width > 688px) {
-    /* stylelint-disable-next-line unit-no-unknown */
     --half-scrollbar-width: calc((100cqw - 100%) / 2);
 
     margin-left: var(--half-scrollbar-width);
@@ -603,16 +597,14 @@ main {
   flex-direction: column;
   align-items: center;
   height: 100%;
-  container-type: size; /* stylelint-disable-line property-no-unknown */
+  container-type: size;
   scrollbar-width: thin;
   /*
   Even though `transform: translateZ(1px)` doesn't have a visual effect,
   it puts `main` element into another rendering layer which somehow
   fixes the `.input-form` jumping on scroll issue.
   */
   transform: translateZ(1px);
-
-  /* stylelint-disable-next-line property-no-unknown */
   scroll-timeline: --scroll-timeline y;
 }
 
@@ -628,9 +620,7 @@ main {
 
   /* Prevents the container from jumping when the scrollbar is shown */
   /* 688px is the max width of the input form + left and right paddings: var(--sys-size-36) + 2 * var(--sys-size-5)  */
-  /* stylelint-disable-next-line at-rule-no-unknown */
   @container (width > 688px) {
-    /* stylelint-disable-next-line unit-no-unknown */
     --half-scrollbar-width: calc((100cqw - 100%) / 2);
 
     margin-left: var(--half-scrollbar-width);

front_end/panels/application/preloading/components/preloadingDisabledInfobar.css

@@ -30,7 +30,7 @@
   grid-column-start: span 2;
 }
 
-x-link { /* stylelint-disable-line selector-type-no-unknown */
+x-link {
   color: var(--sys-color-primary);
   text-decoration-line: underline;
 }

front_end/panels/explain/components/consoleInsight.css

@@ -19,7 +19,6 @@
 .wrapper {
   background-color: var(--sys-color-cdt-base-container);
   border-radius: 16px;
-  /* stylelint-disable-next-line property-no-unknown */
   container-type: inline-size;
   display: grid;
   animation: expand var(--sys-motion-duration-medium2) var(--sys-motion-easing-emphasized) forwards;
@@ -177,7 +176,6 @@ footer {
   gap: 32px;
 }
 
-/* stylelint-disable-next-line at-rule-no-unknown */
 @container (max-width: 600px) {
   footer {
     gap: 8px;
@@ -279,15 +277,13 @@ details {
   margin-top: 10px;
 }
 
-/* stylelint-disable-next-line selector-pseudo-element-no-unknown */
 ::details-content {
   height: 0;
   transition:
     height var(--sys-motion-duration-short4) var(--sys-motion-easing-emphasized),
     content-visibility var(--sys-motion-duration-short4) var(--sys-motion-easing-emphasized) allow-discrete;
 }
 
-/* stylelint-disable-next-line selector-pseudo-element-no-unknown */
 [open]::details-content {
   height: auto;
 }
@@ -364,7 +360,7 @@ h2:focus-visible {
   display: table-cell;
 }
 
-.sources-list x-link.highlighted { /* stylelint-disable-line selector-type-no-unknown */
+.sources-list x-link.highlighted {
   animation: highlight-fadeout 2s;
 }
 

front_end/panels/lighthouse/lighthouseDialog.css

@@ -77,8 +77,7 @@
 
 .lighthouse-progress-bar.errored {
   width: 100%;
-  background: var(--sys-color-error); /* stylelint-disable-line plugin/use_theme_colors */
-  /* See: crbug.com/1152736 for color variable migration. */
+  background: var(--sys-color-error);
 }
 
 .lighthouse-progress-bar.loading {

front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css

@@ -116,10 +116,10 @@
 :host-context(.theme-with-dark-background) .highlight-chip:hover > .delete-highlight-container {
   display: flex;
   /* To avoid issues with stacking semi-transparent colors, we use a hardcoded solid color here. */
-  background: linear-gradient(90deg, transparent 0%, rgb(41 42 45) 25%); /* stylelint-disable-line plugin/use_theme_colors */
+  background: linear-gradient(90deg, transparent 0%, rgb(41 42 45) 25%);
 }
 
 :host-context(.theme-with-dark-background) .highlight-chip.focused:hover > .delete-highlight-container {
   /* To avoid issues with stacking semi-transparent colors, we use a hardcoded solid color here. */
-  background: linear-gradient(90deg, transparent 0%, rgb(48 55 68) 25%); /* stylelint-disable-line plugin/use_theme_colors */
+  background: linear-gradient(90deg, transparent 0%, rgb(48 55 68) 25%);
 }

front_end/panels/network/components/HeaderSectionRow.css

@@ -131,7 +131,7 @@
   color: var(--sys-color-token-subtle);
 }
 
-x-link .inline-icon { /* stylelint-disable-line selector-type-no-unknown */
+x-link .inline-icon {
   padding-right: 3px;
 }
 

front_end/panels/network/components/RequestHeadersView.css

@@ -147,11 +147,11 @@ div.raw-headers-row {
   color: var(--sys-color-on-surface);
 }
 
-x-link { /* stylelint-disable-line selector-type-no-unknown */
+x-link {
   position: relative;
 }
 
-x-link .inline-icon { /* stylelint-disable-line selector-type-no-unknown */
+x-link .inline-icon {
   padding-right: 3px;
 }
 

front_end/panels/network/networkLogView.css

@@ -228,8 +228,6 @@
 
 /* Resource preview icons */
 /* These rules are grouped by type */
-/* stylelint-disable no-duplicate-selectors */
-
 .network-log-grid.data-grid .icon.image {
   position: relative;
 }
@@ -292,7 +290,7 @@
 .network-log-grid.data-grid .trailing-link-icon {
   padding-left: 0.5ex;
 }
-/* stylelint-enable no-duplicate-selectors */
+
 /* This is part of the large color block declared above, but should not be
    extracted out. */
 .network-dim-cell {

front_end/panels/recorder/components/recordingView.css

@@ -32,7 +32,6 @@
   background-color: var(--sys-color-cdt-base-container);
   z-index: 0;
   position: relative;
-  /* stylelint-disable-next-line property-no-unknown */
   container: sections / inline-size;
 }
 
@@ -44,7 +43,7 @@
 }
 
 .section::after {
-  content: "";
+  content: '';
   border-bottom: 1px solid var(--sys-color-divider);
   position: absolute;
   left: 0;
@@ -69,7 +68,6 @@
   z-index: 2;
 }
 
-/* stylelint-disable-next-line at-rule-no-unknown */
 @container sections (max-width: 400px) {
   .screenshot-wrapper {
     display: none;
@@ -162,7 +160,7 @@
 }
 
 .header-title::before {
-  content: "";
+  content: '';
   min-width: 12px;
   height: 12px;
   display: inline-block;
@@ -341,19 +339,19 @@ devtools-split-view {
   min-height: 0;
 }
 
-[slot="main"] {
+[slot='main'] {
   overflow: hidden auto;
 }
 
-[slot="sidebar"] {
+[slot='sidebar'] {
   display: flex;
   flex-direction: column;
   overflow: auto;
   height: 100%;
   width: 100%;
 }
 
-[slot="sidebar"] .section-toolbar {
+[slot='sidebar'] .section-toolbar {
   border-bottom: 1px solid var(--sys-color-divider);
 }