[AI Assistance] Clean up code

Bug: none
Change-Id: I96e4e831937e4e8ecda8e3fd220d5cbff256f54f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6352461
Auto-Submit: Nikolay Vitkov <[email protected]>
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

front_end/panels/ai_assistance/AiAssistancePanel.test.ts

@@ -887,7 +887,7 @@ describeWithMockConnection('AI Assistance Panel', () => {
 
   describe('auto agent selection for panels', () => {
     const tests: Array<{
-      panel: {new (...args: any[]): UI.Panel.Panel},
+      panel: Platform.Constructor.Constructor<UI.Panel.Panel>,
       expectedConversationType: AiAssistance.ConversationType,
       featureFlagName: string,
     }> =

front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -824,9 +824,11 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   }
 
   #getChangeSummary(): string|undefined {
-    return (isAiAssistancePatchingEnabled() && this.#conversationAgent && !this.#conversation?.isReadOnly) ?
-        this.#changeManager.formatChangesForPatching(this.#conversationAgent.id, /* includeSourceLocation= */ true) :
-        undefined;
+    if (!isAiAssistancePatchingEnabled() || !this.#conversationAgent || this.#conversation?.isReadOnly) {
+      return;
+    }
+
+    return this.#changeManager.formatChangesForPatching(this.#conversationAgent.id, /* includeSourceLocation= */ true);
   }
 
   override async performUpdate(): Promise<void> {

front_end/panels/ai_assistance/ChangeManager.ts

@@ -41,7 +41,7 @@ export class ChangeManager {
     this.#stylesheetChanges.clear();
     const firstFailed = results.find(result => result.status === 'rejected');
     if (firstFailed) {
-      throw new Error(firstFailed.reason);
+      console.error(firstFailed.reason);
     }
   }
 
@@ -60,7 +60,7 @@ export class ChangeManager {
     } else {
       changes.push(change);
     }
-    const content = this.formatChangesForInspectoStylesheet(changes);
+    const content = this.#formatChangesForInspectorStylesheet(changes);
     await cssModel.setStyleSheetText(stylesheetId, content, true);
     this.#stylesheetChanges.set(stylesheetId, changes);
     return content;
@@ -74,7 +74,7 @@ export class ChangeManager {
         .join('\n\n');
   }
 
-  formatChangesForInspectoStylesheet(changes: Change[]): string {
+  #formatChangesForInspectorStylesheet(changes: Change[]): string {
     return changes
         .map(change => {
           return `.${change.className} {

front_end/panels/ai_assistance/agents/StylingAgent.ts

@@ -429,8 +429,8 @@ export class StylingAgent extends AiAgent<SDK.DOMModel.DOMNode> {
 
   #execJs: typeof executeJsCode;
 
-  changes: ChangeManager;
-  createExtensionScope: CreateExtensionScopeFunction;
+  #changes: ChangeManager;
+  #createExtensionScope: CreateExtensionScopeFunction;
 
   constructor(opts: AgentOptions) {
     super({
@@ -439,14 +439,17 @@ export class StylingAgent extends AiAgent<SDK.DOMModel.DOMNode> {
       confirmSideEffectForTest: opts.confirmSideEffectForTest,
     });
 
-    this.changes = opts.changeManager || new ChangeManager();
+    this.#changes = opts.changeManager || new ChangeManager();
     this.#execJs = opts.execJs ?? executeJsCode;
-    this.createExtensionScope = opts.createExtensionScope ?? ((changes: ChangeManager) => {
-                                  return new ExtensionScope(changes, this.id);
-                                });
+    this.#createExtensionScope = opts.createExtensionScope ?? ((changes: ChangeManager) => {
+                                   return new ExtensionScope(changes, this.id);
+                                 });
     SDK.TargetManager.TargetManager.instance().addModelListener(
-        SDK.ResourceTreeModel.ResourceTreeModel, SDK.ResourceTreeModel.Events.PrimaryPageChanged,
-        this.onPrimaryPageChanged, this);
+        SDK.ResourceTreeModel.ResourceTreeModel,
+        SDK.ResourceTreeModel.Events.PrimaryPageChanged,
+        this.onPrimaryPageChanged,
+        this,
+    );
 
     this.declareFunction<{
       title: string,
@@ -500,7 +503,7 @@ export class StylingAgent extends AiAgent<SDK.DOMModel.DOMNode> {
   }
 
   onPrimaryPageChanged(): void {
-    void this.changes.clear();
+    void this.#changes.clear();
   }
 
   protected override emulateFunctionCall(aidaResponse: Host.AidaClient.AidaResponse):
@@ -697,7 +700,7 @@ export class StylingAgent extends AiAgent<SDK.DOMModel.DOMNode> {
       };
     }
 
-    const scope = this.createExtensionScope(this.changes);
+    const scope = this.#createExtensionScope(this.#changes);
     await scope.install();
     try {
       let throwOnSideEffect = true;