[Eslint] Add a custom rule for enforcing as const in UIStrings

We needed to update other l10n related eslint rules and
`collect-strings` script to look for `as const` definitions as well.

Fixed: 397381592
Change-Id: Ia3eb9a97fa1595093fb332525f996039f7546d8e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6287325
Commit-Queue: Ergün Erdoğmuş <[email protected]>
Reviewed-by: Nikolay Vitkov <[email protected]>
Reviewed-by: Mathias Bynens <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>

Author: ergunsh

eslint.config.mjs

@@ -615,6 +615,7 @@ export default [
           rootFrontendDirectory: join(import.meta.dirname, 'front_end'),
         },
       ],
+      'rulesdir/enforce-ui-strings-as-const': 'error',
     },
   },
   {

front_end/core/common/ResourceType.ts

@@ -145,7 +145,7 @@ const UIStrings = {
    *@description Name of a network initiator type
    */
   webbundle: 'WebBundle',
-};
+} as const;
 const str_ = i18n.i18n.registerUIStrings('core/common/ResourceType.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 

front_end/core/common/Revealer.ts

@@ -54,7 +54,7 @@ const UIStrings = {
    * @description The UI destination when revealing loaded resources through the Animations panel
    */
   animationsPanel: 'Animations panel',
-};
+} as const;
 const str_ = i18n.i18n.registerUIStrings('core/common/Revealer.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 

front_end/core/common/SettingRegistration.ts

@@ -78,7 +78,7 @@ const UIStrings = {
    * @description Text for the privacy section of the page.
    */
   privacy: 'Privacy',
-};
+} as const;
 const str_ = i18n.i18n.registerUIStrings('core/common/SettingRegistration.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 let registeredSettings: SettingRegistration[] = [];

front_end/core/host/InspectorFrontendHost.ts

@@ -74,7 +74,7 @@ const UIStrings = {
    *@example {example.com} PH1
    */
   devtoolsS: 'DevTools - {PH1}',
-};
+} as const;
 const str_ = i18n.i18n.registerUIStrings('core/host/InspectorFrontendHost.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 

front_end/core/host/ResourceLoader.ts

@@ -65,7 +65,7 @@ const UIStrings = {
    *@description Name of an error category used in error messages
    */
   decodingDataUrlFailed: 'Decoding Data URL failed',
-};
+} as const;
 const str_ = i18n.i18n.registerUIStrings('core/host/ResourceLoader.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 export const ResourceLoader = {};

front_end/core/sdk/CPUProfilerModel.ts

@@ -43,7 +43,7 @@ const UIStrings = {
    *@example {2} PH1
    */
   profileD: 'Profile {PH1}',
-};
+} as const;
 const str_ = i18n.i18n.registerUIStrings('core/sdk/CPUProfilerModel.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 

front_end/core/sdk/CPUThrottlingManager.ts

@@ -30,7 +30,7 @@ const UIStrings = {
    * @description Text label indicating why an option is not available, because the user's device is not fast enough to emulate a device.
    */
   calibrationErrorDeviceTooWeak: 'Device is not powerful enough',
-};
+} as const;
 const str_ = i18n.i18n.registerUIStrings('core/sdk/CPUThrottlingManager.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);

front_end/core/sdk/CSSStyleSheetHeader.ts

@@ -24,7 +24,7 @@ const UIStrings = {
    *@description Error message to display when a source CSS file could not be retrieved.
    */
   thereWasAnErrorRetrievingThe: 'There was an error retrieving the source styles.',
-};
+} as const;
 const str_ = i18n.i18n.registerUIStrings('core/sdk/CSSStyleSheetHeader.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 

front_end/core/sdk/ChildTargetManager.ts

@@ -23,7 +23,7 @@ const UIStrings = {
    * targets at the same time in some scenarios.
    */
   main: 'Main',
-};
+} as const;
 const str_ = i18n.i18n.registerUIStrings('core/sdk/ChildTargetManager.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);