Skip to content

Commit 61007ff

Browse files
Adam RaineDevtools-frontend LUCI CQ
authored andcommitted
[RPP Observations] Update definition of "field data" in translation contexts
Bug: None Change-Id: I6f3cf66452585df8d909ac3c38a5592638ebcb4c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6079049 Reviewed-by: Connor Clark <[email protected]> Reviewed-by: Simon Zünd <[email protected]> Commit-Queue: Adam Raine <[email protected]>
1 parent e84aed6 commit 61007ff

File tree

4 files changed

+18
-18
lines changed

4 files changed

+18
-18
lines changed

front_end/panels/timeline/components/LiveMetricsView.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ const RTT_MINIMUM = 60;
4545

4646
const UIStrings = {
4747
/**
48-
* @description Title of a view that shows performance metrics from the local environment and field metrics collected from real users in the field.
48+
* @description Title of a view that shows performance metrics from the local environment and field metrics collected from real users. "field metrics" should be interpreted as "real user metrics".
4949
*/
5050
localAndFieldMetrics: 'Local and field metrics',
5151
/**
@@ -69,15 +69,15 @@ const UIStrings = {
6969
*/
7070
nextSteps: 'Next steps',
7171
/**
72-
* @description Title of a section that shows options for how real user data in the field should be fetched.
72+
* @description Title of a section that shows options for how real user data in the field should be fetched. This should be interpreted as "Real user data".
7373
*/
7474
fieldData: 'Field data',
7575
/**
7676
* @description Title of a section that shows settings to control the developers local testing environment.
7777
*/
7878
environmentSettings: 'Environment settings',
7979
/**
80-
* @description Label for an select box that selects which device type field data be shown for (e.g. desktop/mobile/all devices/etc).
80+
* @description Label for an select box that selects which device type field data be shown for (e.g. desktop/mobile/all devices/etc). "field data" should be interpreted as "real user data".
8181
* @example {Mobile} PH1
8282
*/
8383
showFieldDataForDevice: 'Show field data for device type: {PH1}',
@@ -91,7 +91,7 @@ const UIStrings = {
9191
*/
9292
network: 'Network: {PH1}',
9393
/**
94-
* @description Label for an select box that selects which device type field data be shown for (e.g. desktop/mobile/all devices/etc).
94+
* @description Label for an select box that selects which device type real user data should be shown for (e.g. desktop/mobile/all devices/etc).
9595
* @example {Mobile} PH1
9696
*/
9797
device: 'Device: {PH1}',
@@ -145,7 +145,7 @@ const UIStrings = {
145145
*/
146146
originOptionWithKey: 'Origin: {PH1}',
147147
/**
148-
* @description Label for an combo-box that indicates if field data should be taken from the page's URL or it's origin/domain.
148+
* @description Label for an combo-box that indicates if field data should be taken from the page's URL or it's origin/domain. "field data" should be interpreted as "real user data".
149149
* @example {Origin: https://example.com} PH1
150150
*/
151151
showFieldDataForPage: 'Show field data for {PH1}',
@@ -210,11 +210,11 @@ const UIStrings = {
210210
*/
211211
seeHowYourLocalMetricsCompare: 'See how your local metrics compare to real user data in the {PH1}.',
212212
/**
213-
* @description Text for a link that goes to more documentation about local and field data. "Local" refers to performance metrics measured in the developers local environment. "field data" is data measured by real users in the field.
213+
* @description Text for a link that goes to more documentation about local and field data. "Local" refers to performance metrics measured in the developers local environment. "field data" should be interpreted as "real user data".
214214
*/
215215
localFieldLearnMoreLink: 'Learn more about local and field data',
216216
/**
217-
* @description Tooltip text for a link that goes to documentation explaining the difference between local and field metrics. "Local metrics" are performance metrics measured in the developers local environment. "field data" is data measured by real users in the field.
217+
* @description Tooltip text for a link that goes to documentation explaining the difference between local and field metrics. "Local metrics" are performance metrics measured in the developers local environment. "field data" should be interpreted as "real user data".
218218
*/
219219
localFieldLearnMoreTooltip:
220220
'Local metrics are captured from the current page using your network connection and device. Field data is measured by real users using many different network connections and devices.',

front_end/panels/timeline/components/MetricCard.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const UIStrings = {
3131
*/
3232
localValue: 'Local',
3333
/**
34-
* @description Label for the 75th percentile of a metric according to data collected from real users in the field.
34+
* @description Label for the 75th percentile of a metric according to data collected from real users in the field. This should be interpreted as "75th percentile of real users".
3535
*/
3636
field75thPercentile: 'Field 75th percentile',
3737
/**

front_end/panels/timeline/components/MetricCompareStrings.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ const UIStrings = {
9090
*/
9191
poorSummarized: 'Your local {PH1} value of {PH2} is poor.',
9292
/**
93-
* @description Text block that compares a local metric value to real user experiences. "field data" refers to performance data collected from real users on the site. "local" refers to a developers local testing environment.
93+
* @description Text block that compares a local metric value to real user experiences. "field data" should be interpreted as "real user data". "local" refers to a developers local testing environment.
9494
* @example {LCP} PH1
9595
* @example {500 ms} PH2
9696
* @example {400 ms} PH3
@@ -99,7 +99,7 @@ const UIStrings = {
9999
goodGoodDetailedCompare:
100100
'Your local {PH1} value of {PH2} is good and is rated the same as {PH4} of real-user {PH1} experiences. Additionally, the field data 75th percentile {PH1} value of {PH3} is good.',
101101
/**
102-
* @description Text block that compares a local metric value to real user experiences. "field data" refers to performance data collected from real users on the site. "local" refers to a developers local testing environment.
102+
* @description Text block that compares a local metric value to real user experiences. "field data" should be interpreted as "real user data". "local" refers to a developers local testing environment.
103103
* @example {LCP} PH1
104104
* @example {500 ms} PH2
105105
* @example {400 ms} PH3
@@ -108,7 +108,7 @@ const UIStrings = {
108108
goodNeedsImprovementDetailedCompare:
109109
'Your local {PH1} value of {PH2} is good and is rated the same as {PH4} of real-user {PH1} experiences. However, the field data 75th percentile {PH1} value of {PH3} needs improvement.',
110110
/**
111-
* @description Text block that compares a local metric value to real user experiences. "field data" refers to performance data collected from real users on the site. "local" refers to a developers local testing environment.
111+
* @description Text block that compares a local metric value to real user experiences. "field data" should be interpreted as "real user data". "local" refers to a developers local testing environment.
112112
* @example {LCP} PH1
113113
* @example {500 ms} PH2
114114
* @example {400 ms} PH3
@@ -117,7 +117,7 @@ const UIStrings = {
117117
goodPoorDetailedCompare:
118118
'Your local {PH1} value of {PH2} is good and is rated the same as {PH4} of real-user {PH1} experiences. However, the field data 75th percentile {PH1} value of {PH3} is poor.',
119119
/**
120-
* @description Text block that compares a local metric value to real user experiences. "field data" refers to performance data collected from real users on the site. "local" refers to a developers local testing environment.
120+
* @description Text block that compares a local metric value to real user experiences. "field data" should be interpreted as "real user data". "local" refers to a developers local testing environment.
121121
* @example {LCP} PH1
122122
* @example {500 ms} PH2
123123
* @example {400 ms} PH3
@@ -126,7 +126,7 @@ const UIStrings = {
126126
needsImprovementGoodDetailedCompare:
127127
'Your local {PH1} value of {PH2} needs improvement and is rated the same as {PH4} of real-user {PH1} experiences. However, the field data 75th percentile {PH1} value of {PH3} is good.',
128128
/**
129-
* @description Text block that compares a local metric value to real user experiences. "field data" refers to performance data collected from real users on the site. "local" refers to a developers local testing environment.
129+
* @description Text block that compares a local metric value to real user experiences. "field data" should be interpreted as "real user data". "local" refers to a developers local testing environment.
130130
* @example {LCP} PH1
131131
* @example {500 ms} PH2
132132
* @example {400 ms} PH3
@@ -135,7 +135,7 @@ const UIStrings = {
135135
needsImprovementNeedsImprovementDetailedCompare:
136136
'Your local {PH1} value of {PH2} needs improvement and is rated the same as {PH4} of real-user {PH1} experiences. Additionally, the field data 75th percentile {PH1} value of {PH3} needs improvement.',
137137
/**
138-
* @description Text block that compares a local metric value to real user experiences. "field data" refers to performance data collected from real users on the site. "local" refers to a developers local testing environment.
138+
* @description Text block that compares a local metric value to real user experiences. "field data" should be interpreted as "real user data". "local" refers to a developers local testing environment.
139139
* @example {LCP} PH1
140140
* @example {500 ms} PH2
141141
* @example {400 ms} PH3
@@ -144,7 +144,7 @@ const UIStrings = {
144144
needsImprovementPoorDetailedCompare:
145145
'Your local {PH1} value of {PH2} needs improvement and is rated the same as {PH4} of real-user {PH1} experiences. However, the field data 75th percentile {PH1} value of {PH3} is poor.',
146146
/**
147-
* @description Text block that compares a local metric value to real user experiences. "field data" refers to performance data collected from real users on the site. "local" refers to a developers local testing environment.
147+
* @description Text block that compares a local metric value to real user experiences. "field data" should be interpreted as "real user data". "local" refers to a developers local testing environment.
148148
* @example {LCP} PH1
149149
* @example {500 ms} PH2
150150
* @example {400 ms} PH3
@@ -153,7 +153,7 @@ const UIStrings = {
153153
poorGoodDetailedCompare:
154154
'Your local {PH1} value of {PH2} is poor and is rated the same as {PH4} of real-user {PH1} experiences. However, the field data 75th percentile {PH1} value of {PH3} is good.',
155155
/**
156-
* @description Text block that compares a local metric value to real user experiences. "field data" refers to performance data collected from real users on the site. "local" refers to a developers local testing environment.
156+
* @description Text block that compares a local metric value to real user experiences. "field data" should be interpreted as "real user data". "local" refers to a developers local testing environment.
157157
* @example {LCP} PH1
158158
* @example {500 ms} PH2
159159
* @example {400 ms} PH3
@@ -162,7 +162,7 @@ const UIStrings = {
162162
poorNeedsImprovementDetailedCompare:
163163
'Your local {PH1} value of {PH2} is poor and is rated the same as {PH4} of real-user {PH1} experiences. However, the field data 75th percentile {PH1} value of {PH3} needs improvement.',
164164
/**
165-
* @description Text block that compares a local metric value to real user experiences. "field data" refers to performance data collected from real users on the site. "local" refers to a developers local testing environment.
165+
* @description Text block that compares a local metric value to real user experiences. "field data" should be interpreted as "real user data". "local" refers to a developers local testing environment.
166166
* @example {LCP} PH1
167167
* @example {500 ms} PH2
168168
* @example {400 ms} PH3

scripts/generate_metric_compare_strings.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ for (const [localRating, localRatingText] of Object.entries(ratings)) {
6060
const tag = camelize(localRating) + capitalizeFirstLetter(camelize(fieldRating)) + 'DetailedCompare';
6161
const transition = localRating === fieldRating ? 'Additionally' : 'However';
6262
console.log(` /**
63-
* @description Text block that compares a local metric value to real user experiences. "field data" refers to performance data collected from real users on the site. "local" refers to a developers local testing environment.
63+
* @description Text block that compares a local metric value to real user experiences. "field data" should be interpreted as "real user data". "local" refers to a developers local testing environment.
6464
* @example {LCP} PH1
6565
* @example {500 ms} PH2
6666
* @example {400 ms} PH3

0 commit comments

Comments
 (0)