[GdpIntegration] Make getProfile request and render the profile settings

Drive-by:
* Added a check to `GdpClient` to make sure to not make a request to backend when the feature is not available.

Bug: 436202677
Change-Id: Ica058e2fd22b8a53334fbd538554e6d5ce6ce85a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6903164
Commit-Queue: Ergün Erdoğmuş <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>

Author: ergunsh

front_end/core/host/GdpClient.test.ts

@@ -2,12 +2,20 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import {updateHostConfig} from '../../testing/EnvironmentHelpers.js';
+
 import * as Host from './host.js';
 
 describe('GdpClient', () => {
   let dispatchHttpRequestStub:
       sinon.SinonStub<Parameters<typeof Host.InspectorFrontendHost.InspectorFrontendHostInstance.dispatchHttpRequest>>;
   beforeEach(() => {
+    updateHostConfig({
+      devToolsGdpProfiles: {
+        enabled: true,
+      }
+    });
+
     dispatchHttpRequestStub =
         sinon.stub(Host.InspectorFrontendHost.InspectorFrontendHostInstance, 'dispatchHttpRequest')
             .callsFake((request, cb) => {
@@ -32,4 +40,19 @@ describe('GdpClient', () => {
 
     sinon.assert.calledOnce(dispatchHttpRequestStub);
   });
+
+  describe('when the integration is disabled', () => {
+    it('should not make a request', async () => {
+      updateHostConfig({
+        devToolsGdpProfiles: {
+          enabled: false,
+        },
+      });
+
+      const profile = await Host.GdpClient.GdpClient.instance({forceNew: true}).getProfile();
+
+      assert.isNull(profile);
+      sinon.assert.notCalled(dispatchHttpRequestStub);
+    });
+  });
 });

front_end/core/host/GdpClient.ts

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as Root from '../root/root.js';
+
 import {InspectorFrontendHostInstance} from './InspectorFrontendHost.js';
 import type {DispatchHttpRequestRequest, DispatchHttpRequestResult} from './InspectorFrontendHostAPI.js';
 
@@ -47,7 +49,11 @@ export interface Profile {
   };
 }
 
-async function dispatchHttpRequestPromise<R extends object>(request: DispatchHttpRequestRequest): Promise<R|null> {
+async function makeHttpRequest<R extends object>(request: DispatchHttpRequestRequest): Promise<R|null> {
+  if (!Root.Runtime.hostConfig.devToolsGdpProfiles?.enabled) {
+    return null;
+  }
+
   const response = await new Promise<DispatchHttpRequestResult>(resolve => {
     InspectorFrontendHostInstance.dispatchHttpRequest(request, resolve);
   });
@@ -78,12 +84,17 @@ export class GdpClient {
     return gdpClientInstance;
   }
 
+  async initialize(): Promise<void> {
+    void this.getProfile();
+    void this.checkEligibility();
+  }
+
   async getProfile(): Promise<Profile|null> {
     if (this.#cachedProfilePromise) {
       return await this.#cachedProfilePromise;
     }
 
-    this.#cachedProfilePromise = dispatchHttpRequestPromise({
+    this.#cachedProfilePromise = makeHttpRequest({
       service: SERVICE_NAME,
       path: '/v1beta1/profile:get',
       method: 'GET',
@@ -97,13 +108,13 @@ export class GdpClient {
     }
 
     this.#cachedEligibilityPromise =
-        dispatchHttpRequestPromise({service: SERVICE_NAME, path: '/v1beta1/eligibility:check', method: 'GET'});
+        makeHttpRequest({service: SERVICE_NAME, path: '/v1beta1/eligibility:check', method: 'GET'});
 
     return await this.#cachedEligibilityPromise;
   }
 
   createProfile({user, emailPreference}: {user: string, emailPreference: EmailPreference}): Promise<Profile|null> {
-    return dispatchHttpRequestPromise({
+    return makeHttpRequest({
       service: SERVICE_NAME,
       path: '/v1beta1/profiles',
       method: 'POST',

front_end/entrypoints/main/MainImpl.ts

@@ -524,6 +524,11 @@ export class MainImpl {
     UI.ShortcutRegistry.ShortcutRegistry.instance({forceNew: true, actionRegistry: actionRegistryInstance});
     this.#registerMessageSinkListener();
 
+    // Initialize `GDPClient` for Google Developer Program integration
+    if (Root.Runtime.hostConfig.devToolsGdpProfiles?.enabled) {
+      void Host.GdpClient.GdpClient.instance().initialize();
+    }
+
     MainImpl.timeEnd('Main._createAppUI');
 
     const appProvider = Common.AppProvider.getRegisteredAppProviders()[0];

front_end/panels/settings/SettingsScreen.ts

@@ -335,17 +335,25 @@ export class GenericSettingsTab extends UI.Widget.VBox implements SettingsTab {
       window.clearTimeout(this.#updateSyncSectionTimerId);
       this.#updateSyncSectionTimerId = -1;
     }
-    Host.InspectorFrontendHost.InspectorFrontendHostInstance.getSyncInformation(syncInfo => {
-      this.syncSection.data = {
-        syncInfo,
-        syncSetting: Common.Settings.moduleSetting('sync-preferences') as Common.Settings.Setting<boolean>,
-        receiveBadgesSetting: Common.Settings.Settings.instance().moduleSetting('receive-gdp-badges'),
-        gdpProfile: undefined,
-      };
-      if (!syncInfo.isSyncActive || !syncInfo.arePreferencesSynced) {
-        this.#updateSyncSectionTimerId = window.setTimeout(this.updateSyncSection.bind(this), 500);
-      }
-    });
+
+    void Promise
+        .all([
+          new Promise<Host.InspectorFrontendHostAPI.SyncInformation>(
+              resolve => Host.InspectorFrontendHost.InspectorFrontendHostInstance.getSyncInformation(resolve)),
+          Root.Runtime.hostConfig.devToolsGdpProfiles?.enabled ? Host.GdpClient.GdpClient.instance().getProfile() :
+                                                                 Promise.resolve(undefined),
+        ])
+        .then(([syncInfo, gdpProfile]) => {
+          this.syncSection.data = {
+            syncInfo,
+            syncSetting: Common.Settings.moduleSetting('sync-preferences') as Common.Settings.Setting<boolean>,
+            receiveBadgesSetting: Common.Settings.Settings.instance().moduleSetting('receive-gdp-badges'),
+            gdpProfile: gdpProfile ?? undefined,
+          };
+          if (!syncInfo.isSyncActive || !syncInfo.arePreferencesSynced) {
+            this.#updateSyncSectionTimerId = window.setTimeout(this.updateSyncSection.bind(this), 500);
+          }
+        });
   }
 
   private createExtensionSection(settings: Common.Settings.SettingRegistration[]): void {