Set timeout for all SnapshotTester tests.

Bug: 449129415
Change-Id: I354a3862254d9592c4dd67cbea3149d82f2efab3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7097518
Auto-Submit: Connor Clark <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
Commit-Queue: Connor Clark <[email protected]>

Author: Connor Clark

front_end/core/sdk/RehydratingConnection.test.ts

@@ -193,11 +193,11 @@ describe('RehydratingSession', () => {
   });
 });
 
-describeWithEnvironment('RehydratingConnection emittance', () => {
+describeWithEnvironment('RehydratingConnection emittance', function() {
   let snapshotTester: SnapshotTester;
 
   before(async () => {
-    snapshotTester = new SnapshotTester(import.meta);
+    snapshotTester = new SnapshotTester(this, import.meta);
     await snapshotTester.load();
 
     // Create fake popup opener as rehydrating connection needs it.

front_end/models/ai_assistance/AiHistoryStorage.test.ts

@@ -546,10 +546,10 @@ describe('AiHistoryStorage', () => {
     });
   });
 
-  describe('getConversationMarkdown', () => {
+  describe('getConversationMarkdown', function() {
     let snapshotTester: SnapshotTester;
     before(async () => {
-      snapshotTester = new SnapshotTester(import.meta);
+      snapshotTester = new SnapshotTester(this, import.meta);
       await snapshotTester.load();
     });
 

front_end/models/ai_assistance/agents/StylingAgent.test.ts

@@ -17,7 +17,7 @@ import * as AiAssistance from '../ai_assistance.js';
 
 const {StylingAgent, AiAgent} = AiAssistance;
 
-describeWithEnvironment('StylingAgent', () => {
+describeWithEnvironment('StylingAgent', function() {
   function mockHostConfig(
       modelId?: string, temperature?: number, userTier?: string,
       executionMode?: Root.Runtime.HostConfigFreestylerExecutionMode, multimodal?: boolean) {
@@ -62,7 +62,7 @@ describeWithEnvironment('StylingAgent', () => {
 
   let snapshotTester: SnapshotTester;
   before(async () => {
-    snapshotTester = new SnapshotTester(import.meta);
+    snapshotTester = new SnapshotTester(this, import.meta);
     await snapshotTester.load();
   });
 

front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.test.ts

@@ -16,7 +16,7 @@ describeWithLocale('PerformanceInsightFormatter', function() {
 
   let snapshotTester: SnapshotTester;
   before(async () => {
-    snapshotTester = new SnapshotTester(import.meta);
+    snapshotTester = new SnapshotTester(this, import.meta);
     await snapshotTester.load();
   });
 

front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.test.ts

@@ -23,11 +23,9 @@ async function createFormatter(context: Mocha.Context|Mocha.Suite|null, name: st
 }
 
 describeWithLocale('PerformanceTraceFormatter', function() {
-  this.timeout(20000);
-
   let snapshotTester: SnapshotTester;
   before(async () => {
-    snapshotTester = new SnapshotTester(import.meta);
+    snapshotTester = new SnapshotTester(this, import.meta);
     await snapshotTester.load();
   });
 

front_end/models/ai_assistance/performance/AICallTree.test.ts

@@ -11,10 +11,10 @@ import {AICallTree} from '../ai_assistance.js';
 
 const NODE_NAME_INDEX = 2;
 
-describeWithEnvironment('AICallTree', () => {
+describeWithEnvironment('AICallTree', function() {
   let snapshotTester: SnapshotTester;
   before(async () => {
-    snapshotTester = new SnapshotTester(import.meta);
+    snapshotTester = new SnapshotTester(this, import.meta);
     await snapshotTester.load();
   });
 

front_end/panels/ai_assistance/AiAssistancePanel.test.ts

@@ -1738,10 +1738,10 @@ describeWithMockConnection('AI Assistance Panel', () => {
     });
   });
 
-  describe('getResponseMarkdown', () => {
+  describe('getResponseMarkdown', function() {
     let snapshotTester: SnapshotTester;
     before(async () => {
-      snapshotTester = new SnapshotTester(import.meta);
+      snapshotTester = new SnapshotTester(this, import.meta);
       await snapshotTester.load();
     });
 

front_end/testing/README.md

@@ -101,7 +101,7 @@ To add snapshot tests to a new test file, add a before and after hook to the des
 ```
 let snapshotTester: SnapshotTester;
 before(async () => {
-  snapshotTester = new SnapshotTester(import.meta);
+  snapshotTester = new SnapshotTester(this, import.meta);
   await snapshotTester.load();
 });
 

front_end/testing/SnapshotTester.test.ts

@@ -4,11 +4,10 @@
 
 import {SnapshotTester} from './SnapshotTester.js';
 
-// Started failing and blocking CfT rolls since 143.0.7447.0
-describe.skip('[crbug.com/449129415]: SnapshotTester', () => {
+describe('SnapshotTester', function() {
   let snapshotTester: SnapshotTester;
   before(async () => {
-    snapshotTester = new SnapshotTester(import.meta);
+    snapshotTester = new SnapshotTester(this, import.meta);
     await snapshotTester.load();
   });
 

front_end/testing/SnapshotTester.ts

@@ -37,7 +37,13 @@ class BaseSnapshotTester {
   #anyFailures = false;
   #newTests = false;
 
-  constructor(meta: ImportMeta) {
+  constructor(context: Mocha.Suite, meta: ImportMeta) {
+    if (context.timeout() > 0) {
+      // The first usage of SnapshotTester in a test seems to take an extraordinary
+      // amount of time, so let's bump the timeout for all snapshot tests.
+      context.timeout(Math.max(context.timeout(), 45000));
+    }
+
     // out/Default/gen/third_party/devtools-frontend/src/front_end/testing/SnapshotTester.test.js?8ee4f2b123e221040a4aa075a28d0e5b41d3d3ed
     // ->
     // front_end/testing/SnapshotTester.snapshot.txt