[RPP] Open the shortcuts dialog once after it ships

Bug: 313757601
Change-Id: I8fb12f7c5071629b0761df4e6e9dca0ace049b64
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6088883
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Alina Varkki <[email protected]>
Auto-Submit: Alina Varkki <[email protected]>

Author: AlinaVarkki

front_end/panels/timeline/TimelinePanel.ts

@@ -459,6 +459,13 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
 
   #eventToRelatedInsights: TimelineComponents.RelatedInsightChips.EventToRelatedInsightsMap = new Map();
   #shortcutsDialog: Dialogs.ShortcutDialog.ShortcutDialog = new Dialogs.ShortcutDialog.ShortcutDialog();
+  /**
+   * Track if the user has opened the shortcuts dialog before. We do this so that the
+   * very first time the performance panel is open after the shortcuts dialog ships, we can
+   * automatically pop it open to aid discovery.
+   */
+  #userHadShortcutsDialogOpenedOnce = Common.Settings.Settings.instance().createSetting<boolean>(
+      'timeline.user-had-shortcuts-dialog-opened-once', false);
   /**
    * Navigation radio buttons located in the shortcuts dialog.
    */
@@ -1127,7 +1134,11 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
 
   #setupNavigationSetting(): HTMLElement {
     const currentNavSetting = Common.Settings.moduleSetting('flamechart-selected-navigation').get();
-    this.#shortcutsDialog.data = {shortcuts: this.#getShortcutsInfo(currentNavSetting === 'classic')};
+    const userHadShortcutsDialogOpenedOnce = this.#userHadShortcutsDialogOpenedOnce.get();
+    this.#shortcutsDialog.data = {
+      shortcuts: this.#getShortcutsInfo(currentNavSetting === 'classic'),
+      open: !userHadShortcutsDialogOpenedOnce,
+    };
 
     this.#navigationRadioButtons.classList.add('nav-radio-buttons');
     UI.ARIAUtils.markAsRadioGroup(this.#navigationRadioButtons);
@@ -1148,6 +1159,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
     this.#classicNavRadioButton.setAttribute(
         'jslog', `${VisualLogging.action().track({click: true}).context('flamechart-select-classic-navigation')}`);
 
+    this.#userHadShortcutsDialogOpenedOnce.set(true);
     return this.#navigationRadioButtons;
   }
 

front_end/ui/visual_logging/KnownContextValues.ts

@@ -3409,7 +3409,6 @@ export const knownContextValues = new Set([
   'timeline-tree-current-thread',
   'timeline-tree-group-by',
   'timeline-user-has-opened-sidebar-once',
-  'timeline-user-has-opened-siderbar-once',
   'timeline-v8-runtime-call-stats',
   'timeline.animations',
   'timeline.annotation-sidebar.annotation-entries-link',
@@ -3524,6 +3523,7 @@ export const knownContextValues = new Set([
   'timeline.toggle-insight.third-parties',
   'timeline.toggle-insight.viewport',
   'timeline.toggle-recording',
+  'timeline.user-had-shortcuts-dialog-opened-once',
   'timelineOverviewMode',
   'timeout',
   'timer',