[cleanup] Remove deprecated functions in EsLint rule

This remove some deprecated functions that were still around after
the v9 migration, which will be remove in the next Major

Also adds types to some places to remove some anys from the code.

Bug: none
Change-Id: I668c4f92566fb838cb99c740458e316447d1fdb1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6730900
Auto-Submit: Nikolay Vitkov <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

scripts/eslint_rules/lib/check-css-import.ts

@@ -28,7 +28,7 @@ export default createRule({
   },
   defaultOptions: [],
   create: function(context) {
-    const filename = context.getFilename();
+    const filename = context.filename;
     return {
       ImportDeclaration(node) {
         const importPath = path.normalize(`${node.source.value}`);

scripts/eslint_rules/lib/check-license-header.ts

@@ -149,8 +149,8 @@ export default createRule({
   },
   defaultOptions: [],
   create: function(context) {
-    const sourceCode = context.sourceCode ?? context.getSourceCode();
-    const filename = context.filename ?? context.getFilename();
+    const sourceCode = context.sourceCode;
+    const filename = context.filename;
     const fileName = filename;
     // Fix windows paths for exemptions
     const relativePath = path.relative(FRONT_END_FOLDER, fileName).replace(/\\/g, '/');

scripts/eslint_rules/lib/check-test-definitions.ts

@@ -41,7 +41,7 @@ export default createRule({
   },
   defaultOptions: [],
   create: function(context) {
-    const sourceCode = context.sourceCode ?? context.getSourceCode();
+    const sourceCode = context.sourceCode;
     return {
       MemberExpression(node) {
         if (node.object.type !== 'Identifier' || node.property.type !== 'Identifier') {

scripts/eslint_rules/lib/enforce-custom-element-definitions-location.ts

@@ -35,7 +35,7 @@ export default createRule<[{rootFrontendDirectory: string}], 'definitionInWrongF
   },
   defaultOptions: [{rootFrontendDirectory: ''}],
   create: function(context) {
-    const filename = context.filename ?? context.getFilename();
+    const filename = context.filename;
     const classDefiningFileName = path.resolve(filename);
 
     let frontEndDirectory = '';

scripts/eslint_rules/lib/html-tagged-template.ts

@@ -25,15 +25,15 @@ export default createRule({
   },
   defaultOptions: [],
   create: function(context) {
-    const sourceCode = context.sourceCode ?? context.getSourceCode();
+    const sourceCode = context.sourceCode;
     let lastImport: ImportDeclaration|null = null;
     let shorthandDefined = false;
     return {
       ImportDeclaration(node) {
         lastImport = node;
       },
       VariableDeclarator(node) {
-        const scope = sourceCode.getScope ? sourceCode.getScope(node) : context.getScope();
+        const scope = sourceCode.getScope(node);
         if (scope.type !== 'module') {
           return;
         }

scripts/eslint_rules/lib/inline-type-imports.ts

@@ -83,7 +83,7 @@ export default createRule({
       }
       const importStart = valueImportNode.range[0];
       // Find the 'type' keyword after 'import'. It should be the first token after 'import'.
-      const sourceCode = context.sourceCode ?? context.getSourceCode();
+      const sourceCode = context.sourceCode;
       const importToken = sourceCode.getFirstToken(valueImportNode);
       const typeToken = importToken ? sourceCode.getTokenAfter(importToken) : null;
 

scripts/eslint_rules/lib/no-commented-out-console.ts

@@ -20,7 +20,7 @@ export default createRule({
   },
   defaultOptions: [],
   create: function(context) {
-    const sourceCode = context.sourceCode ?? context.getSourceCode();
+    const sourceCode = context.sourceCode;
 
     function checkCommentAndReportError(comment) {
       const trimmed = comment.value.trim();

scripts/eslint_rules/lib/no-imperative-dom-api.ts

@@ -63,7 +63,7 @@ export default createRule({
   },
   defaultOptions: [],
   create: function(context) {
-    const sourceCode = context.getSourceCode();
+    const sourceCode = context.sourceCode;
 
     const subrules: Subrule[] = [
       adorner.create(context),

scripts/eslint_rules/lib/no-imperative-dom-api/adorner.ts

@@ -7,14 +7,15 @@
 
 import type {TSESTree} from '@typescript-eslint/utils';
 
-import {isIdentifier, isIdentifierChain} from './ast.ts';
+import {type Context, isIdentifier, isIdentifierChain} from './ast.ts';
 import {DomFragment} from './dom-fragment.ts';
+
 type Identifier = TSESTree.Identifier;
 type Node = TSESTree.Node;
 
 export const adorner = {
-  create(context) {
-    const sourceCode = context.getSourceCode();
+  create(context: Context) {
+    const sourceCode = context.sourceCode;
     return {
       propertyAssignment(property: Identifier, propertyValue: Node, domFragment: DomFragment) {
         if (domFragment.tagName === 'devtools-adorner' && isIdentifier(property, 'data') &&

scripts/eslint_rules/lib/no-imperative-dom-api/aria-utils.ts

@@ -7,15 +7,15 @@
 
 import type {TSESTree} from '@typescript-eslint/utils';
 
-import {isIdentifier, isIdentifierChain, isMemberExpression} from './ast.ts';
+import {type Context, isIdentifier, isIdentifierChain, isMemberExpression} from './ast.ts';
 import type {DomFragment} from './dom-fragment.ts';
 
 type Node = TSESTree.Node;
 type CallExpression = TSESTree.CallExpression;
 type Identifier = TSESTree.Identifier;
 
 export const ariaUtils = {
-  create(_) {
+  create(_context: Context) {
     return {
       functionCall(call: CallExpression, _firstArg: Node, secondArg: Node, domFragment: DomFragment): boolean {
         const func = isMemberExpression(