[Patch agent] Remove first-run-disclaimer

wolfib · Devtools-frontend LUCI CQ · commit 6353dded5043 · 2025-03-28T05:55:58.000-07:00
The disclaimer was only needed for connecting workspaces from within the patch agent UI. Since the patch agent now only uses workspaces if they have already been set up before via the Sources panel, the patch agent's first-run-disclaimer can be removed. Fixed: 406686142 Change-Id: I18b28475ac9904fd65a8041f96d36986804169c1 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405319 Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org> Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org> Auto-Submit: Wolfgang Beyer <wolfi@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
diff --git a/front_end/panels/ai_assistance/BUILD.gn b/front_end/panels/ai_assistance/BUILD.gn
@@ -36,7 +36,6 @@ devtools_module("ai_assistance") {
     "../../models/workspace:bundle",
     "../../models/workspace_diff:bundle",
     "../../panels/changes:bundle",
-    "../../panels/common:bundle",
     "../../panels/elements:bundle",
     "../../panels/network:bundle",
     "../../panels/sources:bundle",
diff --git a/front_end/panels/ai_assistance/PatchWidget.test.ts b/front_end/panels/ai_assistance/PatchWidget.test.ts
@@ -2,12 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import * as Common from '../../core/common/common.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
 import * as AiAssistanceModel from '../../models/ai_assistance/ai_assistance.js';
 import * as Workspace from '../../models/workspace/workspace.js';
-import * as PanelCommon from '../../panels/common/common.js';
 import {
   cleanup,
   createPatchWidget,
@@ -24,11 +22,7 @@ import {createContentProviderUISourceCode, createFileSystemUISourceCode} from '.
 import * as AiAssistance from './ai_assistance.js';
 
 describeWithMockConnection('PatchWidget', () => {
-  let showFreDialogStub: sinon.SinonStub<Parameters<typeof PanelCommon.FreDialog.show>, Promise<boolean>>;
   beforeEach(() => {
-    Common.Settings.moduleSetting('ai-assistance-patching-fre-completed').set(true);
-    showFreDialogStub = sinon.stub(PanelCommon.FreDialog, 'show');
-
     initializePersistenceImplForTests();
   });
 
@@ -54,51 +48,8 @@ describeWithMockConnection('PatchWidget', () => {
     });
 
     describe('enterprise text cases', () => {
-      it('should FRE text include no logging case when the enterprise policy value is ALLOW_WITHOUT_LOGGING',
-         async () => {
-           Common.Settings.moduleSetting('ai-assistance-patching-fre-completed').set(false);
-           updateHostConfig({
-             devToolsFreestyler: {
-               enabled: true,
-               patching: true,
-             },
-             aidaAvailability: {enterprisePolicyValue: Root.Runtime.GenAiEnterprisePolicyValue.ALLOW_WITHOUT_LOGGING}
-           });
-           const {view, widget} = await createPatchWidget();
-           widget.changeSummary = 'body { background-color: red; }';
-
-           view.input.onApplyToPageTree();
-
-           assert.isTrue(showFreDialogStub.called, 'Expected FreDialog to be shown but it\'s not shown');
-           assert.exists(showFreDialogStub.lastCall.args[0].reminderItems.find(
-               reminderItem => reminderItem.content.toString().includes(
-                   'This data will not be used to improve Google’s AI models.')));
-         });
-
-      it('should FRE text not include no logging case when the enterprise policy value is ALLOW_WITHOUT_LOGGING',
-         async () => {
-           Common.Settings.moduleSetting('ai-assistance-patching-fre-completed').set(false);
-           updateHostConfig({
-             devToolsFreestyler: {
-               enabled: true,
-               patching: true,
-             },
-             aidaAvailability: {enterprisePolicyValue: Root.Runtime.GenAiEnterprisePolicyValue.ALLOW}
-           });
-           const {view, widget} = await createPatchWidget();
-           widget.changeSummary = 'body { background-color: red; }';
-
-           view.input.onApplyToPageTree();
-
-           assert.isTrue(showFreDialogStub.called, 'Expected FreDialog to be shown but it\'s not shown');
-           assert.notExists(showFreDialogStub.lastCall.args[0].reminderItems.find(
-               reminderItem => reminderItem.content.toString().includes(
-                   'This data will not be used to improve Google’s AI models.')));
-         });
-
       it('should tooltip text include no logging case when the enterprise policy value is ALLOW_WITHOUT_LOGGING',
          async () => {
-           Common.Settings.moduleSetting('ai-assistance-patching-fre-completed').set(false);
            updateHostConfig({
              devToolsFreestyler: {
                enabled: true,
@@ -113,7 +64,6 @@ describeWithMockConnection('PatchWidget', () => {
          });
 
       it('should tooltip text not include no logging case when the enterprise policy value is ALLOW', async () => {
-        Common.Settings.moduleSetting('ai-assistance-patching-fre-completed').set(false);
         updateHostConfig({
           devToolsFreestyler: {
             enabled: true,
@@ -128,26 +78,6 @@ describeWithMockConnection('PatchWidget', () => {
       });
     });
 
-    it('should show FRE dialog on applyToPageTree click if the setting is false', async () => {
-      Common.Settings.moduleSetting('ai-assistance-patching-fre-completed').set(false);
-      const {view, widget} = await createPatchWidget();
-      widget.changeSummary = 'body { background-color: red; }';
-
-      view.input.onApplyToPageTree();
-
-      assert.isTrue(showFreDialogStub.called, 'Expected FreDialog to be shown but it\'s not shown');
-    });
-
-    it('should not show FRE dialog on applyToPageTree click if the setting is true', async () => {
-      Common.Settings.moduleSetting('ai-assistance-patching-fre-completed').set(true);
-      const {view, widget} = await createPatchWidget();
-      widget.changeSummary = 'body { background-color: red; }';
-
-      view.input.onApplyToPageTree();
-
-      assert.isFalse(showFreDialogStub.called, 'Expected FreDialog to be not shown but it\'s shown');
-    });
-
     it('should show files uploaded', async () => {
       const {view, widget} = await createPatchWidget({
         aidaClient: mockAidaClient([
diff --git a/front_end/panels/ai_assistance/PatchWidget.ts b/front_end/panels/ai_assistance/PatchWidget.ts
@@ -7,7 +7,6 @@ import '../../ui/components/spinners/spinners.js';
 import '../../ui/components/tooltips/tooltips.js';
 import '../../ui/legacy/legacy.js';
 
-import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import type * as Platform from '../../core/platform/platform.js';
@@ -20,7 +19,6 @@ import * as UI from '../../ui/legacy/legacy.js';
 import {Directives, html, type LitTemplate, nothing, render} from '../../ui/lit/lit.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 import * as ChangesPanel from '../changes/changes.js';
-import * as PanelCommon from '../common/common.js';
 
 const {classMap} = Directives;
 
@@ -74,27 +72,6 @@ const UIStringsNotTranslate = {
    *@description Tooltip link for the navigating to "AI innovations" page in settings.
    */
   learnMore: 'Learn more',
-  /**
-   *@description Header text for the AI-powered code suggestions disclaimer dialog.
-   */
-  freDisclaimerHeader: 'Get AI-powered code suggestions for your workspace',
-  /**
-   *@description First disclaimer item text for the fre dialog.
-   */
-  freDisclaimerTextAiWontAlwaysGetItRight: 'This feature uses AI and won’t always get it right',
-  /**
-   *@description Second disclaimer item text for the fre dialog.
-   */
-  freDisclaimerTextPrivacy: 'Source code from the selected folder is sent to Google to generate code suggestions',
-  /**
-   *@description Second disclaimer item text for the fre dialog when enterprise logging is off.
-   */
-  freDisclaimerTextPrivacyNoLogging:
-      'Source code from the selected folder is sent to Google to generate code suggestions. This data will not be used to improve Google’s AI models.',
-  /**
-   *@description Third disclaimer item text for the fre dialog.
-   */
-  freDisclaimerTextUseWithCaution: 'Use generated code snippets with caution',
   /**
    * @description Title of the link opening data that was used to
    * produce a code suggestion.
@@ -112,8 +89,6 @@ const UIStringsNotTranslate = {
 
 const lockedString = i18n.i18n.lockedString;
 
-const CODE_SNIPPET_WARNING_URL = 'https://support.google.com/legal/answer/13505487';
-
 export enum PatchSuggestionState {
   /**
    * The user did not attempt patching yet
@@ -156,9 +131,6 @@ type View = (input: ViewInput, output: ViewOutput, target: HTMLElement) => void;
 export class PatchWidget extends UI.Widget.Widget {
   changeSummary = '';
   changeManager: AiAssistanceModel.ChangeManager|undefined;
-  // Whether the user completed first run experience dialog or not.
-  #aiPatchingFreCompletedSetting =
-      Common.Settings.Settings.instance().createSetting('ai-assistance-patching-fre-completed', false);
   #view: View;
   #viewOutput: ViewOutput = {};
   #aidaClient: Host.AidaClient.AidaClient;
@@ -397,64 +369,10 @@ export class PatchWidget extends UI.Widget.Widget {
     }
   }
 
-  async #showFreDisclaimerIfNeeded(): Promise<boolean> {
-    const isAiPatchingFreCompleted = this.#aiPatchingFreCompletedSetting.get();
-    if (isAiPatchingFreCompleted) {
-      return true;
-    }
-
-    const result = await PanelCommon.FreDialog.show({
-      header: {iconName: 'smart-assistant', text: lockedString(UIStringsNotTranslate.freDisclaimerHeader)},
-      reminderItems: [
-        {
-          iconName: 'psychiatry',
-          content: lockedString(UIStringsNotTranslate.freDisclaimerTextAiWontAlwaysGetItRight),
-        },
-        {
-          iconName: 'google',
-          content: this.#noLogging ? lockedString(UIStringsNotTranslate.freDisclaimerTextPrivacyNoLogging) :
-                                     lockedString(UIStringsNotTranslate.freDisclaimerTextPrivacy),
-        },
-        {
-          iconName: 'warning',
-          // clang-format off
-          content: html`<x-link
-            href=${CODE_SNIPPET_WARNING_URL}
-            class="link"
-            jslog=${VisualLogging.link('code-snippets-explainer.patch-widget').track({
-              click: true
-            })}
-          >${lockedString(UIStringsNotTranslate.freDisclaimerTextUseWithCaution)}</x-link>`,
-          // clang-format on
-        }
-      ],
-      onLearnMoreClick: () => {
-        void UI.ViewManager.ViewManager.instance().showView('chrome-ai');
-      }
-    });
-
-    if (result) {
-      this.#aiPatchingFreCompletedSetting.set(true);
-    }
-    return result;
-  }
-
   async #onApplyToPageTree(): Promise<void> {
     if (!isAiAssistancePatchingEnabled()) {
       return;
     }
-
-    // Show the FRE dialog if needed and only continue when
-    // the user accepted the disclaimer.
-    const freDisclaimerCompleted = await this.#showFreDisclaimerIfNeeded();
-    if (!freDisclaimerCompleted) {
-      return;
-    }
-
-    await this.#applyPatchAndUpdateUI();
-  }
-
-  async #applyPatchAndUpdateUI(): Promise<void> {
     const changeSummary = this.changeSummary;
     if (!changeSummary) {
       throw new Error('Change summary does not exist');
diff --git a/front_end/testing/EnvironmentHelpers.ts b/front_end/testing/EnvironmentHelpers.ts
@@ -293,9 +293,6 @@ export async function initializeGlobalVars({reset = true} = {}) {
         Common.Settings.SettingCategory.AI, 'ai-annotations-enabled', false, Common.Settings.SettingType.BOOLEAN),
     createSettingValue(
         Common.Settings.SettingCategory.AI, 'ai-assistance-history-entries', [], Common.Settings.SettingType.ARRAY),
-    createSettingValue(
-        Common.Settings.SettingCategory.AI, 'ai-assistance-patching-fre-completed', false,
-        Common.Settings.SettingType.BOOLEAN),
     createSettingValue(
         Common.Settings.SettingCategory.MOBILE, 'emulation.show-device-outline', false,
         Common.Settings.SettingType.BOOLEAN),
diff --git a/front_end/ui/visual_logging/KnownContextValues.ts b/front_end/ui/visual_logging/KnownContextValues.ts
@@ -334,7 +334,6 @@ export const knownContextValues = new Set([
   'ai-assistance-enabled',
   'ai-assistance-history-entries',
   'ai-assistance-history-images',
-  'ai-assistance-patching-fre-completed',
   'ai-assistance-patching-selected-project-id',
   'ai_assistance',
   'align-content',
