[RPP] Linkify using source maps for enhanced traces

The linkifying done for bottom-up/call-tree tables only tried to use
source maps if the trace is fresh, as otherwise script ids are not
accurate. However, they are accurate for enhanced traces, so I added
support for that too.

Unrelated to this change, I also added an error event listener to
Worker.ts to log when a worker fails to load. This would have saved me
a couple hours of debugging.

Fixed: 432044399
Change-Id: I23ff59fe9209b6ac3a3f50c1ea009ba2df802e65
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7046248
Commit-Queue: Paul Irish <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
Auto-Submit: Connor Clark <[email protected]>

Author: Connor Clark

front_end/core/common/Worker.ts

@@ -11,6 +11,9 @@ export class WorkerWrapper {
     this.#workerPromise = new Promise((fulfill, reject) => {
       this.#rejectWorkerPromise = reject;
       const worker = new Worker(workerLocation, {type: 'module'});
+      worker.onerror = event => {
+        console.error(`Failed to load worker for ${workerLocation.href}:`, event);
+      };
       worker.onmessage = (event: MessageEvent<unknown>) => {
         console.assert(event.data === 'workerReady');
         worker.onmessage = null;

front_end/panels/timeline/TimelineTreeView.ts

@@ -799,9 +799,9 @@ export class GridNode extends DataGrid.SortableDataGrid.SortableDataGridNode<Gri
       const parsedTrace = this.treeView.parsedTrace();
       const target = parsedTrace ? targetForEvent(parsedTrace, event) : null;
       const linkifier = this.treeView.linkifier;
-      const isFreshRecording =
-          Boolean(parsedTrace && Tracing.FreshRecording.Tracker.instance().recordingIsFresh(parsedTrace));
-      this.linkElement = TimelineUIUtils.linkifyTopCallFrame(event, target, linkifier, isFreshRecording);
+      const isFreshOrEnhanced =
+          Boolean(parsedTrace && Tracing.FreshRecording.Tracker.instance().recordingIsFreshOrEnhanced(parsedTrace));
+      this.linkElement = TimelineUIUtils.linkifyTopCallFrame(event, target, linkifier, isFreshOrEnhanced);
       if (this.linkElement) {
         container.createChild('div', 'activity-link').appendChild(this.linkElement);
       }

front_end/panels/timeline/TimelineUIUtils.test.ts

@@ -189,7 +189,7 @@ describeWithMockConnection('TimelineUIUtils', function() {
         url: 'https://google.com/test.js',
         lineNumber: 0,
         columnNumber: 0,
-        isFreshRecording: true,
+        isFreshOrEnhanced: true,
         target,
         linkifier,
       });

front_end/panels/timeline/TimelineUIUtils.ts

@@ -493,7 +493,7 @@ interface LinkifyLocationOptions {
   lineNumber: number;
   target: SDK.Target.Target|null;
   linkifier: LegacyComponents.Linkifier.Linkifier;
-  isFreshRecording?: boolean;
+  isFreshOrEnhanced?: boolean;
   columnNumber?: number;
   omitOrigin?: boolean;
 }
@@ -656,7 +656,7 @@ export class TimelineUIUtils {
 
   static async buildDetailsNodeForTraceEvent(
       event: Trace.Types.Events.Event, target: SDK.Target.Target|null, linkifier: LegacyComponents.Linkifier.Linkifier,
-      isFreshRecording = false, parsedTrace: Trace.TraceModel.ParsedTrace): Promise<Node|null> {
+      isFreshOrEnhanced = false, parsedTrace: Trace.TraceModel.ParsedTrace): Promise<Node|null> {
     let details: HTMLElement|HTMLSpanElement|(Element | null)|Text|null = null;
     let detailsText;
     // TODO(40287735): update this code with type-safe data checks.
@@ -706,7 +706,7 @@ export class TimelineUIUtils {
           lineNumber: callFrame?.lineNumber || 0,
           columnNumber: callFrame?.columnNumber,
           target,
-          isFreshRecording,
+          isFreshOrEnhanced,
           linkifier,
           omitOrigin: true,
         });
@@ -725,7 +725,7 @@ export class TimelineUIUtils {
           lineNumber: 0,
           columnNumber: 0,
           target,
-          isFreshRecording,
+          isFreshOrEnhanced,
           linkifier,
         });
         break;
@@ -743,7 +743,7 @@ export class TimelineUIUtils {
             lineNumber: lineNumber || 0,
             columnNumber: 0,
             target,
-            isFreshRecording,
+            isFreshOrEnhanced,
             linkifier,
             omitOrigin: true,
           });
@@ -761,7 +761,7 @@ export class TimelineUIUtils {
             lineNumber: 0,
             columnNumber: 0,
             target,
-            isFreshRecording,
+            isFreshOrEnhanced,
             linkifier,
             omitOrigin: true,
           });
@@ -779,7 +779,7 @@ export class TimelineUIUtils {
             Trace.Types.Events.isProfileCall(event)) {
           detailsText = null;
         } else {
-          details = this.linkifyTopCallFrame(event, target, linkifier, isFreshRecording) ?? null;
+          details = this.linkifyTopCallFrame(event, target, linkifier, isFreshOrEnhanced) ?? null;
         }
         break;
       }
@@ -792,7 +792,7 @@ export class TimelineUIUtils {
   }
 
   static linkifyLocation(linkifyOptions: LinkifyLocationOptions): Element|null {
-    const {scriptId, url, lineNumber, columnNumber, isFreshRecording, linkifier, target, omitOrigin} = linkifyOptions;
+    const {scriptId, url, lineNumber, columnNumber, isFreshOrEnhanced, linkifier, target, omitOrigin} = linkifyOptions;
     const options = {
       lineNumber,
       columnNumber,
@@ -802,7 +802,7 @@ export class TimelineUIUtils {
       tabStop: true,
       omitOrigin,
     };
-    if (isFreshRecording) {
+    if (isFreshOrEnhanced) {
       return linkifier.linkifyScriptLocation(
           target, scriptId, url as Platform.DevToolsPath.UrlString, lineNumber, options);
     }
@@ -811,7 +811,7 @@ export class TimelineUIUtils {
 
   static linkifyTopCallFrame(
       event: Trace.Types.Events.Event, target: SDK.Target.Target|null, linkifier: LegacyComponents.Linkifier.Linkifier,
-      isFreshRecording = false): Element|null {
+      isFreshOrEnhanced = false): Element|null {
     let frame = Trace.Helpers.Trace.getZeroIndexedStackTraceInEventPayload(event)?.[0];
     if (Trace.Types.Events.isProfileCall(event)) {
       frame = event.callFrame;
@@ -827,7 +827,7 @@ export class TimelineUIUtils {
       columnNumber: frame.columnNumber,
       lineNumber: frame.lineNumber,
     };
-    if (isFreshRecording) {
+    if (isFreshOrEnhanced) {
       return linkifier.maybeLinkifyConsoleCallFrame(target, frame, {showColumnNumber: true, inlineFrameIndex: 0});
     }
     return LegacyComponents.Linkifier.Linkifier.linkifyURL(frame.url as Platform.DevToolsPath.UrlString, options);
@@ -1078,8 +1078,8 @@ export class TimelineUIUtils {
       }
     }
 
-    const isFreshRecording =
-        Boolean(parsedTrace && Tracing.FreshRecording.Tracker.instance().recordingIsFresh(parsedTrace));
+    const isFreshOrEnhanced =
+        Boolean(parsedTrace && Tracing.FreshRecording.Tracker.instance().recordingIsFreshOrEnhanced(parsedTrace));
 
     switch (event.name) {
       case Trace.Types.Events.Name.GC:
@@ -1110,7 +1110,7 @@ export class TimelineUIUtils {
       }
       case Trace.Types.Events.Name.FUNCTION_CALL: {
         const detailsNode = await TimelineUIUtils.buildDetailsNodeForTraceEvent(
-            event, targetForEvent(parsedTrace, event), linkifier, isFreshRecording, parsedTrace);
+            event, targetForEvent(parsedTrace, event), linkifier, isFreshOrEnhanced, parsedTrace);
         if (detailsNode) {
           contentHelper.appendElementRow(i18nString(UIStrings.function), detailsNode);
           const originWithEntity = this.getOriginWithEntity(entityMapper, parsedTrace, event);
@@ -1473,7 +1473,7 @@ export class TimelineUIUtils {
 
       case Trace.Types.Events.Name.EVENT_TIMING: {
         const detailsNode = await TimelineUIUtils.buildDetailsNodeForTraceEvent(
-            event, targetForEvent(parsedTrace, event), linkifier, isFreshRecording, parsedTrace);
+            event, targetForEvent(parsedTrace, event), linkifier, isFreshOrEnhanced, parsedTrace);
         if (detailsNode) {
           contentHelper.appendElementRow(i18nString(UIStrings.details), detailsNode);
         }
@@ -1491,7 +1491,7 @@ export class TimelineUIUtils {
 
       default: {
         const detailsNode = await TimelineUIUtils.buildDetailsNodeForTraceEvent(
-            event, targetForEvent(parsedTrace, event), linkifier, isFreshRecording, parsedTrace);
+            event, targetForEvent(parsedTrace, event), linkifier, isFreshOrEnhanced, parsedTrace);
         if (detailsNode) {
           contentHelper.appendElementRow(i18nString(UIStrings.details), detailsNode);
         }

front_end/services/tracing/FreshRecording.ts

@@ -28,4 +28,8 @@ export class Tracker {
   recordingIsFresh(data: Trace.TraceModel.ParsedTrace): boolean {
     return this.#freshRecordings.has(data);
   }
+
+  recordingIsFreshOrEnhanced(data: Trace.TraceModel.ParsedTrace): boolean {
+    return this.#freshRecordings.has(data) || data.metadata.enhancedTraceVersion !== undefined;
+  }
 }