Skip to content

Commit 6400380

Browse files
bmeurerDevtools-frontend LUCI CQ
authored andcommitted
[cleanup] Remove the RenderCoordinator singleton.
This is the second step in making the `RenderCoordinator` more ergonomic to use in our codebase. It also removes the unnecessary singleton and just uses module-level state and simple functions for interacting with the `RenderCoordinator`. Drive-by-fix: Also change the test-only properties to a proper function `setLoggingEnabled()`, similar to what we have for VE logging debugging. Fixed: 387186170 Change-Id: Ib33a86060c1378e24adc95cb99ffa106a5b0c499 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6133022 Auto-Submit: Benedikt Meurer <[email protected]> Reviewed-by: Nikolay Vitkov <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]>
1 parent c52c058 commit 6400380

File tree

5 files changed

+355
-397
lines changed

5 files changed

+355
-397
lines changed

config/gni/devtools_grd_files.gni

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2261,7 +2261,6 @@ grd_files_debug_sources = [
22612261
"front_end/ui/components/panel_feedback/previewToggle.css.js",
22622262
"front_end/ui/components/panel_introduction_steps/PanelIntroductionSteps.js",
22632263
"front_end/ui/components/panel_introduction_steps/panelIntroductionSteps.css.js",
2264-
"front_end/ui/components/render_coordinator/RenderCoordinator.js",
22652264
"front_end/ui/components/report_view/ReportView.js",
22662265
"front_end/ui/components/report_view/report.css.js",
22672266
"front_end/ui/components/report_view/reportKey.css.js",

front_end/ui/components/render_coordinator/BUILD.gn

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,10 @@ import("../../../../scripts/build/ninja/devtools_module.gni")
77
import("../../../../scripts/build/typescript/typescript.gni")
88
import("../visibility.gni")
99

10-
devtools_module("render_coordinator") {
11-
sources = [ "RenderCoordinator.ts" ]
12-
deps = [ "../../../core/platform:bundle" ]
13-
}
14-
1510
devtools_entrypoint("bundle") {
1611
entrypoint = "render_coordinator.ts"
1712

18-
deps = [ ":render_coordinator" ]
13+
deps = [ "../../../core/platform:bundle" ]
1914

2015
visibility = default_components_visibility
2116
}

front_end/ui/components/render_coordinator/RenderCoordinator.ts

Lines changed: 0 additions & 335 deletions
This file was deleted.

0 commit comments

Comments
 (0)