Skip to content

Commit 642aa1e

Browse files
Andrew PaseltinerDevtools-frontend LUCI CQ
Andrew Paseltiner
authored and
Devtools-frontend LUCI CQ
committed
Add missing Attribution Reporting issue descriptions
Bug: 375209496 Change-Id: Ibb3faea6fb2e756d21df19e5136d09490461f7b5 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5956822 Reviewed-by: Simon Zünd <[email protected]> Commit-Queue: Andrew Paseltiner <[email protected]>
1 parent 160df0e commit 642aa1e

11 files changed

+120
-18
lines changed

‎config/gni/devtools_grd_files.gni‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -384,11 +384,18 @@ grd_files_release_sources = [
384384
"front_end/models/issues_manager/descriptions/SameSiteWarnCrossDowngradeSet.md",
385385
"front_end/models/issues_manager/descriptions/SameSiteWarnStrictLaxDowngradeStrict.md",
386386
"front_end/models/issues_manager/descriptions/arInsecureContext.md",
387+
"front_end/models/issues_manager/descriptions/arInvalidInfoHeader.md",
387388
"front_end/models/issues_manager/descriptions/arInvalidRegisterOsSourceHeader.md",
388389
"front_end/models/issues_manager/descriptions/arInvalidRegisterOsTriggerHeader.md",
389390
"front_end/models/issues_manager/descriptions/arInvalidRegisterSourceHeader.md",
390391
"front_end/models/issues_manager/descriptions/arInvalidRegisterTriggerHeader.md",
392+
"front_end/models/issues_manager/descriptions/arNavigationRegistrationUniqueScopeAlreadySet.md",
391393
"front_end/models/issues_manager/descriptions/arNavigationRegistrationWithoutTransientUserActivation.md",
394+
"front_end/models/issues_manager/descriptions/arNoRegisterOsSourceHeader.md",
395+
"front_end/models/issues_manager/descriptions/arNoRegisterOsTriggerHeader.md",
396+
"front_end/models/issues_manager/descriptions/arNoRegisterSourceHeader.md",
397+
"front_end/models/issues_manager/descriptions/arNoRegisterTriggerHeader.md",
398+
"front_end/models/issues_manager/descriptions/arNoWebOrOsSupport.md",
392399
"front_end/models/issues_manager/descriptions/arOsSourceIgnored.md",
393400
"front_end/models/issues_manager/descriptions/arOsTriggerIgnored.md",
394401
"front_end/models/issues_manager/descriptions/arPermissionPolicyDisabled.md",

‎front_end/models/issues_manager/AttributionReportingIssue.ts‎

Lines changed: 58 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,16 @@ export const enum IssueCode {
2222
INVALID_REGISTER_OS_SOURCE_HEADER = 'AttributionReportingIssue::InvalidRegisterOsSourceHeader',
2323
INVALID_REGISTER_OS_TRIGGER_HEADER = 'AttributionReportingIssue::InvalidRegisterOsTriggerHeader',
2424
WEB_AND_OS_HEADERS = 'AttributionReportingIssue::WebAndOsHeaders',
25+
NO_WEB_OR_OS_SUPPORT = 'AttributionReportingIssue::NoWebOrOsSupport',
2526
NAVIGATION_REGISTRATION_WITHOUT_TRANSIENT_USER_ACTIVATION =
2627
'AttributionReportingIssue::NavigationRegistrationWithoutTransientUserActivation',
28+
INVALID_INFO_HEADER = 'AttributionReportingIssue::InvalidInfoHeader',
29+
NO_REGISTER_SOURCE_HEADER = 'AttributionReportingIssue::NoRegisterSourceHeader',
30+
NO_REGISTER_TRIGGER_HEADER = 'AttributionReportingIssue::NoRegisterTriggerHeader',
31+
NO_REGISTER_OS_SOURCE_HEADER = 'AttributionReportingIssue::NoRegisterOsSourceHeader',
32+
NO_REGISTER_OS_TRIGGER_HEADER = 'AttributionReportingIssue::NoRegisterOsTriggerHeader',
33+
NAVIGATION_REGISTRATION_UNIQUE_SCOPE_ALREADY_SET =
34+
'AttributionReportingIssue::NavigationRegistrationUniqueScopeAlreadySet',
2735
UNKNOWN = 'AttributionReportingIssue::Unknown',
2836
}
2937

@@ -55,8 +63,22 @@ function getIssueCode(details: Protocol.Audits.AttributionReportingIssueDetails)
5563
return IssueCode.INVALID_REGISTER_OS_TRIGGER_HEADER;
5664
case Protocol.Audits.AttributionReportingIssueType.WebAndOsHeaders:
5765
return IssueCode.WEB_AND_OS_HEADERS;
66+
case Protocol.Audits.AttributionReportingIssueType.NoWebOrOsSupport:
67+
return IssueCode.NO_WEB_OR_OS_SUPPORT;
5868
case Protocol.Audits.AttributionReportingIssueType.NavigationRegistrationWithoutTransientUserActivation:
5969
return IssueCode.NAVIGATION_REGISTRATION_WITHOUT_TRANSIENT_USER_ACTIVATION;
70+
case Protocol.Audits.AttributionReportingIssueType.InvalidInfoHeader:
71+
return IssueCode.INVALID_INFO_HEADER;
72+
case Protocol.Audits.AttributionReportingIssueType.NoRegisterSourceHeader:
73+
return IssueCode.NO_REGISTER_SOURCE_HEADER;
74+
case Protocol.Audits.AttributionReportingIssueType.NoRegisterTriggerHeader:
75+
return IssueCode.NO_REGISTER_TRIGGER_HEADER;
76+
case Protocol.Audits.AttributionReportingIssueType.NoRegisterOsSourceHeader:
77+
return IssueCode.NO_REGISTER_OS_SOURCE_HEADER;
78+
case Protocol.Audits.AttributionReportingIssueType.NoRegisterOsTriggerHeader:
79+
return IssueCode.NO_REGISTER_OS_TRIGGER_HEADER;
80+
case Protocol.Audits.AttributionReportingIssueType.NavigationRegistrationUniqueScopeAlreadySet:
81+
return IssueCode.NAVIGATION_REGISTRATION_UNIQUE_SCOPE_ALREADY_SET;
6082
default:
6183
return IssueCode.UNKNOWN;
6284
}
@@ -166,6 +188,41 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
166188
file: 'arNavigationRegistrationWithoutTransientUserActivation.md',
167189
links: [],
168190
};
191+
case IssueCode.NO_WEB_OR_OS_SUPPORT:
192+
return {
193+
file: 'arNoWebOrOsSupport.md',
194+
links: [],
195+
};
196+
case IssueCode.INVALID_INFO_HEADER:
197+
return {
198+
file: 'arInvalidInfoHeader.md',
199+
links: [],
200+
};
201+
case IssueCode.NO_REGISTER_SOURCE_HEADER:
202+
return {
203+
file: 'arNoRegisterSourceHeader.md',
204+
links: [],
205+
};
206+
case IssueCode.NO_REGISTER_TRIGGER_HEADER:
207+
return {
208+
file: 'arNoRegisterTriggerHeader.md',
209+
links: [],
210+
};
211+
case IssueCode.NO_REGISTER_OS_SOURCE_HEADER:
212+
return {
213+
file: 'arNoRegisterOsSourceHeader.md',
214+
links: [],
215+
};
216+
case IssueCode.NO_REGISTER_OS_TRIGGER_HEADER:
217+
return {
218+
file: 'arNoRegisterOsTriggerHeader.md',
219+
links: [],
220+
};
221+
case IssueCode.NAVIGATION_REGISTRATION_UNIQUE_SCOPE_ALREADY_SET:
222+
return {
223+
file: 'arNavigationRegistrationUniqueScopeAlreadySet.md',
224+
links: [],
225+
};
169226
case IssueCode.UNKNOWN:
170227
return null;
171228
}
@@ -176,24 +233,7 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
176233
}
177234

178235
getKind(): IssueKind {
179-
switch (this.code()) {
180-
case IssueCode.PERMISSION_POLICY_DISABLED:
181-
case IssueCode.UNTRUSTWORTHY_REPORTING_ORIGIN:
182-
case IssueCode.INSECURE_CONTEXT:
183-
case IssueCode.INVALID_REGISTER_SOURCE_HEADER:
184-
case IssueCode.INVALID_REGISTER_TRIGGER_HEADER:
185-
case IssueCode.INVALID_REGISTER_OS_SOURCE_HEADER:
186-
case IssueCode.INVALID_REGISTER_OS_TRIGGER_HEADER:
187-
case IssueCode.SOURCE_AND_TRIGGER_HEADERS:
188-
case IssueCode.WEB_AND_OS_HEADERS:
189-
case IssueCode.SOURCE_IGNORED:
190-
case IssueCode.TRIGGER_IGNORED:
191-
case IssueCode.OS_SOURCE_IGNORED:
192-
case IssueCode.OS_TRIGGER_IGNORED:
193-
case IssueCode.NAVIGATION_REGISTRATION_WITHOUT_TRANSIENT_USER_ACTIVATION:
194-
case IssueCode.UNKNOWN:
195-
return IssueKind.PAGE_ERROR;
196-
}
236+
return IssueKind.PAGE_ERROR;
197237
}
198238

199239
static fromInspectorIssue(issuesModel: SDK.IssuesModel.IssuesModel, inspectorIssue: Protocol.Audits.InspectorIssue):

‎front_end/models/issues_manager/BUILD.gn‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,18 @@ devtools_module("issues_manager") {
6060

6161
devtools_issue_description_files = [
6262
"arInsecureContext.md",
63+
"arInvalidInfoHeader.md",
6364
"arInvalidRegisterOsSourceHeader.md",
6465
"arInvalidRegisterOsTriggerHeader.md",
6566
"arInvalidRegisterSourceHeader.md",
6667
"arInvalidRegisterTriggerHeader.md",
6768
"arNavigationRegistrationWithoutTransientUserActivation.md",
69+
"arNavigationRegistrationUniqueScopeAlreadySet.md",
70+
"arNoRegisterOsSourceHeader.md",
71+
"arNoRegisterOsTriggerHeader.md",
72+
"arNoRegisterSourceHeader.md",
73+
"arNoRegisterTriggerHeader.md",
74+
"arNoWebOrOsSupport.md",
6875
"arOsSourceIgnored.md",
6976
"arOsTriggerIgnored.md",
7077
"arPermissionPolicyDisabled.md",

‎front_end/models/issues_manager/descriptions/arInvalidInfoHeader.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# Ensure that the `Attribution-Reporting-Info` header is valid
2+
3+
This page tried to register a source or trigger using the Attribution Reporting
4+
API but failed because an `Attribution-Reporting-Info` response header was
5+
invalid.

‎front_end/models/issues_manager/descriptions/arNavigationRegistrationUniqueScopeAlreadySet.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# Ensure that multiple sources associated with the same navigation have the same attribution scopes
2+
3+
The page tried to register a source using Attribution Reporting API, but the
4+
source was rejected because a previous source associated with the same
5+
navigation and reporting origin used a different set of attribution scopes.

‎front_end/models/issues_manager/descriptions/arNoRegisterOsSourceHeader.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# OS attribution source expected but corresponding header not found
2+
3+
The page indicated, via the `Attribution-Reporting-Info` header, that it
4+
intended to register an OS source using the Attribution Reporting API, but the
5+
corresponding `Attribution-Reporting-Register-OS-Source` header was missing.

‎front_end/models/issues_manager/descriptions/arNoRegisterOsTriggerHeader.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# OS attribution trigger expected but corresponding header not found
2+
3+
The page indicated, via the `Attribution-Reporting-Info` header, that it
4+
intended to register an OS trigger using the Attribution Reporting API, but the
5+
corresponding `Attribution-Reporting-Register-OS-Trigger` header was missing.

‎front_end/models/issues_manager/descriptions/arNoRegisterSourceHeader.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# Web attribution source expected but corresponding header not found
2+
3+
The page indicated, via the `Attribution-Reporting-Info` header, that it
4+
intended to register a web source using the Attribution Reporting API, but the
5+
corresponding `Attribution-Reporting-Register-Source` header was missing.

‎front_end/models/issues_manager/descriptions/arNoRegisterTriggerHeader.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# Web attribution trigger expected but corresponding header not found
2+
3+
The page indicated, via the `Attribution-Reporting-Info` header, that it
4+
intended to register a web trigger using the Attribution Reporting API, but the
5+
corresponding `Attribution-Reporting-Register-Trigger` header was missing.

‎front_end/models/issues_manager/descriptions/arNoWebOrOsSupport.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# No web or OS support for Attribution Reporting
2+
3+
The page tried to send an attributionsrc request, but there was neither web nor
4+
OS support for the Attribution Reporting API, so the request was skipped.

0 commit comments

Comments
 (0)