Skip to content

Commit 648ad84

Browse files
ergunshDevtools-frontend LUCI CQ
authored andcommitted
[AiAutocompletion] Do not enable the feature when AIDA is not available
Fixed: 444403502 Change-Id: Iafe0d94a8fc5037d63ab28489a5999d2462f7749 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6940194 Auto-Submit: Ergün Erdoğmuş <[email protected]> Commit-Queue: Alex Rudenko <[email protected]> Commit-Queue: Ergün Erdoğmuş <[email protected]> Reviewed-by: Alex Rudenko <[email protected]>
1 parent e5cca6c commit 648ad84

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

front_end/panels/console/ConsolePrompt.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ describeWithMockConnection('ConsoleContextSelector', () => {
3838
devToolsAiCodeCompletion: {
3939
enabled: true,
4040
},
41+
aidaAvailability: {enabled: true},
4142
});
4243
registerNoopActions(['console.clear', 'console.clear.history', 'console.create-pin']);
4344

front_end/panels/console/ConsolePrompt.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,8 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
582582
}
583583

584584
private isAiCodeCompletionEnabled(): boolean {
585-
return Boolean(Root.Runtime.hostConfig.devToolsAiCodeCompletion?.enabled);
585+
return Boolean(
586+
Root.Runtime.hostConfig.aidaAvailability?.enabled && Root.Runtime.hostConfig.devToolsAiCodeCompletion?.enabled);
586587
}
587588

588589
private editorSetForTest(): void {

front_end/panels/sources/UISourceCodeFrame.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,8 @@ export class UISourceCodeFrame extends Common.ObjectWrapper
346346
AiWarningInfobarPlugin,
347347
];
348348

349-
if (Boolean(Root.Runtime.hostConfig.devToolsAiCodeCompletion?.enabled)) {
349+
if (Root.Runtime.hostConfig.aidaAvailability?.enabled &&
350+
Root.Runtime.hostConfig.devToolsAiCodeCompletion?.enabled) {
350351
sourceFramePluginsList.push(AiCodeCompletionPlugin);
351352
}
352353
return sourceFramePluginsList;

0 commit comments

Comments
 (0)