[eslint] Run no-unnecessary-type-assertion

This type duplication can happen because of two reasons. 1) TypeScript
was not smart enough to deduce the type correctly 2) During our
TypeScript migration not very was typed, so we need to type cast in a
lot of places.

The rule is disabled as its too aggressive in some places, will file
issues upstream.

Bug: 397260638
Change-Id: Ic1100fee1e5a1d160d366f65d969442909f16eaf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276556
Auto-Submit: Nikolay Vitkov <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

eslint.config.mjs

@@ -498,6 +498,10 @@ export default [
       'no-throw-literal': 'off',
       '@typescript-eslint/only-throw-error': 'error',
 
+      // Disabled this rule while investigating why it creates
+      // certain TypeScript compilation errors after fixes
+      '@typescript-eslint/no-unnecessary-type-assertion': 'off',
+
       'rulesdir/no-underscored-properties': 'error',
       'rulesdir/inline-type-imports': 'error',
 

extensions/cxx_debugging/src/DWARFSymbols.ts

@@ -99,7 +99,7 @@ export function createEmbindPool(): {
 
     manage<T extends SymbolsBackend.EmbindObject|undefined>(object: T): T {
       if (typeof object !== 'undefined') {
-        this.objectPool.push(object as SymbolsBackend.EmbindObject);
+        this.objectPool.push(object);
       }
       return object;
     }

extensions/cxx_debugging/src/WasmTypes.ts

@@ -33,23 +33,23 @@ export function serializeWasmValue(value: WasmValue|ArrayBuffer, buffer: ArrayBu
   const view = new DataView(buffer);
   switch (value.type) {
     case 'i32': {
-      view.setInt32(0, value.value as number, true);
+      view.setInt32(0, value.value, true);
       return SerializedWasmType.i32;
     }
     case 'i64': {
-      view.setBigInt64(0, value.value as bigint, true);
+      view.setBigInt64(0, value.value, true);
       return SerializedWasmType.i64;
     }
     case 'f32': {
-      view.setFloat32(0, value.value as number, true);
+      view.setFloat32(0, value.value, true);
       return SerializedWasmType.f32;
     }
     case 'f64': {
-      view.setFloat64(0, value.value as number, true);
+      view.setFloat64(0, value.value, true);
       return SerializedWasmType.f64;
     }
     case 'v128': {
-      const [, a, b, c, d] = (value.value as string).split(' ');
+      const [, a, b, c, d] = (value.value).split(' ');
       view.setInt32(0, Number(a), true);
       view.setInt32(4, Number(b), true);
       view.setInt32(8, Number(c), true);

front_end/core/common/ParsedURL.ts

@@ -168,7 +168,7 @@ export class ParsedURL {
     // Based on net::FilePathToFileURL. Ideally we would handle
     // '\\' as well on non-Windows file systems.
     for (const specialChar of ['%', ';', '#', '?', ' ']) {
-      (path as string) = path.replaceAll(specialChar, encodeURIComponent(specialChar));
+      (path) = path.replaceAll(specialChar, encodeURIComponent(specialChar));
     }
     return path;
   }

front_end/core/common/ResourceType.test.ts

@@ -121,21 +121,21 @@ describeWithEnvironment('ResourceType class', () => {
   it('is able to return an wasm resource from the string "application/wasm"', () => {
     const result = ResourceType.fromMimeTypeOverride('application/wasm');
     assert.instanceOf(result, ResourceType, 'result type is incorrect');
-    assert.strictEqual(result!.name(), 'wasm', 'name was not set correctly');
-    assert.strictEqual(result!.title(), 'Wasm', 'title was not set correctly');
-    assert.strictEqual(result!.category().title(), 'WebAssembly', 'category title was not set correctly');
-    assert.strictEqual(result!.category().shortTitle(), 'Wasm', 'category short title was not set correctly');
-    assert.isFalse(result!.isTextType(), 'resource type was not set correctly');
+    assert.strictEqual(result.name(), 'wasm', 'name was not set correctly');
+    assert.strictEqual(result.title(), 'Wasm', 'title was not set correctly');
+    assert.strictEqual(result.category().title(), 'WebAssembly', 'category title was not set correctly');
+    assert.strictEqual(result.category().shortTitle(), 'Wasm', 'category short title was not set correctly');
+    assert.isFalse(result.isTextType(), 'resource type was not set correctly');
   });
 
   it('is able to return an web bundle resource from the string "application/webbundle"', () => {
     const result = ResourceType.fromMimeTypeOverride('application/webbundle');
     assert.instanceOf(result, ResourceType, 'result type is incorrect');
-    assert.strictEqual(result!.name(), 'webbundle', 'name was not set correctly');
-    assert.strictEqual(result!.title(), 'WebBundle', 'title was not set correctly');
-    assert.strictEqual(result!.category().title(), 'Other', 'category title was not set correctly');
-    assert.strictEqual(result!.category().shortTitle(), 'Other', 'category short title was not set correctly');
-    assert.isFalse(result!.isTextType(), 'resource type was not set correctly');
+    assert.strictEqual(result.name(), 'webbundle', 'name was not set correctly');
+    assert.strictEqual(result.title(), 'WebBundle', 'title was not set correctly');
+    assert.strictEqual(result.category().title(), 'Other', 'category title was not set correctly');
+    assert.strictEqual(result.category().shortTitle(), 'Other', 'category short title was not set correctly');
+    assert.isFalse(result.isTextType(), 'resource type was not set correctly');
   });
 
   it('is able to return a resource of type other from the string "test/resource"', () => {
@@ -151,41 +151,41 @@ describeWithEnvironment('ResourceType class', () => {
   it('is able to return a resource type from a URL that contains a mapped extension', () => {
     const result = ResourceType.fromURL('http://www.example.com/test/testFile.js');
     assert.instanceOf(result, ResourceType, 'result type is incorrect');
-    assert.strictEqual(result!.name(), 'script', 'name was not set correctly');
-    assert.strictEqual(result!.title(), 'Script', 'title was not set correctly');
-    assert.strictEqual(result!.category().title(), 'JavaScript', 'category title was not set correctly');
-    assert.strictEqual(result!.category().shortTitle(), 'JS', 'category short title was not set correctly');
-    assert.isTrue(result!.isTextType(), 'resource type was not set correctly');
+    assert.strictEqual(result.name(), 'script', 'name was not set correctly');
+    assert.strictEqual(result.title(), 'Script', 'title was not set correctly');
+    assert.strictEqual(result.category().title(), 'JavaScript', 'category title was not set correctly');
+    assert.strictEqual(result.category().shortTitle(), 'JS', 'category short title was not set correctly');
+    assert.isTrue(result.isTextType(), 'resource type was not set correctly');
   });
 
   it('is able to return a resource type from a URL that ends in .avif', () => {
     const result = ResourceType.fromURL('https://host.example/image.avif');
     assert.instanceOf(result, ResourceType, 'result type is incorrect');
-    assert.strictEqual(result!.name(), 'image', 'name was not set correctly');
-    assert.strictEqual(result!.title(), 'Image', 'title was not set correctly');
-    assert.strictEqual(result!.category().title(), 'Image', 'category title was not set correctly');
-    assert.strictEqual(result!.category().shortTitle(), 'Img', 'category short title was not set correctly');
-    assert.isTrue(result!.isImage(), 'resource type was not set correctly');
+    assert.strictEqual(result.name(), 'image', 'name was not set correctly');
+    assert.strictEqual(result.title(), 'Image', 'title was not set correctly');
+    assert.strictEqual(result.category().title(), 'Image', 'category title was not set correctly');
+    assert.strictEqual(result.category().shortTitle(), 'Img', 'category short title was not set correctly');
+    assert.isTrue(result.isImage(), 'resource type was not set correctly');
   });
 
   it('is able to return a resource type from a URL that ends in .jxl', () => {
     const result = ResourceType.fromURL('https://host.example/image.jxl');
     assert.instanceOf(result, ResourceType, 'result type is incorrect');
-    assert.strictEqual(result!.name(), 'image', 'name was not set correctly');
-    assert.strictEqual(result!.title(), 'Image', 'title was not set correctly');
-    assert.strictEqual(result!.category().title(), 'Image', 'category title was not set correctly');
-    assert.strictEqual(result!.category().shortTitle(), 'Img', 'category short title was not set correctly');
-    assert.isTrue(result!.isImage(), 'resource type was not set correctly');
+    assert.strictEqual(result.name(), 'image', 'name was not set correctly');
+    assert.strictEqual(result.title(), 'Image', 'title was not set correctly');
+    assert.strictEqual(result.category().title(), 'Image', 'category title was not set correctly');
+    assert.strictEqual(result.category().shortTitle(), 'Img', 'category short title was not set correctly');
+    assert.isTrue(result.isImage(), 'resource type was not set correctly');
   });
 
   it('is able to return a resource type from a URL that ends in .woff2', () => {
     const result = ResourceType.fromURL('https://host.example/image.woff2');
     assert.instanceOf(result, ResourceType, 'result type is incorrect');
-    assert.strictEqual(result!.name(), 'font', 'name was not set correctly');
-    assert.strictEqual(result!.title(), 'Font', 'title was not set correctly');
-    assert.strictEqual(result!.category().title(), 'Font', 'category title was not set correctly');
-    assert.strictEqual(result!.category().shortTitle(), 'Font', 'category short title was not set correctly');
-    assert.isFalse(result!.isTextType(), 'resource type was not set correctly');
+    assert.strictEqual(result.name(), 'font', 'name was not set correctly');
+    assert.strictEqual(result.title(), 'Font', 'title was not set correctly');
+    assert.strictEqual(result.category().title(), 'Font', 'category title was not set correctly');
+    assert.strictEqual(result.category().shortTitle(), 'Font', 'category short title was not set correctly');
+    assert.isFalse(result.isTextType(), 'resource type was not set correctly');
   });
 
   it('is able to return null from a URL that contains an unmapped extension', () => {
@@ -196,11 +196,11 @@ describeWithEnvironment('ResourceType class', () => {
   it('is able to return a resource type from a mapped name', () => {
     const result = ResourceType.fromName('script');
     assert.instanceOf(result, ResourceType, 'result type is incorrect');
-    assert.strictEqual(result!.name(), 'script', 'name was not set correctly');
-    assert.strictEqual(result!.title(), 'Script', 'title was not set correctly');
-    assert.strictEqual(result!.category().title(), 'JavaScript', 'category title was not set correctly');
-    assert.strictEqual(result!.category().shortTitle(), 'JS', 'category short title was not set correctly');
-    assert.isTrue(result!.isTextType(), 'resource type was not set correctly');
+    assert.strictEqual(result.name(), 'script', 'name was not set correctly');
+    assert.strictEqual(result.title(), 'Script', 'title was not set correctly');
+    assert.strictEqual(result.category().title(), 'JavaScript', 'category title was not set correctly');
+    assert.strictEqual(result.category().shortTitle(), 'JS', 'category short title was not set correctly');
+    assert.isTrue(result.isTextType(), 'resource type was not set correctly');
   });
 
   it('is able to return null from an unmapped name', () => {

front_end/core/common/SettingRegistration.test.ts

@@ -51,8 +51,7 @@ describe('SettingRegistration', () => {
 
   it('retrieves a registered setting', () => {
     try {
-      const preRegisteredSetting =
-          Common.Settings.Settings.instance().moduleSetting(settingName) as Common.Settings.Setting<boolean>;
+      const preRegisteredSetting = Common.Settings.Settings.instance().moduleSetting(settingName);
       assert.strictEqual(preRegisteredSetting.title(), settingTitle, 'Setting title is not returned correctly');
       assert.strictEqual(
           preRegisteredSetting.category(), settingCategory, 'Setting category is not returned correctly');

front_end/core/host/InspectorFrontendHost.ts

@@ -121,7 +121,7 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
     }
 
     document.addEventListener('keydown', event => {
-      stopEventPropagation.call(this, (event as KeyboardEvent));
+      stopEventPropagation.call(this, (event));
     }, true);
   }
 

front_end/core/i18n/DevToolsLocale.ts

@@ -62,7 +62,7 @@ export class DevToolsLocale {
   forceFallbackLocale(): void {
     // Locale is 'readonly', this is the only case where we want to forceably
     // overwrite the locale.
-    (this.locale as DevToolsLocale['locale']) = 'en-US';
+    (this.locale as unknown) = 'en-US';
   }
 
   /**

front_end/core/protocol_client/InspectorBackend.ts

@@ -545,7 +545,7 @@ export class TargetBase {
     router.registerSession(this, this.sessionId);
 
     for (const [domain, agentPrototype] of inspectorBackend.agentPrototypes) {
-      const agent = Object.create((agentPrototype as AgentPrototype));
+      const agent = Object.create((agentPrototype));
       agent.target = this;
       this.#agents.set(domain, agent);
     }

front_end/core/sdk/CSSMatchedStyles.ts

@@ -69,8 +69,8 @@ function cleanUserAgentPayload(payload: Protocol.CSS.RuleMatch[]): Protocol.CSS.
   return cleanMatchedPayload;
 
   function mergeRule(from: Protocol.CSS.RuleMatch, to: Protocol.CSS.RuleMatch): void {
-    const shorthands = (new Map() as Map<string, string>);
-    const properties = (new Map() as Map<string, string>);
+    const shorthands = new Map<string, string>();
+    const properties = new Map<string, string>();
     for (const entry of to.rule.style.shorthandEntries) {
       shorthands.set(entry.name, entry.value);
     }
@@ -241,14 +241,14 @@ export class CSSRegisteredProperty {
 export class CSSMatchedStyles {
   #cssModelInternal: CSSModel;
   #nodeInternal: DOMNode;
-  #addedStyles: Map<CSSStyleDeclaration, DOMNode>;
-  #matchingSelectors: Map<number, Map<string, boolean>>;
-  #keyframesInternal: CSSKeyframesRule[];
+  #addedStyles = new Map<CSSStyleDeclaration, DOMNode>();
+  #matchingSelectors = new Map<number, Map<string, boolean>>();
+  #keyframesInternal: CSSKeyframesRule[] = [];
   #registeredProperties: CSSRegisteredProperty[];
   #registeredPropertyMap = new Map<string, CSSRegisteredProperty>();
-  #nodeForStyleInternal: Map<CSSStyleDeclaration, DOMNode|null>;
-  #inheritedStyles: Set<CSSStyleDeclaration>;
-  #styleToDOMCascade: Map<CSSStyleDeclaration, DOMInheritanceCascade>;
+  #nodeForStyleInternal = new Map<CSSStyleDeclaration, DOMNode|null>();
+  #inheritedStyles = new Set<CSSStyleDeclaration>();
+  #styleToDOMCascade = new Map<CSSStyleDeclaration, DOMInheritanceCascade>();
   #parentLayoutNodeId: Protocol.DOM.NodeId|undefined;
   #positionTryRules: CSSPositionTryRule[];
   #activePositionFallbackIndex: number;
@@ -276,13 +276,10 @@ export class CSSMatchedStyles {
   }: CSSMatchedStylesPayload) {
     this.#cssModelInternal = cssModel;
     this.#nodeInternal = node;
-    this.#addedStyles = new Map();
-    this.#matchingSelectors = new Map();
     this.#registeredProperties = [
       ...propertyRules.map(rule => new CSSPropertyRule(cssModel, rule)),
       ...cssPropertyRegistrations,
     ].map(r => new CSSRegisteredProperty(cssModel, r));
-    this.#keyframesInternal = [];
     if (animationsPayload) {
       this.#keyframesInternal = animationsPayload.map(rule => new CSSKeyframesRule(cssModel, rule));
     }
@@ -291,10 +288,6 @@ export class CSSMatchedStyles {
     this.#fontPaletteValuesRule =
         fontPaletteValuesRule ? new CSSFontPaletteValuesRule(cssModel, fontPaletteValuesRule) : undefined;
 
-    this.#nodeForStyleInternal = new Map();
-    this.#inheritedStyles = new Set();
-    this.#styleToDOMCascade = new Map();
-    this.#registeredPropertyMap = new Map();
     this.#activePositionFallbackIndex = activePositionFallbackIndex;
   }
 
@@ -818,17 +811,15 @@ class NodeCascade {
   readonly styles: CSSStyleDeclaration[];
   readonly #isInherited: boolean;
   readonly #isHighlightPseudoCascade: boolean;
-  readonly propertiesState: Map<CSSProperty, PropertyState>;
-  readonly activeProperties: Map<string, CSSProperty>;
+  readonly propertiesState = new Map<CSSProperty, PropertyState>();
+  readonly activeProperties = new Map<string, CSSProperty>();
   constructor(
       matchedStyles: CSSMatchedStyles, styles: CSSStyleDeclaration[], isInherited: boolean,
       isHighlightPseudoCascade: boolean = false) {
     this.#matchedStyles = matchedStyles;
     this.styles = styles;
     this.#isInherited = isInherited;
     this.#isHighlightPseudoCascade = isHighlightPseudoCascade;
-    this.propertiesState = new Map();
-    this.activeProperties = new Map();
   }
 
   computeActiveProperties(): void {
@@ -1301,8 +1292,8 @@ class DOMInheritanceCascade {
       const nodeCascade = this.#nodeCascades[i];
       const variableNames = [];
       for (const entry of nodeCascade.activeProperties.entries()) {
-        const propertyName = (entry[0] as string);
-        const property = (entry[1] as CSSProperty);
+        const propertyName = entry[0];
+        const property = entry[1];
         if (propertyName.startsWith('--')) {
           accumulatedCSSVariables.set(propertyName, {value: property.value, declaration: new CSSValueSource(property)});
           variableNames.push(propertyName);