Skip to content

Commit 67f366b

Browse files
szuendDevtools-frontend LUCI CQ
authored andcommitted
Reland "[deps] Update esbuild to 0.24.0"
This is a reland of commit fcb4df4 ESBuild stumbled over the import(`../../${modulePath}`); in Runtime.js. It considers this a "glob" import and attempts to bundle ALL DevTools file (since the import could load anything). There is no config option to disable this so the solution is to break the esbuild heuristic that detects this. See https://esbuild.github.io/api/#glob for more info. Original change's description: > [deps] Update esbuild to 0.24.0 > > [email protected] > > Bug: None > Change-Id: I587b974f2ff787fa2c0560863d702140f2eff9e2 > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5953149 > Reviewed-by: Philip Pfaffe <[email protected]> > Commit-Queue: Simon Zünd <[email protected]> Bug: None Change-Id: If10a918a0f5075916493c3fa5797212ffb1ee9ba Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5952982 Commit-Queue: Simon Zünd <[email protected]> Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Auto-Submit: Simon Zünd <[email protected]>
1 parent d1d8628 commit 67f366b

File tree

11 files changed

+2549
-2021
lines changed

11 files changed

+2549
-2021
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ deps = {
131131
'packages': [
132132
{
133133
'package': 'infra/3pp/tools/esbuild/${{platform}}',
134-
'version': 'version:2@0.14.13.chromium.2',
134+
'version': 'version:3@0.24.0.chromium.2',
135135
}
136136
],
137137
'dep_type': 'cipd',

front_end/core/root/Runtime.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,9 @@ export class Runtime {
103103
}
104104

105105
loadLegacyModule(modulePath: string): Promise<void> {
106-
return import(`../../${modulePath}`);
106+
const importPath =
107+
`../../${modulePath}`; // Extracted as a variable so esbuild doesn't attempt to bundle all the things.
108+
return import(importPath);
107109
}
108110
}
109111

node_modules/.package-lock.json

Lines changed: 31 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

node_modules/esbuild/LICENSE.md

Lines changed: 21 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

node_modules/esbuild/bin/esbuild

Lines changed: 123 additions & 64 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)