[UNO-d] Remove sync references in devtools strings

Preferences can now be saved to Google account for signed-in users
without enabling Chrome Sync on Win/Mac/Linux (crrev.com/c/6239792,
ChromeOS experiment is in progress). That is, `arePreferencesSynced` can
be true with `isSyncActive` false.

Meanwhile, users cannot toggle devtools settings sync if either
`isSyncActive` or `arePreferencesSynced` is false. Since the
`isSyncActive` condition is redundant on applicable platforms, we will
default `isSyncActive` to true in crrev.com/c/6965039. Setting sync
toggle-ability should then only depend on `arePreferencesSynced`..

Eventually, the current Sync model will be deprecated. This CL updates
the strings accordingly.

Bug: 441694920
Change-Id: Ib78fc28e922b26d3cc78eb8b2e57d50bae5e44c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6956108
Reviewed-by: Wolfgang Beyer <[email protected]>
Commit-Queue: Duong Dac <[email protected]>
Reviewed-by: Ergün Erdoğmuş <[email protected]>

Author: Duong Dac

front_end/entrypoints/main/main-meta.ts

@@ -188,9 +188,9 @@ const UIStrings = {
   browserLanguage: 'Browser UI language',
   /**
    * @description Label for a checkbox in the settings UI. Allows developers to opt-in/opt-out
-   * of syncing DevTools settings via Chrome Sync.
+   * of saving settings to their Google account.
    */
-  enableSync: 'Enable settings sync',
+  saveSettings: 'Save `DevTools` settings to your `Google` account',
   /**
    * @description Label for a checkbox in the settings UI. Allows developers to opt-in/opt-out
    * of receiving Google Developer Program (GDP) badges based on their activity in Chrome DevTools.
@@ -789,7 +789,7 @@ Common.Settings.registerSettingExtension({
   // This name must be kept in sync with DevToolsSettings::kSyncDevToolsPreferencesFrontendName.
   settingName: 'sync-preferences',
   settingType: Common.Settings.SettingType.BOOLEAN,
-  title: i18nLazyString(UIStrings.enableSync),
+  title: i18nLazyString(UIStrings.saveSettings),
   defaultValue: false,
   reloadRequired: true,
 });

front_end/panels/settings/components/SyncSection.test.ts

@@ -70,8 +70,7 @@ describeWithLocale('SyncSection', () => {
 
     const warning = shadowRoot.querySelector('devtools-tooltip');
     assert.instanceOf(warning, HTMLElement);
-
-    assert.include(warning.innerText, 'To turn this setting on');
+    assert.include(warning.innerText, 'You need to first enable saving Chrome settings in your Google account.');
   });
 
   it('disables the checkbox when sync is not active', async () => {

front_end/panels/settings/components/SyncSection.ts

@@ -31,10 +31,10 @@ const UIStrings = {
    */
   syncDisabled: 'To turn this setting on, you must enable Chrome sync.',
   /**
-   * @description Text shown to the user in the Settings UI. 'This setting' refers
-   * to a checkbox that is disabled.
+   * @description Text shown to the user in the Settings UI. Explains why the checkbox
+   * for saving DevTools settings to the user's Google account is inactive.
    */
-  preferencesSyncDisabled: 'To turn this setting on, you must first enable settings sync in Chrome.',
+  preferencesSyncDisabled: 'You need to first enable saving `Chrome` settings in your `Google` account.',
   /**
    * @description Label for the account email address. Shown in the DevTools Settings UI in
    * front of the email address currently used for Chrome Sync.