[sdk] Use source map cache when loading source maps

This CL wires up the SourceMapCache in the source map manager. Since
SourceMapManager works for both Scripts and Stylesheets, we add a new
'debugId' getter to the 'FrameAssociated' interface.

Drive-by: Turn 'loadSourceMap' into a bottle-neck.

[email protected]

Fixed: 442508443
Change-Id: I4e0765241db49b4eebca1b65790ea3552a2b7370
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6903228
Reviewed-by: Philip Pfaffe <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>

Author: szuend

front_end/core/sdk/CSSStyleSheetHeader.ts

@@ -13,6 +13,7 @@ import {DeferredDOMNode} from './DOMModel.js';
 import type {FrameAssociated} from './FrameAssociated.js';
 import type {PageResourceLoadInitiator} from './PageResourceLoader.js';
 import {ResourceTreeModel} from './ResourceTreeModel.js';
+import type {DebugId} from './SourceMap.js';
 
 const UIStrings = {
   /**
@@ -188,4 +189,8 @@ export class CSSStyleSheetHeader implements TextUtils.ContentProvider.ContentPro
       initiatorUrl: this.hasSourceURL ? Platform.DevToolsPath.EmptyUrlString : this.sourceURL,
     };
   }
+
+  debugId(): DebugId|null {
+    return null;
+  }
 }

front_end/core/sdk/FrameAssociated.ts

@@ -3,6 +3,9 @@
 // found in the LICENSE file.
 
 import type {PageResourceLoadInitiator} from './PageResourceLoader.js';
+import type {DebugId} from './SourceMap.js';
+
 export interface FrameAssociated {
-  createPageResourceLoadInitiator: () => PageResourceLoadInitiator;
+  createPageResourceLoadInitiator(): PageResourceLoadInitiator;
+  debugId(): DebugId|null;
 }

front_end/core/sdk/Script.ts

@@ -44,7 +44,7 @@ import type {FrameAssociated} from './FrameAssociated.js';
 import type {PageResourceLoadInitiator} from './PageResourceLoader.js';
 import {ResourceTreeModel} from './ResourceTreeModel.js';
 import type {ExecutionContext} from './RuntimeModel.js';
-import type {SourceMap} from './SourceMap.js';
+import type {DebugId, SourceMap} from './SourceMap.js';
 import type {Target} from './Target.js';
 
 const UIStrings = {
@@ -425,6 +425,10 @@ export class Script implements TextUtils.ContentProvider.ContentProvider, FrameA
     return {target: this.target(), frameId: this.frameId, initiatorUrl: this.embedderName()};
   }
 
+  debugId(): DebugId|null {
+    return this.buildId as (DebugId | null);
+  }
+
   /**
    * Translates the `rawLocation` from line and column number in terms of what V8 understands
    * to a script relative location. Specifically this means that for inline `<script>`'s

front_end/core/sdk/SourceMapManager.test.ts

@@ -110,6 +110,10 @@ describe('SourceMapManager', () => {
     createPageResourceLoadInitiator(): SDK.PageResourceLoader.PageResourceLoadInitiator {
       return {target: this.target, frameId: null, initiatorUrl: null};
     }
+
+    debugId(): SDK.SourceMap.DebugId|null {
+      return null;
+    }
   }
 
   describe('attachSourceMap', () => {

front_end/core/sdk/SourceMapManager.ts

@@ -7,7 +7,8 @@ import * as Platform from '../platform/platform.js';
 
 import type {FrameAssociated} from './FrameAssociated.js';
 import {PageResourceLoader, type PageResourceLoadInitiator} from './PageResourceLoader.js';
-import {parseSourceMap, SourceMap, type SourceMapV3} from './SourceMap.js';
+import {type DebugId, parseSourceMap, SourceMap, type SourceMapV3} from './SourceMap.js';
+import {SourceMapCache} from './SourceMapCache.js';
 import {type Target, Type} from './Target.js';
 
 export class SourceMapManager<T extends FrameAssociated> extends Common.ObjectWrapper.ObjectWrapper<EventTypes<T>> {
@@ -105,7 +106,7 @@ export class SourceMapManager<T extends FrameAssociated> extends Common.ObjectWr
           this.#attachingClient = null;
           const initiator = client.createPageResourceLoadInitiator();
           clientData.sourceMapPromise =
-              loadSourceMap(sourceMapURL, initiator)
+              loadSourceMap(sourceMapURL, client.debugId(), initiator)
                   .then(
                       payload => {
                         const sourceMap = new SourceMap(sourceURL, sourceMapURL, payload);
@@ -169,10 +170,23 @@ export class SourceMapManager<T extends FrameAssociated> extends Common.ObjectWr
 }
 
 export async function loadSourceMap(
-    url: Platform.DevToolsPath.UrlString, initiator: PageResourceLoadInitiator): Promise<SourceMapV3> {
+    url: Platform.DevToolsPath.UrlString, debugId: DebugId|null,
+    initiator: PageResourceLoadInitiator): Promise<SourceMapV3> {
   try {
+    if (debugId) {
+      const cachedSourceMap = await SourceMapCache.instance().get(debugId);
+      if (cachedSourceMap) {
+        return cachedSourceMap;
+      }
+    }
+
     const {content} = await PageResourceLoader.instance().loadResource(url, initiator);
-    return parseSourceMap(content);
+    const sourceMap = parseSourceMap(content);
+    if ('debugId' in sourceMap && sourceMap.debugId) {
+      // In case something goes wrong with updating the cache, we still want to use the source map.
+      await SourceMapCache.instance().set(sourceMap.debugId as DebugId, sourceMap).catch();
+    }
+    return sourceMap;
   } catch (cause) {
     throw new Error(`Could not load content for ${url}: ${cause.message}`, {cause});
   }
@@ -181,10 +195,9 @@ export async function loadSourceMap(
 export async function tryLoadSourceMap(
     url: Platform.DevToolsPath.UrlString, initiator: PageResourceLoadInitiator): Promise<SourceMapV3|null> {
   try {
-    const {content} = await PageResourceLoader.instance().loadResource(url, initiator);
-    return parseSourceMap(content);
+    return await loadSourceMap(url, null, initiator);
   } catch (cause) {
-    console.error(`Could not load content for ${url}: ${cause.message}`, {cause});
+    console.error(cause);
     return null;
   }
 }