[DrJones/Perf] Omit the call tree on followup questions

The model doesn't need it repeated. And we can use the context window
space.

Bug: 370436840
Change-Id: I4699807fb0877f4cbfd689434d1533ec19fd4cb0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5976667
Commit-Queue: Jack Franklin <[email protected]>
Auto-Submit: Paul Irish <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>

Author: paulirish

front_end/panels/freestyler/DrJonesPerformanceAgent.test.ts

@@ -165,7 +165,7 @@ self: 3
         },
         {
           type: ResponseType.QUERYING,
-          query: `\n${expectedData}\n\n# User request\n\ntest`,
+          query: `${expectedData}\n\n# User request\n\ntest`,
         },
         {
           type: ResponseType.ANSWER,
@@ -178,7 +178,7 @@ self: 3
       assert.deepStrictEqual(agent.chatHistoryForTesting, [
         {
           entity: 1,
-          text: `\n${aiCallTree.serialize()}\n\n# User request\n\ntest`,
+          text: `${aiCallTree.serialize()}\n\n# User request\n\ntest`,
         },
         {
           entity: 2,
@@ -187,4 +187,55 @@ self: 3
       ]);
     });
   });
+
+  describe('enhanceQuery', () => {
+    it('does not send the serialized calltree again if it is a followup chat about the same calltree', async () => {
+      const agent = new DrJonesPerformanceAgent({
+        aidaClient: {} as Host.AidaClient.AidaClient,
+      });
+
+      const mockAiCallTree = {
+        serialize: () => 'Mock call tree',
+      } as unknown as TimelineUtils.AICallTree.AICallTree;
+
+      const enhancedQuery1 = await agent.enhanceQuery('What is this?', mockAiCallTree);
+      assert.strictEqual(enhancedQuery1, 'Mock call tree\n\n# User request\n\nWhat is this?');
+
+      // Create history state of the above query
+      agent.chatNewHistoryForTesting = new Map([[
+        0,
+        [
+          {
+            type: ResponseType.CONTEXT,
+            title: 'Analyzing call tree',
+            details: [
+              {
+                title: 'Selected call tree',
+                text: mockAiCallTree.serialize(),
+              },
+            ],
+          },
+          {
+            type: ResponseType.QUERYING,
+            query: enhancedQuery1,
+          },
+          {
+            type: ResponseType.ANSWER,
+            text: 'test answer',
+          },
+        ],
+      ]]);
+
+      const query2 = 'But what about this follow-up question?';
+      const enhancedQuery2 = await agent.enhanceQuery(query2, mockAiCallTree);
+      assert.strictEqual(enhancedQuery2, query2);
+      assert.isFalse(enhancedQuery2.includes(mockAiCallTree.serialize()));
+
+      // Just making sure any subsequent chat doesnt include it either.
+      const query3 = 'And this 3rd question?';
+      const enhancedQuery3 = await agent.enhanceQuery(query3, mockAiCallTree);
+      assert.strictEqual(enhancedQuery3, query3);
+      assert.isFalse(enhancedQuery3.includes(mockAiCallTree.serialize()));
+    });
+  });
 });

front_end/panels/freestyler/DrJonesPerformanceAgent.ts

@@ -159,7 +159,20 @@ export class DrJonesPerformanceAgent extends AiAgent<TimelineUtils.AICallTree.AI
   override async enhanceQuery(query: string, aiCallTree: TimelineUtils.AICallTree.AICallTree|null): Promise<string> {
     const treeStr = aiCallTree?.serialize();
 
-    const perfEnhancementQuery = aiCallTree ? `\n${treeStr}\n\n# User request\n\n` : '';
+    // Collect the queries from previous messages in this session
+    const prevQueries: string[] = [];
+    for await (const data of this.runFromHistory()) {
+      if (data.type === ResponseType.QUERYING) {
+        prevQueries.push(data.query);
+      }
+    }
+    // If this is a followup chat about the same call tree, don't include the call tree serialization again.
+    // We don't need to repeat it and we'd rather have more the context window space.
+    if (prevQueries.length && treeStr && prevQueries.find(q => q.startsWith(treeStr))) {
+      aiCallTree = null;
+    }
+
+    const perfEnhancementQuery = aiCallTree ? `${treeStr}\n\n# User request\n\n` : '';
     return `${perfEnhancementQuery}${query}`;
   }