Fix letting disabled custom properties as override previous declarations

Fixed: 361717753
Change-Id: Ibd724284b6a5461ed136fd3046e955ecb47359e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5973212
Auto-Submit: Philip Pfaffe <[email protected]>
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>

Author: pfaffe

front_end/core/sdk/CSSStyleDeclaration.test.ts

@@ -202,6 +202,16 @@ describeWithMockConnection('CSSStyleDeclaration', () => {
           range: {startLine: 1, startColumn: 4, endLine: 1, endColumn: 20},
           text: '--a 10;',
         },
+        {
+          name: '--b',
+          value: '10',
+          disabled: true,
+          implicit: false,
+          parsedOk: true,
+          longhandProperties: [],
+          range: {startLine: 1, startColumn: 4, endLine: 1, endColumn: 20},
+          text: '--b: 10;',
+        },
       ],
       shorthandEntries: [],
       cssText: '\n    --a: 5px;\n    --a: 10\n',

front_end/core/sdk/CSSStyleDeclaration.ts

@@ -192,7 +192,7 @@ export class CSSStyleDeclaration {
       const metadata = cssMetadata();
       const canonicalName = metadata.canonicalPropertyName(property.name);
       if (property.disabled || !property.parsedOk) {
-        if (property.name.startsWith('--')) {
+        if (!property.disabled && metadata.isCustomProperty(property.name)) {
           // Variable declarations that aren't parsedOk still "overload" other previous active declarations.
           activeProperties.get(canonicalName)?.setActive(false);
           activeProperties.delete(canonicalName);