Skip to content

Commit 7055c56

Browse files
hanselfmu-chromiumDevtools-frontend LUCI CQ
authored andcommitted
Remove CSSPropertyDocumentation metrics tracking
Bug: 392616108 Change-Id: I29fbc1b49629bd76ee9c7cc52ead793de51c0bd3 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6233368 Commit-Queue: Philip Pfaffe <[email protected]> Auto-Submit: Changhao Han <[email protected]> Commit-Queue: Changhao Han <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]>
1 parent 108ede5 commit 7055c56

File tree

4 files changed

+0
-20
lines changed

4 files changed

+0
-20
lines changed

front_end/core/host/InspectorFrontendHostAPI.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,6 @@ export const enum EnumeratedHistogram {
483483
CSSHintShown = 'DevTools.CSSHintShown',
484484
LighthouseModeRun = 'DevTools.LighthouseModeRun',
485485
LighthouseCategoryUsed = 'DevTools.LighthouseCategoryUsed',
486-
CSSPropertyDocumentation = 'DevTools.CSSPropertyDocumentation',
487486
SwatchActivated = 'DevTools.SwatchActivated',
488487
AnimationPlaybackRateChanged = 'DevTools.AnimationPlaybackRateChanged',
489488
AnimationPointDragged = 'DevTools.AnimationPointDragged',

front_end/core/host/UserMetrics.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -310,11 +310,6 @@ export class UserMetrics {
310310
EnumeratedHistogram.LighthouseCategoryUsed, type, LighthouseCategoryUsed.MAX_VALUE);
311311
}
312312

313-
cssPropertyDocumentation(type: CSSPropertyDocumentation): void {
314-
InspectorFrontendHostInstance.recordEnumeratedHistogram(
315-
EnumeratedHistogram.CSSPropertyDocumentation, type, CSSPropertyDocumentation.MAX_VALUE);
316-
}
317-
318313
swatchActivated(swatch: SwatchType): void {
319314
InspectorFrontendHostInstance.recordEnumeratedHistogram(
320315
EnumeratedHistogram.SwatchActivated, swatch, SwatchType.MAX_VALUE);
@@ -1000,13 +995,6 @@ export enum DevtoolsExperiments {
1000995
MAX_VALUE = 107,
1001996
}
1002997

1003-
export const enum CSSPropertyDocumentation {
1004-
SHOWN = 0,
1005-
TOGGLED_ON = 1,
1006-
TOGGLED_OFF = 2,
1007-
MAX_VALUE = 3,
1008-
}
1009-
1010998
// Update DevToolsIssuesPanelIssueExpanded from tools/metrics/histograms/enums.xml if new enum is added.
1011999
export enum IssueExpanded {
10121000
/* eslint-disable @typescript-eslint/naming-convention */

front_end/devtools_compatibility.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,6 @@ const EnumeratedHistogram = {
441441
TimelineNavigationSettingState: 'DevTools.TimelineNavigationSettingState',
442442
StyleTextCopied: 'DevTools.StyleTextCopied',
443443
SyncSetting: 'DevTools.SyncSetting',
444-
CSSPropertyDocumentation: 'DevTools.CSSPropertyDocumentation',
445444
SwatchActivated: 'DevTools.SwatchActivated',
446445
AnimationPlaybackRateChanged: 'DevTools.AnimationPlaybackRateChanged',
447446
AnimationPointDragged: 'DevTools.AnimationPointDragged',

front_end/panels/elements/StylesSidebarPane.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -296,11 +296,6 @@ export class StylesSidebarPane extends Common.ObjectWrapper.eventMixin<EventType
296296

297297
const showDocumentationSetting =
298298
Common.Settings.Settings.instance().moduleSetting('show-css-property-documentation-on-hover');
299-
showDocumentationSetting.addChangeListener(event => {
300-
const metricType = Boolean(event.data) ? Host.UserMetrics.CSSPropertyDocumentation.TOGGLED_ON :
301-
Host.UserMetrics.CSSPropertyDocumentation.TOGGLED_OFF;
302-
Host.userMetrics.cssPropertyDocumentation(metricType);
303-
});
304299

305300
this.#hintPopoverHelper = new UI.PopoverHelper.PopoverHelper(this.contentElement, event => {
306301
const hoveredNode = event.composedPath()[0];
@@ -346,7 +341,6 @@ export class StylesSidebarPane extends Common.ObjectWrapper.eventMixin<EventType
346341
show: async (popover: UI.GlassPane.GlassPane) => {
347342
const popupElement = new ElementsComponents.CSSPropertyDocsView.CSSPropertyDocsView(cssProperty);
348343
popover.contentElement.appendChild(popupElement);
349-
Host.userMetrics.cssPropertyDocumentation(Host.UserMetrics.CSSPropertyDocumentation.SHOWN);
350344
return true;
351345
},
352346
};

0 commit comments

Comments
 (0)