Skip to content

Commit 710f5de

Browse files
danilsomsikovDevtools-frontend LUCI CQ
authored andcommitted
Fully adopt UI eng vision in CoverageView
Bug: 407751409 Change-Id: I390df4f1b6f28439518629216dcfefdd4522ad28 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7027474 Commit-Queue: Danil Somsikov <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]> Auto-Submit: Danil Somsikov <[email protected]>
1 parent 5e96b70 commit 710f5de

File tree

3 files changed

+205
-198
lines changed

3 files changed

+205
-198
lines changed

front_end/panels/coverage/CoverageView.test.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const isShowingLandingPage = (view: Coverage.CoverageView.CoverageView) => {
2020
};
2121

2222
const isShowingResults = (view: Coverage.CoverageView.CoverageView) => {
23-
return Boolean(view.contentElement.querySelector('.coverage-results .vbox.flex-auto'));
23+
return Boolean(view.contentElement.querySelector('.coverage-results .results'));
2424
};
2525

2626
const isShowingPrerenderPage = (view: Coverage.CoverageView.CoverageView) => {
@@ -94,9 +94,10 @@ describeWithMockConnection('CoverageView', () => {
9494
]);
9595
});
9696

97-
it('dispatches a record/reload action when the button is clicked', () => {
97+
it('dispatches a record/reload action when the button is clicked', async () => {
9898
const view = Coverage.CoverageView.CoverageView.instance();
9999
renderElementIntoDOM(view);
100+
await view.updateComplete;
100101
assert.isTrue(isShowingLandingPage(view));
101102

102103
const button = view.contentElement.querySelector('.empty-state devtools-button');
@@ -130,6 +131,7 @@ describeWithMockConnection('CoverageView', () => {
130131
sinon.assert.calledOnce(startSpy);
131132

132133
navigate(getMainFrame(target), {}, Protocol.Page.NavigationType.BackForwardCacheRestore);
134+
await view.updateComplete;
133135

134136
assert.isFalse(isShowingLandingPage(view));
135137
assert.isFalse(isShowingResults(view));
@@ -139,6 +141,7 @@ describeWithMockConnection('CoverageView', () => {
139141
sinon.assert.notCalled(stopSpy);
140142

141143
navigate(getMainFrame(target));
144+
await view.updateComplete;
142145
assert.isFalse(isShowingLandingPage(view));
143146
assert.isTrue(isShowingResults(view));
144147
assert.isFalse(isShowingPrerenderPage(view));
@@ -156,6 +159,7 @@ describeWithMockConnection('CoverageView', () => {
156159
it('can handle prerender activations', async () => {
157160
const {startSpy, stopSpy} = setupTargetAndModels();
158161
const view = Coverage.CoverageView.CoverageView.instance();
162+
await view.updateComplete;
159163
renderElementIntoDOM(view);
160164
assert.isTrue(isShowingLandingPage(view));
161165
assert.isFalse(isShowingResults(view));
@@ -185,6 +189,7 @@ describeWithMockConnection('CoverageView', () => {
185189
sinon.assert.notCalled(stopSpy2);
186190

187191
navigate(getMainFrame(target2), {url: 'http://www.example.com/page'});
192+
await view.updateComplete;
188193
assert.isFalse(isShowingLandingPage(view));
189194
assert.isTrue(isShowingResults(view));
190195
assert.isFalse(isShowingPrerenderPage(view));

0 commit comments

Comments
 (0)