[cleanup] Remove explicit flag

Run the type checking before committing changes

Fixed: 407085691
Change-Id: If0431efa67e90e067a5005381133096887fda4dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6417242
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

scripts/build/typescript/ts_library.py

@@ -10,7 +10,6 @@
 import subprocess
 import sys
 import re
-from pathlib import Path
 
 from os import path
 

scripts/eslint_rules/lib/no-imperative-dom-api/dom-api.js

@@ -100,7 +100,7 @@ module.exports = {
         if (isIdentifier(property, 'setAttribute')) {
           const attribute = firstArg;
           const value = secondArg;
-          if (attribute.type === 'Literal' && value.type !== 'SpreadElement') {
+          if (attribute.type === 'Literal' && value.type !== 'SpreadElement' && attribute.value) {
             domFragment.attributes.push({key: attribute.value.toString(), value});
             return true;
           }

scripts/test/run_lint_check.mjs

@@ -31,11 +31,6 @@ const flags = yargs(hideBin(process.argv))
     describe:
       'Disable cache validations during debugging, useful for custom rule creation/debugging.',
   })
-  .option('tsc', {
-    type: 'boolean',
-    default: false,
-    describe: 'Temperary here while fixing EsLint rule',
-  })
   .usage('$0 [<files...>]', 'Run the linter on the provided files', yargs => {
     yargs.positional('files', {
       describe: 'File(s), glob(s), or directories',
@@ -275,7 +270,8 @@ function shouldIgnoreFile(path) {
 }
 
 async function runEslintRulesTypeCheck(_files) {
-  const tscPath = join(nodeModulesPath(), '.bin', 'tsc');
+  debugLogging('[lint]: Running EsLint custom rules typechecking...');
+  const tscPath = join(nodeModulesPath(), 'typescript', 'bin', 'tsc');
   const tsConfigEslintRules = join(
     devtoolsRootPath(),
     'scripts',
@@ -294,24 +290,24 @@ async function runEslintRulesTypeCheck(_files) {
     };
 
     return await new Promise(resolve => {
-      const litAnalyzerProcess = spawn(nodePath(), args, {
+      const tscProcess = spawn(nodePath(), args, {
         encoding: 'utf-8',
         cwd: devtoolsRootPath(),
       });
 
-      litAnalyzerProcess.stdout.on('data', data => {
+      tscProcess.stdout.on('data', data => {
         result.output += `\n${data.toString()}`;
       });
-      litAnalyzerProcess.stderr.on('data', data => {
+      tscProcess.stderr.on('data', data => {
         result.error += `\n${data.toString()}`;
       });
 
-      litAnalyzerProcess.on('error', message => {
+      tscProcess.on('error', message => {
         result.error += `\n${message}`;
         resolve(result);
       });
 
-      litAnalyzerProcess.on('exit', code => {
+      tscProcess.on('exit', code => {
         result.status = code === 0;
         resolve(result);
       });
@@ -320,7 +316,7 @@ async function runEslintRulesTypeCheck(_files) {
 
   const result = await runTypeCheck();
 
-  if (result.output && !result.output.includes('Found 0 problems')) {
+  if (result.output) {
     console.log(result.output);
   }
   if (result.error) {
@@ -362,7 +358,7 @@ async function run() {
   if (styles.length !== 0) {
     succeed &&= await runStylelint(styles);
   }
-  if (esLintRules.length !== 0 && flags.tsc) {
+  if (esLintRules.length !== 0) {
     succeed &&= await runEslintRulesTypeCheck();
   }