Skip to content

Commit 7158d49

Browse files
Samiya CaurDevtools-frontend LUCI CQ
authored andcommitted
Update CSS for toolbar to allow for better wrapping on smaller screens
Screenshots: - Bigger window size: https://screenshot.googleplex.com/B64oqJ84NtEukkf - Small window size without citations: https://screenshot.googleplex.com/BQjNFvidUCb3w8U - Small window size with citations: https://screenshot.googleplex.com/6rt34jsY6WxnwcD This CL also removes '\n' as the suffix in case of no characters after the cursor Bug: 425645741 Change-Id: Iaed77b77a522c093fd999a71114c0bffe6029dba Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6823965 Auto-Submit: Samiya Caur <[email protected]> Commit-Queue: Samiya Caur <[email protected]> Reviewed-by: Ergün Erdoğmuş <[email protected]>
1 parent e58100d commit 7158d49

File tree

3 files changed

+45
-18
lines changed

3 files changed

+45
-18
lines changed

front_end/panels/common/AiCodeCompletionSummaryToolbar.ts

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -105,20 +105,21 @@ export const DEFAULT_SUMMARY_TOOLBAR_VIEW: View = (input, output, target) => {
105105
};
106106
}
107107
})}></devtools-spinner>
108-
<span
109-
tabIndex="0"
110-
class="link"
111-
role="link"
112-
jslog=${VisualLogging.link('open-ai-settings').track({
113-
click: true,
114-
})}
115-
aria-details=${input.disclaimerTooltipId}
116-
aria-describedby=${input.disclaimerTooltipId}
117-
@click=${() => {
118-
void UI.ViewManager.ViewManager.instance().showView('chrome-ai');
119-
}}
120-
>${lockedString(UIStrings.relevantData)}</span>${lockedString(UIStrings.isSentToGoogle)}
121-
<devtools-tooltip
108+
<span class="disclaimer-text">
109+
<span
110+
tabIndex="0"
111+
class="link"
112+
role="link"
113+
jslog=${VisualLogging.link('open-ai-settings').track({
114+
click: true,
115+
})}
116+
aria-details=${input.disclaimerTooltipId}
117+
aria-describedby=${input.disclaimerTooltipId}
118+
@click=${() => {
119+
void UI.ViewManager.ViewManager.instance().showView('chrome-ai');
120+
}}
121+
>${lockedString(UIStrings.relevantData)}</span>&nbsp;${lockedString(UIStrings.isSentToGoogle)}
122+
</span><devtools-tooltip
122123
id=${input.disclaimerTooltipId}
123124
variant=${'rich'}
124125
jslogContext=${input.panelName + '.ai-code-completion-disclaimer'}

front_end/panels/common/aiCodeCompletionSummaryToolbar.css

Lines changed: 30 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
@scope to (devtools-widget > *) {
88
.ai-code-completion-summary-toolbar {
99
display: flex;
10+
height: 26px;
1011
border-top: var(--sys-size-1) solid var(--sys-color-divider);
1112
background-color: var(--sys-color-cdt-base-container);
1213
padding: var(--sys-size-2) var(--sys-size-5);
@@ -26,9 +27,11 @@
2627
}
2728

2829
.ai-code-completion-disclaimer {
29-
padding-right: var(--sys-size-5);
3030
gap: 5px;
3131
display: flex;
32+
white-space: nowrap;
33+
overflow: hidden;
34+
flex-shrink: 0;
3235

3336
devtools-spinner {
3437
margin-top: var(--sys-size-2);
@@ -39,13 +42,39 @@
3942
}
4043

4144
.ai-code-completion-recitation-notice {
45+
padding-left: var(--sys-size-5);
4246
border-left: var(--sys-size-1) solid var(--sys-color-divider);
47+
white-space: nowrap;
48+
overflow: hidden;
4349

4450
span.link {
4551
padding-left: var(--sys-size-3);
4652
}
4753
}
4854

55+
@media (width < 545px) {
56+
flex-direction: column;
57+
align-items: flex-start;
58+
59+
.ai-code-completion-disclaimer {
60+
height: 26px;
61+
margin-bottom: -3px;
62+
margin-top: var(--sys-size-2);
63+
flex-shrink: 1;
64+
}
65+
66+
.ai-code-completion-recitation-notice {
67+
height: 26px;
68+
padding-left: 0;
69+
border-left: 0;
70+
margin-top: -3px;
71+
}
72+
73+
&:has(.ai-code-completion-recitation-notice) {
74+
height: 46px;
75+
}
76+
}
77+
4978
devtools-tooltip:popover-open {
5079
display: flex;
5180
flex-direction: column;

front_end/panels/console/ConsolePrompt.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -252,9 +252,6 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
252252
}
253253
}
254254
let suffix = query.substring(cursor);
255-
if (suffix === '') {
256-
suffix = '\n';
257-
}
258255
if (prefix.length > AI_CODE_COMPLETION_CHARACTER_LIMIT) {
259256
prefix = prefix.substring(prefix.length - AI_CODE_COMPLETION_CHARACTER_LIMIT);
260257
}

0 commit comments

Comments
 (0)