Skip to content

Commit 71be07d

Browse files
Connor ClarkDevtools-frontend LUCI CQ
authored andcommitted
Tweak strings used for CPU calibration.
Bug: 311438112 Change-Id: I804e2ac64e6d31c3b30e9e855d84f80444935fc1 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6168379 Commit-Queue: Connor Clark <[email protected]> Reviewed-by: Paul Irish <[email protected]>
1 parent ab2dbb6 commit 71be07d

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -143,12 +143,16 @@ const UIStrings = {
143143
* @description Text to use to indicate that a CPU calibration has not been run yet.
144144
*/
145145
needsCalibration: 'Needs calibration',
146-
// TODO(crbug.com/311438112): Add 'Learn more' link.
147146
/**
148147
*@description Text to explain why the user should run the CPU calibration process.
149148
*/
150149
calibrationCTA:
151150
'To use the CPU throttling presets, run the calibration process to determine the ideal throttling rate for your device.',
151+
/**
152+
*@description Text to explain what CPU throttling presets are.
153+
*/
154+
cpuCalibrationDescription:
155+
'These presets throttle your CPU to approximate the performance of typical low or mid-tier mobile devices.',
152156
/**
153157
*@description Text to explain how the CPU calibration process will work.
154158
*/
@@ -218,6 +222,9 @@ export class CPUThrottlingCard {
218222

219223
const card = new Cards.Card.Card();
220224

225+
const descriptionEl = card.createChild('span');
226+
descriptionEl.textContent = i18nString(UIStrings.cpuCalibrationDescription);
227+
221228
this.lowTierMobileDeviceEl = card.createChild('div', 'cpu-preset-section');
222229
this.lowTierMobileDeviceEl.append('Low-tier mobile device');
223230
this.lowTierMobileDeviceEl.createChild('div', 'cpu-preset-result');
@@ -256,7 +263,7 @@ export class CPUThrottlingCard {
256263

257264
card.data = {
258265
heading: i18nString(UIStrings.cpuThrottlingPresets),
259-
content: [this.lowTierMobileDeviceEl, this.midTierMobileDeviceEl, this.calibrateEl],
266+
content: [descriptionEl, this.lowTierMobileDeviceEl, this.midTierMobileDeviceEl, this.calibrateEl],
260267
};
261268
this.element = card;
262269

@@ -294,9 +301,11 @@ export class CPUThrottlingCard {
294301
this.calibrateButton.textContent =
295302
hasCalibrated ? i18nString(UIStrings.recalibrate) : i18nString(UIStrings.calibrate);
296303

297-
this.textEl.style.display = '';
298-
this.textEl.textContent = '';
299-
this.textEl.append(this.createTextWithIcon(i18nString(UIStrings.calibrationCTA), 'info'));
304+
if (!hasCalibrated) {
305+
this.textEl.style.display = '';
306+
this.textEl.textContent = '';
307+
this.textEl.append(this.createTextWithIcon(i18nString(UIStrings.calibrationCTA), 'info'));
308+
}
300309
} else if (this.state === 'prompting') {
301310
this.calibrateButton.style.display = '';
302311
this.calibrateButton.textContent = i18nString(UIStrings.continue);

0 commit comments

Comments
 (0)