Skip to content

Commit 72ecee6

Browse files
ergunshDevtools-frontend LUCI CQ
authored andcommitted
Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance. In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8724318640761543329 [email protected] Bug: none Change-Id: Ib6caf6868401e1690d931babc222cde0d24dd3c5 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6216624 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Ergün Erdoğmuş <[email protected]> Reviewed-by: Nikolay Vitkov <[email protected]>
1 parent 8793401 commit 72ecee6

File tree

12 files changed

+353
-110
lines changed

12 files changed

+353
-110
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ vars = {
2424
'inspector_protocol_revision': '69d69ddf3aa698b171886551a4a672c5af1ad902',
2525

2626
# Keeping track of the last time we rollerd the browser protocol files.
27-
'chromium_browser_protocol_revision' : '596cc3859fdf284fa1108c6a959ca94589132b8d',
27+
'chromium_browser_protocol_revision' : 'a8021e75f19d65f31e2ef30c86e91663889595ee',
2828

2929
'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
3030
'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',

front_end/core/sdk/ResourceTreeModel.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1131,6 +1131,9 @@ export class PageDispatcher implements ProtocolProxyApi.PageDispatcher {
11311131
frameClearedScheduledNavigation({}: Protocol.Page.FrameClearedScheduledNavigationEvent): void {
11321132
}
11331133

1134+
frameStartedNavigating({}: Protocol.Page.FrameStartedNavigatingEvent): void {
1135+
}
1136+
11341137
navigatedWithinDocument({}: Protocol.Page.NavigatedWithinDocumentEvent): void {
11351138
}
11361139

front_end/core/sdk/ScreenCaptureModel.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,9 @@ export class ScreenCaptureModel extends SDKModel<void> implements ProtocolProxyA
140140
frameRequestedNavigation(_params: Protocol.Page.FrameRequestedNavigationEvent): void {
141141
}
142142

143+
frameStartedNavigating(_params: Protocol.Page.FrameStartedNavigatingEvent): void {
144+
}
145+
143146
frameSubtreeWillBeDetached(_params: Protocol.Page.FrameSubtreeWillBeDetachedEvent): void {
144147
}
145148

front_end/generated/InspectorBackendCommands.js

Lines changed: 6 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

front_end/generated/protocol-mapping.d.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,16 @@ export namespace ProtocolMapping {
373373
*/
374374
'Page.documentOpened': [Protocol.Page.DocumentOpenedEvent];
375375
'Page.frameResized': [];
376+
/**
377+
* Fired when a navigation starts. This event is fired for both
378+
* renderer-initiated and browser-initiated navigations. For renderer-initiated
379+
* navigations, the event is fired after `frameRequestedNavigation`.
380+
* Navigation may still be cancelled after the event is issued. Multiple events
381+
* can be fired for a single navigation, for example, when a same-document
382+
* navigation becomes a cross-document navigation (such as in the case of a
383+
* frameset).
384+
*/
385+
'Page.frameStartedNavigating': [Protocol.Page.FrameStartedNavigatingEvent];
376386
/**
377387
* Fired when a renderer-initiated navigation is requested.
378388
* Navigation may still be cancelled after the event is issued.
@@ -714,6 +724,7 @@ export namespace ProtocolMapping {
714724
'FedCm.dialogClosed': [Protocol.FedCm.DialogClosedEvent];
715725
/**
716726
* Fired when breakpoint is resolved to an actual script and location.
727+
* Deprecated in favor of `resolvedBreakpoints` in the `scriptParsed` event.
717728
*/
718729
'Debugger.breakpointResolved': [Protocol.Debugger.BreakpointResolvedEvent];
719730
/**

front_end/generated/protocol-proxy-api.d.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2915,6 +2915,17 @@ declare namespace ProtocolProxyApi {
29152915

29162916
frameResized(): void;
29172917

2918+
/**
2919+
* Fired when a navigation starts. This event is fired for both
2920+
* renderer-initiated and browser-initiated navigations. For renderer-initiated
2921+
* navigations, the event is fired after `frameRequestedNavigation`.
2922+
* Navigation may still be cancelled after the event is issued. Multiple events
2923+
* can be fired for a single navigation, for example, when a same-document
2924+
* navigation becomes a cross-document navigation (such as in the case of a
2925+
* frameset).
2926+
*/
2927+
frameStartedNavigating(params: Protocol.Page.FrameStartedNavigatingEvent): void;
2928+
29182929
/**
29192930
* Fired when a renderer-initiated navigation is requested.
29202931
* Navigation may still be cancelled after the event is issued.
@@ -4345,6 +4356,7 @@ declare namespace ProtocolProxyApi {
43454356
export interface DebuggerDispatcher {
43464357
/**
43474358
* Fired when breakpoint is resolved to an actual script and location.
4359+
* Deprecated in favor of `resolvedBreakpoints` in the `scriptParsed` event.
43484360
*/
43494361
breakpointResolved(params: Protocol.Debugger.BreakpointResolvedEvent): void;
43504362

0 commit comments

Comments
 (0)