Skip to content

Commit 73feede

Browse files
hanselfmu-chromiumDevtools-frontend LUCI CQ
authored andcommitted
Remove justify-self from grid validator
Per https://issues.chromium.org/issues/374801318#comment6, `justify-self` is now supported for block items as well, hence removing it from a GridItem validator. Fixed: 374991970 Change-Id: I94dacd560ee71ca3fda2649ba2ff46e597972c81 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5961523 Auto-Submit: Changhao Han <[email protected]> Reviewed-by: Simon Zünd <[email protected]> Commit-Queue: Simon Zünd <[email protected]>
1 parent becc8c8 commit 73feede

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

front_end/panels/elements/CSSRuleValidator.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -304,11 +304,6 @@ export class GridItemValidator extends CSSRuleValidator {
304304
'grid-row',
305305
'grid-row-end',
306306
'grid-row-start',
307-
// At the time of writing (November 2022), `justify-self` is only in effect in grid layout.
308-
// There are no other browsers that support `justify-self` in other layouts.
309-
// https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Box_Alignment/Box_Alignment_In_Block_Abspos_Tables
310-
// TODO: move `justify-self` to other validator or change pop-over text if Chrome supports CSS Align in other layouts.
311-
'justify-self',
312307
]);
313308
}
314309

0 commit comments

Comments
 (0)