Skip to content

Commit 76cbb2c

Browse files
Lightning00BladeDevtools-frontend LUCI CQ
authored andcommitted
[eslint] Add eslint-plugin-lit
This enforces rules from the plugin, and disables the two offending files, comments on the files themselves. Fixed: 457654458 Change-Id: I762b2eac31480cedafdf6031dee8b1e054b83a18 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7124645 Auto-Submit: Nikolay Vitkov <[email protected]> Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Nikolay Vitkov <[email protected]>
1 parent 92be0b6 commit 76cbb2c

File tree

127 files changed

+13827
-169
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

127 files changed

+13827
-169
lines changed

eslint.config.mjs

Lines changed: 167 additions & 151 deletions
Large diffs are not rendered by default.

front_end/panels/timeline/components/SidebarSingleInsightSet.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -437,6 +437,7 @@ export class SidebarSingleInsightSet extends HTMLElement {
437437

438438
const agentFocus = AIAssistance.AIContext.AgentFocus.fromInsight(this.#data.parsedTrace, model);
439439
// clang-format off
440+
/* eslint-disable lit/binding-positions,lit/no-invalid-html */
440441
return html`<div>
441442
<${componentClass.litTagName}
442443
.selected=${this.#data.activeInsight?.model === model}
@@ -452,6 +453,7 @@ export class SidebarSingleInsightSet extends HTMLElement {
452453
.fieldMetrics=${fieldMetrics}>
453454
</${componentClass.litTagName}>
454455
</div>`;
456+
/* eslint-enable lit/binding-positions,lit/no-invalid-html */
455457
// clang-format on
456458
};
457459

front_end/ui/components/markdown_view/MarkdownView.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,7 @@ export class MarkdownLitRenderer {
239239
case 'code':
240240
return this.renderCodeBlock(token);
241241
case 'space':
242+
// eslint-disable-next-line lit/prefer-nothing
242243
return html``;
243244
case 'link':
244245
return html`<devtools-markdown-link

node_modules/.package-lock.json

Lines changed: 50 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

node_modules/eslint-plugin-lit/LICENSE

Lines changed: 21 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

node_modules/eslint-plugin-lit/README.md

Lines changed: 145 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

node_modules/eslint-plugin-lit/custom_types/espree.d.ts

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)